[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

[Christian Ulmann via Phabricator via cfe-commits]

Dinistro added a comment.

Sorry for the noise. I didn't pull in between the different runs and was still 
on the broken version.
Thanks for fixing this issue :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148697/new/

https://reviews.llvm.org/D148697

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

[Christian Ulmann via Phabricator via cfe-commits]

Dinistro added a comment.

In D148697#4421643 , @PiotrZSL wrote:

> @Dinistro It compiles & links with clang 16 also (shared libs). So I'm unable 
> to reproduce.

I used the following command to build:

  cmake -S/home/christianu/repos/llvm-project/llvm 
-B/home/christianu/repos/llvm-project/build-clang-tidy -GNinja 
-DLLVM_ENABLE_LLD=ON -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" 
-DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_ASSERTIONS=ON -DBUILD_SHARED_LIBS=ON 
-DLLVM_INCLUDE_UTILS=ON -DLLVM_INSTALL_UTILS=ON -DLLVM_BUILD_EXAMPLES=OFF 
-DLLVM_CCACHE_BUILD=ON -DLLVM_OPTIMIZED_TABLEGEN=ON -DCMAKE_BUILD_TYPE=Debug 
-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ 
-DLLVM_ENABLE_RUNTIMES=openmp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148697/new/

https://reviews.llvm.org/D148697

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

[Christian Ulmann via Phabricator via cfe-commits]

Dinistro added a comment.

In D148697#4421420 , @PiotrZSL wrote:

> In D148697#4421339 , @Dinistro 
> wrote:
>
>> In D148697#4421268 , @PiotrZSL 
>> wrote:
>>
>>> In D148697#4420359 , @Dinistro 
>>> wrote:
>>>
 I'm getting a linking error by some of the files changed in this revision.
>>>
>>> You shouldn't because this library got dependency on 
>>> clangTidyPerformanceModule.
>>> Is this a blocker for you, or you can live with this for 1 day ? Until I 
>>> verify this.
>>
>> I don't necessarily need to build clang-tidy, so it's fine for now.
>
> I did a clean build with shared libraries enabled, everything is working.
> I do not get those issues. Try a clean-build. I will try to check build with 
> clang-16.

I tried with a clean build, and I get the exact same issues. Might be caused by 
the lld and clang-16 combination, not sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148697/new/

https://reviews.llvm.org/D148697

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

[Christian Ulmann via Phabricator via cfe-commits]

Dinistro added a comment.

In D148697#4421268 , @PiotrZSL wrote:

> In D148697#4420359 , @Dinistro 
> wrote:
>
>> I'm getting a linking error by some of the files changed in this revision.
>
> You shouldn't because this library got dependency on 
> clangTidyPerformanceModule.
> Is this a blocker for you, or you can live with this for 1 day ? Until I 
> verify this.

I don't necessarily need to build clang-tidy, so it's fine for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148697/new/

https://reviews.llvm.org/D148697

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

[Christian Ulmann via Phabricator via cfe-commits]

Dinistro added a comment.

I'm getting a linking error by some of the files changed in this revision.

  ld.lld: error: undefined symbol: vtable for 
clang::tidy::performance::NoexceptDestructorCheck
  >>> referenced by NoexceptDestructorCheck.h:26 
(/home/christianu/repos/llvm-project/clang-tools-extra/clang-tidy/cppcoreguidelines/../performance/NoexceptDestructorCheck.h:26)
  >>>   
tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/CppCoreGuidelinesTidyModule.cpp.o:(std::enable_if>, void 
clang::tidy::ClangTidyCheckFactories::registerCheck(ll
  vm::StringRef)::'lambda'(llvm::StringRef, clang::tidy::ClangTidyContext*)&, 
llvm::StringRef, clang::tidy::ClangTidyContext*>, 
std::unique_ptr>>::type 
std::__invoke_r>, void 
clang::tidy::ClangTidyCheckFactories::registerCheck
  
(llvm::StringRef)::'lambda'(llvm::StringRef,
 clang::tidy::ClangTidyContext*)&, llvm::StringRef, 
clang::tidy::ClangTidyContext*>(void clang::tidy::C
  
langTidyCheckFactories::registerCheck(llvm::StringRef)::'lambda'(llvm::StringRef,
 clang::tidy::ClangTidyContext*)&, llvm::StringRef&&, clang::tidy:
  :ClangTidyContext*&&))
  >>> the vtable symbol may be undefined because the class is missing its key 
function (see https://lld.llvm.org/missingkeyfunction)
  
  ld.lld: error: undefined symbol: vtable for 
clang::tidy::performance::NoexceptMoveConstructorCheck
  >>> referenced by NoexceptMoveConstructorCheck.h:30 
(/home/christianu/repos/llvm-project/clang-tools-extra/clang-tidy/cppcoreguidelines/../performance/NoexceptMoveConstructorCheck.h:30)
  >>>   
tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/CppCoreGuidelinesTidyModule.cpp.o:(std::enable_if>, void 
clang::tidy::ClangTidyCheckFactories::registerCheck(llvm::StringRef)::'lambda'(llvm::StringRef, 
clang::tidy::ClangTidyContext*)&, llvm::StringRef, 
clang::tidy::ClangTidyContext*>, std::unique_ptr>>::type 
std::__invoke_r>, void 
clang::tidy::ClangTidyCheckFactories::register
  
Check(llvm::StringRef)::'lambda'(llvm::StringRef,
 clang::tidy::ClangTidyContext*)&, llvm::StringRef, 
clang::tidy::ClangTidyContext*>(void clan
  
g::tidy::ClangTidyCheckFactories::registerCheck(llvm::StringRef)::'lambda'(llvm::StringRef,
 clang::tidy::ClangTidyContext*)&, llvm::StringRef&
  &, clang::tidy::ClangTidyContext*&&))
  >>> the vtable symbol may be undefined because the class is missing its key 
function (see https://lld.llvm.org/missingkeyfunction)
  
  ld.lld: error: undefined symbol: vtable for 
clang::tidy::performance::NoexceptSwapCheck
  >>> referenced by NoexceptSwapCheck.h:26 
(/home/christianu/repos/llvm-project/clang-tools-extra/clang-tidy/cppcoreguidelines/../performance/NoexceptSwapCheck.h:26)
  >>>   
tools/clang/tools/extra/clang-tidy/cppcoreguidelines/CMakeFiles/obj.clangTidyCppCoreGuidelinesModule.dir/CppCoreGuidelinesTidyModule.cpp.o:(std::enable_if>, void 
clang::tidy::ClangTidyCheckFactories::registerCheck(llvm::St
  ringRef)::'lambda'(llvm::StringRef, clang::tidy::ClangTidyContext*)&, 
llvm::StringRef, clang::tidy::ClangTidyContext*>, 
std::unique_ptr>>::type 
std::__invoke_r>, void 
clang::tidy::ClangTidyCheckFactories::registerCheck(llvm::StringRef)::'lambda'(llvm::StringRef,
 clang::tidy::ClangTidyContext*)&, llvm::StringRef, 
clang::tidy::ClangTidyContext*>(void clang::tidy::ClangTidyChec
  
kFactories::registerCheck(llvm::StringRef)::'lambda'(llvm::StringRef,
 clang::tidy::ClangTidyContext*)&, llvm::StringRef&&, 
clang::tidy::ClangTidyContext*
  &&))
  >>> the vtable symbol may be undefined because the class is missing its key 
function (see https://lld.llvm.org/missingkeyfunction)
  clang-16: error: linker command failed with exit code 1 (use -v to see 
invocation)

I'm building with shared libraries on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148697/new/

https://reviews.llvm.org/D148697

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

[Christian Ulmann via Phabricator via cfe-commits]

Dinistro added a comment.

Thanks for fixing this issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152802/new/

https://reviews.llvm.org/D152802

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

[Christian Ulmann via Phabricator via cfe-commits]

Dinistro added inline comments.



Comment at: llvm/unittests/ProfileData/InstrProfTest.cpp:1359
   auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile));
   ASSERT_TRUE(InstrProfError::take(RawProfileReaderOrErr.takeError()) ==
   instrprof_error::unrecognized_format);

Dinistro wrote:
> It seems that this and the following similar line do not compile. I assume 
> that the necessary flags to activate this test were not provided in the CI 
> executed for this revision. 
> 
> Crashing build: 
> https://lab.llvm.org/buildbot/#/builders/104/builds/11668/steps/6/logs/stdio
I creatred and landed a revision that fixes this 
https://reviews.llvm.org/D149434


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149361/new/

https://reviews.llvm.org/D149361

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

[Christian Ulmann via Phabricator via cfe-commits]

Dinistro added inline comments.



Comment at: llvm/unittests/ProfileData/InstrProfTest.cpp:1359
   auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile));
   ASSERT_TRUE(InstrProfError::take(RawProfileReaderOrErr.takeError()) ==
   instrprof_error::unrecognized_format);

It seems that this and the following similar line do not compile. I assume that 
the necessary flags to activate this test were not provided in the CI executed 
for this revision. 

Crashing build: 
https://lab.llvm.org/buildbot/#/builders/104/builds/11668/steps/6/logs/stdio


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149361/new/

https://reviews.llvm.org/D149361

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits