[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

[Hongbin Zheng via Phabricator via cfe-commits]

etherzhhb added a comment.

Thanks, I will commit tonight. If you want this patch before that, you could 
commit it for me.


Repository:
  rC Clang

https://reviews.llvm.org/D42227



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

[Hongbin Zheng via Phabricator via cfe-commits]

etherzhhb created this revision.
etherzhhb added reviewers: aaron.ballman, echristo.
Herald added a subscriber: cfe-commits.

Simple change to use Use enum instead of magic number in 
handleX86ForceAlignArgPointerAttr. No functional change


Repository:
  rC Clang

https://reviews.llvm.org/D42227

Files:
  lib/Sema/SemaDeclAttr.cpp


Index: lib/Sema/SemaDeclAttr.cpp
===
--- lib/Sema/SemaDeclAttr.cpp
+++ lib/Sema/SemaDeclAttr.cpp
@@ -5554,7 +5554,7 @@
   // Attribute can only be applied to function types.
   if (!isa(D)) {
 S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type)
-  << Attr.getName() << /* function */0;
+  << Attr.getName() << ExpectedFunction;
 return;
   }
 


Index: lib/Sema/SemaDeclAttr.cpp
===
--- lib/Sema/SemaDeclAttr.cpp
+++ lib/Sema/SemaDeclAttr.cpp
@@ -5554,7 +5554,7 @@
   // Attribute can only be applied to function types.
   if (!isa(D)) {
 S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type)
-  << Attr.getName() << /* function */0;
+  << Attr.getName() << ExpectedFunction;
 return;
   }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28050: [Clang][Driver] Clean up Clang::ConstructJob a little bit, NFC

[Hongbin Zheng via Phabricator via cfe-commits]

etherzhhb added a comment.

In https://reviews.llvm.org/D28050#660715, @ahatanak wrote:

> I think this patch is an improvement, but Clang::ConstructJob is still one 
> giant function.
>
> Do you have ideas to improve readability of this function or plans to further 
> reduce its size?


I am trying to identify the self-contained chunks and extra them


Repository:
  rL LLVM

https://reviews.llvm.org/D28050



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits