[clang] 7419792 - [clang][examples] Fix build failure (NFC)
Author: Jie Fu Date: 2024-06-29T21:42:26+08:00 New Revision: 74197925dcb144ba31c7abfc61494c31c03d1f64 URL: https://github.com/llvm/llvm-project/commit/74197925dcb144ba31c7abfc61494c31c03d1f64 DIFF: https://github.com/llvm/llvm-project/commit/74197925dcb144ba31c7abfc61494c31c03d1f64.diff LOG: [clang][examples] Fix build failure (NFC) /llvm-project/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp:36:20: error: cannot use incomplete type 'llvm::Module' as a range for (auto : M) ^ Added: Modified: clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp Removed: diff --git a/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp b/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp index 6cb87e4b5e19c..79a315d5a4ee2 100644 --- a/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp +++ b/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp @@ -18,6 +18,7 @@ #include "clang/Frontend/CompilerInstance.h" #include "clang/Frontend/FrontendPluginRegistry.h" #include "clang/Sema/Sema.h" +#include "llvm/IR/Module.h" #include "llvm/IR/PassManager.h" #include "llvm/Passes/OptimizationLevel.h" #include "llvm/Passes/PassBuilder.h" ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] c69ea04 - Revert "[clangd] Fix the build broken (NFC)"
Author: Jie Fu
Date: 2024-06-25T21:30:02+08:00
New Revision: c69ea04fb9738db283263eb350669e00b77ee4fd
URL:
https://github.com/llvm/llvm-project/commit/c69ea04fb9738db283263eb350669e00b77ee4fd
DIFF:
https://github.com/llvm/llvm-project/commit/c69ea04fb9738db283263eb350669e00b77ee4fd.diff
LOG: Revert "[clangd] Fix the build broken (NFC)"
This reverts commit 4c91b49bab0728d4bc136aa33c4aeb4e8ea37d01 after
70cfece24d6cbb57e35dd961cc97eb2a6bf1e387.
Added:
Modified:
clang-tools-extra/clangd/Format.cpp
Removed:
diff --git a/clang-tools-extra/clangd/Format.cpp
b/clang-tools-extra/clangd/Format.cpp
index fc56a1c8c5030..272a34d4ed797 100644
--- a/clang-tools-extra/clangd/Format.cpp
+++ b/clang-tools-extra/clangd/Format.cpp
@@ -281,7 +281,7 @@ formatIncremental(llvm::StringRef OriginalCode, unsigned
OriginalCursor,
// Never *remove* lines in response to pressing enter! This annoys users.
if (InsertedText == "\n") {
Style.MaxEmptyLinesToKeep = 1000;
-Style.KeepEmptyLines.AtStartOfBlock = true;
+Style.KeepEmptyLinesAtTheStartOfBlocks = true;
}
// Compute the code we want to format:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] 4c91b49 - [clangd] Fix the build broken (NFC)
Author: Jie Fu
Date: 2024-06-25T14:51:57+08:00
New Revision: 4c91b49bab0728d4bc136aa33c4aeb4e8ea37d01
URL:
https://github.com/llvm/llvm-project/commit/4c91b49bab0728d4bc136aa33c4aeb4e8ea37d01
DIFF:
https://github.com/llvm/llvm-project/commit/4c91b49bab0728d4bc136aa33c4aeb4e8ea37d01.diff
LOG: [clangd] Fix the build broken (NFC)
/llvm-project/clang-tools-extra/clangd/Format.cpp:284:11:
error: no member named 'KeepEmptyLinesAtTheStartOfBlocks' in
'clang::format::FormatStyle'
Style.KeepEmptyLinesAtTheStartOfBlocks = true;
~ ^
1 error generated.
Added:
Modified:
clang-tools-extra/clangd/Format.cpp
Removed:
diff --git a/clang-tools-extra/clangd/Format.cpp
b/clang-tools-extra/clangd/Format.cpp
index 272a34d4ed797..fc56a1c8c5030 100644
--- a/clang-tools-extra/clangd/Format.cpp
+++ b/clang-tools-extra/clangd/Format.cpp
@@ -281,7 +281,7 @@ formatIncremental(llvm::StringRef OriginalCode, unsigned
OriginalCursor,
// Never *remove* lines in response to pressing enter! This annoys users.
if (InsertedText == "\n") {
Style.MaxEmptyLinesToKeep = 1000;
-Style.KeepEmptyLinesAtTheStartOfBlocks = true;
+Style.KeepEmptyLines.AtStartOfBlock = true;
}
// Compute the code we want to format:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] efab4a3 - [Sema] Fix -Wunused-variable in SemaType.cpp (NFC)
Author: Jie Fu Date: 2024-06-24T19:40:35+08:00 New Revision: efab4a380f36dcd23561633f8bba484036c500f3 URL: https://github.com/llvm/llvm-project/commit/efab4a380f36dcd23561633f8bba484036c500f3 DIFF: https://github.com/llvm/llvm-project/commit/efab4a380f36dcd23561633f8bba484036c500f3.diff LOG: [Sema] Fix -Wunused-variable in SemaType.cpp (NFC) /llvm-project/clang/lib/Sema/SemaType.cpp:7625:8: error: unused variable 'Success' [-Werror,-Wunused-variable] bool Success = FX.insert(NewEC, Errs); ^ 1 error generated. Added: Modified: clang/lib/Sema/SemaType.cpp Removed: diff --git a/clang/lib/Sema/SemaType.cpp b/clang/lib/Sema/SemaType.cpp index 426cd0aa91c01..53b9083c95c1b 100644 --- a/clang/lib/Sema/SemaType.cpp +++ b/clang/lib/Sema/SemaType.cpp @@ -7622,7 +7622,7 @@ handleNonBlockingNonAllocatingTypeAttr(TypeProcessingState , FunctionProtoType::ExtProtoInfo EPI = FPT->getExtProtoInfo(); FunctionEffectSet FX(EPI.FunctionEffects); FunctionEffectSet::Conflicts Errs; - bool Success = FX.insert(NewEC, Errs); + [[maybe_unused]] bool Success = FX.insert(NewEC, Errs); assert(Success && "effect conflicts should have been diagnosed above"); EPI.FunctionEffects = FunctionEffectsRef(FX); ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 24c6409 - [clang] Fix -Wunused-variable in ByteCodeStmtGen.cpp (NFC)
Author: Jie Fu
Date: 2024-04-26T17:53:31+08:00
New Revision: 24c6409d56e43a7af3f6be6dd3e7267e243fb162
URL:
https://github.com/llvm/llvm-project/commit/24c6409d56e43a7af3f6be6dd3e7267e243fb162
DIFF:
https://github.com/llvm/llvm-project/commit/24c6409d56e43a7af3f6be6dd3e7267e243fb162.diff
LOG: [clang] Fix -Wunused-variable in ByteCodeStmtGen.cpp (NFC)
llvm-project/clang/lib/AST/Interp/ByteCodeStmtGen.cpp:196:31:
error: unused variable 'B' [-Werror,-Wunused-variable]
const Record::Base *B = R->getVirtualBase(BaseDecl);
^
1 error generated.
Added:
Modified:
clang/lib/AST/Interp/ByteCodeStmtGen.cpp
Removed:
diff --git a/clang/lib/AST/Interp/ByteCodeStmtGen.cpp
b/clang/lib/AST/Interp/ByteCodeStmtGen.cpp
index 9b8e64f1138559..ec2fe39a8aeae9 100644
--- a/clang/lib/AST/Interp/ByteCodeStmtGen.cpp
+++ b/clang/lib/AST/Interp/ByteCodeStmtGen.cpp
@@ -193,8 +193,7 @@ bool ByteCodeStmtGen::visitFunc(const FunctionDecl
*F) {
assert(BaseDecl);
if (Init->isBaseVirtual()) {
- const Record::Base *B = R->getVirtualBase(BaseDecl);
- assert(B);
+ assert(R->getVirtualBase(BaseDecl));
if (!this->emitGetPtrThisVirtBase(BaseDecl, InitExpr))
return false;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 609ee9f - [clang] Remove unused lambda capture (NFC)
Author: Jie Fu
Date: 2024-04-18T15:49:52+08:00
New Revision: 609ee9fe6a96113c893e8344f0dfaef5eba73e3d
URL:
https://github.com/llvm/llvm-project/commit/609ee9fe6a96113c893e8344f0dfaef5eba73e3d
DIFF:
https://github.com/llvm/llvm-project/commit/609ee9fe6a96113c893e8344f0dfaef5eba73e3d.diff
LOG: [clang] Remove unused lambda capture (NFC)
llvm-project/clang/lib/Serialization/ASTWriter.cpp:5077:59:
error: lambda capture 'SemaRef' is not used [-Werror,-Wunused-lambda-capture]
auto AddEmittedDeclRefOrZero = [this, , ](Decl *D) {
~~~^~~
1 error generated.
Added:
Modified:
clang/lib/Serialization/ASTWriter.cpp
Removed:
diff --git a/clang/lib/Serialization/ASTWriter.cpp
b/clang/lib/Serialization/ASTWriter.cpp
index 522b8ce56c3266..2eb4adac53de2a 100644
--- a/clang/lib/Serialization/ASTWriter.cpp
+++ b/clang/lib/Serialization/ASTWriter.cpp
@@ -5074,7 +5074,7 @@ void ASTWriter::WriteSpecialDeclRecords(Sema ) {
// Write the record containing declaration references of Sema.
RecordData SemaDeclRefs;
if (SemaRef.StdNamespace || SemaRef.StdBadAlloc || SemaRef.StdAlignValT) {
-auto AddEmittedDeclRefOrZero = [this, , ](Decl *D) {
+auto AddEmittedDeclRefOrZero = [this, ](Decl *D) {
if (!D || !wasDeclEmitted(D))
SemaDeclRefs.push_back(0);
else
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 6e934b7 - [clang] Fix -Wunused-variable in SemaCast.cpp (NFC)
Author: Jie Fu
Date: 2024-04-14T20:34:26+08:00
New Revision: 6e934b7cfba8e0c167d2b287a30dfc1b720397c1
URL:
https://github.com/llvm/llvm-project/commit/6e934b7cfba8e0c167d2b287a30dfc1b720397c1
DIFF:
https://github.com/llvm/llvm-project/commit/6e934b7cfba8e0c167d2b287a30dfc1b720397c1.diff
LOG: [clang] Fix -Wunused-variable in SemaCast.cpp (NFC)
llvm-project/clang/lib/Sema/SemaCast.cpp:503:23:
error: unused variable 'Res' [-Werror,-Wunused-variable]
OverloadingResult Res =
^
1 error generated.
Added:
Modified:
clang/lib/Sema/SemaCast.cpp
Removed:
diff --git a/clang/lib/Sema/SemaCast.cpp b/clang/lib/Sema/SemaCast.cpp
index aac43e2cad603f..b0c28531fe8738 100644
--- a/clang/lib/Sema/SemaCast.cpp
+++ b/clang/lib/Sema/SemaCast.cpp
@@ -500,7 +500,7 @@ static bool tryDiagnoseOverloadedCast(Sema , CastType CT,
case OR_Deleted: {
OverloadCandidateSet::iterator Best;
-OverloadingResult Res =
+[[maybe_unused]] OverloadingResult Res =
candidates.BestViableFunction(S, range.getBegin(), Best);
assert(Res == OR_Deleted && "Inconsistent overload resolution");
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 6ef4450 - [clang] Fix -Wunused-function in CGStmtOpenMP.cpp (NFC)
Author: Jie Fu
Date: 2024-04-11T07:37:12+08:00
New Revision: 6ef4450705473e5cccb025219e8980999f456b71
URL:
https://github.com/llvm/llvm-project/commit/6ef4450705473e5cccb025219e8980999f456b71
DIFF:
https://github.com/llvm/llvm-project/commit/6ef4450705473e5cccb025219e8980999f456b71.diff
LOG: [clang] Fix -Wunused-function in CGStmtOpenMP.cpp (NFC)
llvm-project/clang/lib/CodeGen/CGStmtOpenMP.cpp:7959:13:
error: unused function 'emitTargetTeamsLoopCodegenStatus'
[-Werror,-Wunused-function]
static void emitTargetTeamsLoopCodegenStatus(CodeGenFunction ,
^
1 error generated.
Added:
Modified:
clang/lib/CodeGen/CGStmtOpenMP.cpp
Removed:
diff --git a/clang/lib/CodeGen/CGStmtOpenMP.cpp
b/clang/lib/CodeGen/CGStmtOpenMP.cpp
index 3bf99366b69ced..a0a8a07c76ba16 100644
--- a/clang/lib/CodeGen/CGStmtOpenMP.cpp
+++ b/clang/lib/CodeGen/CGStmtOpenMP.cpp
@@ -7956,10 +7956,10 @@ void CodeGenFunction::EmitOMPTeamsGenericLoopDirective(
[](CodeGenFunction &) { return nullptr; });
}
+#ifndef NDEBUG
static void emitTargetTeamsLoopCodegenStatus(CodeGenFunction ,
std::string StatusMsg,
const OMPExecutableDirective ) {
-#ifndef NDEBUG
bool IsDevice = CGF.CGM.getLangOpts().OpenMPIsTargetDevice;
if (IsDevice)
StatusMsg += ": DEVICE";
@@ -7972,8 +7972,8 @@ static void
emitTargetTeamsLoopCodegenStatus(CodeGenFunction ,
unsigned LineNo =
PLoc.isValid() ? PLoc.getLine() : SM.getExpansionLineNumber(L);
llvm::dbgs() << StatusMsg << ": " << FileName << ": " << LineNo << "\n";
-#endif
}
+#endif
static void emitTargetTeamsGenericLoopRegionAsParallel(
CodeGenFunction , PrePostActionTy ,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] feebcd6 - [clang] Fix -Wunused-variable in SemaDecl.cpp (NFC)
Author: Jie Fu
Date: 2024-03-26T20:41:46+08:00
New Revision: feebcd65fb7e0534f5219e05432a05e45aa8cd2a
URL:
https://github.com/llvm/llvm-project/commit/feebcd65fb7e0534f5219e05432a05e45aa8cd2a
DIFF:
https://github.com/llvm/llvm-project/commit/feebcd65fb7e0534f5219e05432a05e45aa8cd2a.diff
LOG: [clang] Fix -Wunused-variable in SemaDecl.cpp (NFC)
llvm-project/clang/lib/Sema/SemaDecl.cpp:11653:20:
error: unused variable 'OldMVKind' [-Werror,-Wunused-variable]
MultiVersionKind OldMVKind = OldFD->getMultiVersionKind();
^
1 error generated.
Added:
Modified:
clang/lib/Sema/SemaDecl.cpp
Removed:
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index 9a286e0b26a4c6..b907fee01d5f26 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -11650,7 +11650,7 @@ static bool CheckMultiVersionAdditionalDecl(
const auto *NewTA = NewFD->getAttr();
const auto *NewTVA = NewFD->getAttr();
MultiVersionKind NewMVKind = NewFD->getMultiVersionKind();
- MultiVersionKind OldMVKind = OldFD->getMultiVersionKind();
+ [[maybe_unused]] MultiVersionKind OldMVKind = OldFD->getMultiVersionKind();
ParsedTargetAttr NewParsed;
if (NewTA) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 611d5ae - [clang] Fix -Wunused-variable in InterpBuiltin.cpp (NFC)
Author: Jie Fu
Date: 2024-03-14T21:55:23+08:00
New Revision: 611d5aec1de59fe567162158347c6c2ea29ff4d8
URL:
https://github.com/llvm/llvm-project/commit/611d5aec1de59fe567162158347c6c2ea29ff4d8
DIFF:
https://github.com/llvm/llvm-project/commit/611d5aec1de59fe567162158347c6c2ea29ff4d8.diff
LOG: [clang] Fix -Wunused-variable in InterpBuiltin.cpp (NFC)
llvm-project/clang/lib/AST/Interp/InterpBuiltin.cpp:1332:21:
error: unused variable 'SrcDesc' [-Werror,-Wunused-variable]
const Descriptor *SrcDesc = Src.getFieldDesc();
^
1 error generated.
Added:
Modified:
clang/lib/AST/Interp/InterpBuiltin.cpp
Removed:
diff --git a/clang/lib/AST/Interp/InterpBuiltin.cpp
b/clang/lib/AST/Interp/InterpBuiltin.cpp
index 8113254f8fa8e2..8bbe881bb4b928 100644
--- a/clang/lib/AST/Interp/InterpBuiltin.cpp
+++ b/clang/lib/AST/Interp/InterpBuiltin.cpp
@@ -1329,7 +1329,7 @@ bool SetThreeWayComparisonField(InterpState , CodePtr
OpPC,
bool DoMemcpy(InterpState , CodePtr OpPC, const Pointer , Pointer )
{
assert(Src.isLive() && Dest.isLive());
- const Descriptor *SrcDesc = Src.getFieldDesc();
+ [[maybe_unused]] const Descriptor *SrcDesc = Src.getFieldDesc();
const Descriptor *DestDesc = Dest.getFieldDesc();
assert(!DestDesc->isPrimitive() && !SrcDesc->isPrimitive());
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] f03aaa3 - [clang] Silence -Wlogical-op-parentheses in Clang.cpp (NFC)
Author: Jie Fu Date: 2024-03-12T21:24:37+08:00 New Revision: f03aaa3c0cca77c15adfbb4544f296bc0441f6fc URL: https://github.com/llvm/llvm-project/commit/f03aaa3c0cca77c15adfbb4544f296bc0441f6fc DIFF: https://github.com/llvm/llvm-project/commit/f03aaa3c0cca77c15adfbb4544f296bc0441f6fc.diff LOG: [clang] Silence -Wlogical-op-parentheses in Clang.cpp (NFC) llvm-project/clang/lib/Driver/ToolChains/Clang.cpp:2721:49: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses] !Option.empty() && !NegateFortranOption && !NegateLimitedOption) ^~~ llvm-project/clang/lib/Driver/ToolChains/Clang.cpp:2721:49: note: place parentheses around the '&&' expression to silence this warning !Option.empty() && !NegateFortranOption && !NegateLimitedOption) ^ ( ) 1 error generated. Added: Modified: clang/lib/Driver/ToolChains/Clang.cpp Removed: diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 6246a28a13060e..3a7a1cf99c79ac 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -2718,7 +2718,7 @@ static void EmitComplexRangeDiag(const Driver , Option == "-fno-cx-limited-range"; } if (Option.empty() || -!Option.empty() && !NegateFortranOption && !NegateLimitedOption) +(!Option.empty() && !NegateFortranOption && !NegateLimitedOption)) D.Diag(clang::diag::warn_drv_overriding_option) << EnumComplexRangeToStr(Range1, Option) << EnumComplexRangeToStr(Range2, Option); ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 83fe0b1 - [clang] Fix -Wunused-lambda-capture in TokenAnnotator.cpp (NFC)
Author: Jie Fu
Date: 2024-03-09T20:26:10+08:00
New Revision: 83fe0b13824bc419092bad47727aa1c8ca69330a
URL:
https://github.com/llvm/llvm-project/commit/83fe0b13824bc419092bad47727aa1c8ca69330a
DIFF:
https://github.com/llvm/llvm-project/commit/83fe0b13824bc419092bad47727aa1c8ca69330a.diff
LOG: [clang] Fix -Wunused-lambda-capture in TokenAnnotator.cpp (NFC)
llvm-project/clang/lib/Format/TokenAnnotator.cpp:2707:43:
error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
auto IsQualifiedPointerOrReference = [this](FormatToken *T) {
^~~~
1 error generated.
Added:
Modified:
clang/lib/Format/TokenAnnotator.cpp
Removed:
diff --git a/clang/lib/Format/TokenAnnotator.cpp
b/clang/lib/Format/TokenAnnotator.cpp
index 3a5510661200e8..d7b84e309e0964 100644
--- a/clang/lib/Format/TokenAnnotator.cpp
+++ b/clang/lib/Format/TokenAnnotator.cpp
@@ -2707,6 +2707,7 @@ class AnnotatingParser {
auto IsQualifiedPointerOrReference = [this](FormatToken *T) {
// This is used to handle cases such as x = (foo *const)
assert(!T->isTypeName(IsCpp) && "Should have already been checked");
+ (void)IsCpp; // Avoid -Wunused-lambda-capture when assertion is disabled.
// Strip trailing qualifiers such as const or volatile when checking
// whether the parens could be a cast to a pointer/reference type.
while (T) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 881df55 - [clang] Fix -Wunused-variable in SemaChecking.cpp (NFC)
Author: Jie Fu
Date: 2024-03-08T17:03:51+08:00
New Revision: 881df557501d339c7a14b16d68e43da5c732b424
URL:
https://github.com/llvm/llvm-project/commit/881df557501d339c7a14b16d68e43da5c732b424
DIFF:
https://github.com/llvm/llvm-project/commit/881df557501d339c7a14b16d68e43da5c732b424.diff
LOG: [clang] Fix -Wunused-variable in SemaChecking.cpp (NFC)
llvm-project/clang/lib/Sema/SemaChecking.cpp:19192:15:
error: unused variable 'Field1Parent' [-Werror,-Wunused-variable]
const Type *Field1Parent = Field1->getParent()->getTypeForDecl();
^
llvm-project/clang/lib/Sema/SemaChecking.cpp:19193:15:
error: unused variable 'Field2Parent' [-Werror,-Wunused-variable]
const Type *Field2Parent = Field2->getParent()->getTypeForDecl();
^
2 errors generated.
Added:
Modified:
clang/lib/Sema/SemaChecking.cpp
Removed:
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index b34b8df0020137..a5f42b630c3fa2 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -19189,8 +19189,10 @@ static bool isLayoutCompatible(ASTContext , EnumDecl
*ED1, EnumDecl *ED2) {
static bool isLayoutCompatible(ASTContext , FieldDecl *Field1,
FieldDecl *Field2,
bool AreUnionMembers = false) {
- const Type *Field1Parent = Field1->getParent()->getTypeForDecl();
- const Type *Field2Parent = Field2->getParent()->getTypeForDecl();
+ [[maybe_unused]] const Type *Field1Parent =
+ Field1->getParent()->getTypeForDecl();
+ [[maybe_unused]] const Type *Field2Parent =
+ Field2->getParent()->getTypeForDecl();
assert(((Field1Parent->isStructureOrClassType() &&
Field2Parent->isStructureOrClassType()) ||
(Field1Parent->isUnionType() && Field2Parent->isUnionType())) &&
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] a4703e5 - [clang] Remove std::move in GenerateModuleAction::CreateMultiplexConsumer (NFC)
Author: Jie Fu Date: 2024-03-08T10:19:07+08:00 New Revision: a4703e5bccc63eca45e0e4bff8f04f82d8622ebe URL: https://github.com/llvm/llvm-project/commit/a4703e5bccc63eca45e0e4bff8f04f82d8622ebe DIFF: https://github.com/llvm/llvm-project/commit/a4703e5bccc63eca45e0e4bff8f04f82d8622ebe.diff LOG: [clang] Remove std::move in GenerateModuleAction::CreateMultiplexConsumer (NFC) llvm-project/clang/lib/Frontend/FrontendActions.cpp:213:10: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move] 213 | return std::move(Consumers); | ^ /Users/jiefu/llvm-project/clang/lib/Frontend/FrontendActions.cpp:213:10: note: remove std::move call here 213 | return std::move(Consumers); | ^~ ~ 1 error generated. Added: Modified: clang/lib/Frontend/FrontendActions.cpp Removed: diff --git a/clang/lib/Frontend/FrontendActions.cpp b/clang/lib/Frontend/FrontendActions.cpp index cd9b9923421c69..50338bfa670f83 100644 --- a/clang/lib/Frontend/FrontendActions.cpp +++ b/clang/lib/Frontend/FrontendActions.cpp @@ -210,7 +210,7 @@ GenerateModuleAction::CreateMultiplexConsumer(CompilerInstance , +CI.getFrontendOpts().BuildingImplicitModule)); Consumers.push_back(CI.getPCHContainerWriter().CreatePCHContainerGenerator( CI, std::string(InFile), OutputFile, std::move(OS), Buffer)); - return std::move(Consumers); + return Consumers; } std::unique_ptr ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 6ed67ca - [clang] Remove unused-lambda-capture in AArch64.cpp (NFC)
Author: Jie Fu
Date: 2024-03-01T17:37:11+08:00
New Revision: 6ed67ca14cd05596a8253eeceb247d2743e00f6e
URL:
https://github.com/llvm/llvm-project/commit/6ed67ca14cd05596a8253eeceb247d2743e00f6e
DIFF:
https://github.com/llvm/llvm-project/commit/6ed67ca14cd05596a8253eeceb247d2743e00f6e.diff
LOG: [clang] Remove unused-lambda-capture in AArch64.cpp (NFC)
llvm-project/clang/lib/CodeGen/Targets/AArch64.cpp:886:26:
error: lambda capture 'TI' is not used [-Werror,-Wunused-lambda-capture]
886 | llvm::sort(Features, [](const StringRef LHS, const StringRef RHS) {
| ~^~
1 error generated.
Added:
Modified:
clang/lib/CodeGen/Targets/AArch64.cpp
Removed:
diff --git a/clang/lib/CodeGen/Targets/AArch64.cpp
b/clang/lib/CodeGen/Targets/AArch64.cpp
index 79a9c1d5978a14..725e8a70fddfe6 100644
--- a/clang/lib/CodeGen/Targets/AArch64.cpp
+++ b/clang/lib/CodeGen/Targets/AArch64.cpp
@@ -882,8 +882,7 @@ void AArch64ABIInfo::appendAttributeMangling(StringRef
AttrStr,
for (auto : Features)
Feat = Feat.trim();
- const TargetInfo = CGT.getTarget();
- llvm::sort(Features, [](const StringRef LHS, const StringRef RHS) {
+ llvm::sort(Features, [](const StringRef LHS, const StringRef RHS) {
return LHS.compare(RHS) < 0;
});
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 27b297b - [clang] Fix -Wunused-variable in CGCall.cpp (NFC)
Author: Jie Fu
Date: 2024-02-28T20:58:20+08:00
New Revision: 27b297bf21b6637047c1ac403f983351b9a3fc64
URL:
https://github.com/llvm/llvm-project/commit/27b297bf21b6637047c1ac403f983351b9a3fc64
DIFF:
https://github.com/llvm/llvm-project/commit/27b297bf21b6637047c1ac403f983351b9a3fc64.diff
LOG: [clang] Fix -Wunused-variable in CGCall.cpp (NFC)
llvm-project/clang/lib/CodeGen/CGCall.cpp:3226:24:
error: unused variable 'StructSize' [-Werror,-Wunused-variable]
llvm::TypeSize StructSize = CGM.getDataLayout().getTypeAllocSize(STy);
^
llvm-project/clang/lib/CodeGen/CGCall.cpp:3227:24:
error: unused variable 'PtrElementSize' [-Werror,-Wunused-variable]
llvm::TypeSize PtrElementSize =
^
llvm-project/clang/lib/CodeGen/CGCall.cpp:5313:24:
error: unused variable 'SrcTypeSize' [-Werror,-Wunused-variable]
llvm::TypeSize SrcTypeSize =
^
llvm-project/clang/lib/CodeGen/CGCall.cpp:5315:24:
error: unused variable 'DstTypeSize' [-Werror,-Wunused-variable]
llvm::TypeSize DstTypeSize = CGM.getDataLayout().getTypeAllocSize(STy);
^
4 errors generated.
Added:
Modified:
clang/lib/CodeGen/CGCall.cpp
Removed:
diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp
index 0d86fcf544d0fd..13f68237b464d6 100644
--- a/clang/lib/CodeGen/CGCall.cpp
+++ b/clang/lib/CodeGen/CGCall.cpp
@@ -3223,8 +3223,9 @@ void CodeGenFunction::EmitFunctionProlog(const
CGFunctionInfo ,
dyn_cast(ArgI.getCoerceToType());
if (ArgI.isDirect() && !ArgI.getCanBeFlattened() && STy &&
STy->getNumElements() > 1) {
-llvm::TypeSize StructSize = CGM.getDataLayout().getTypeAllocSize(STy);
-llvm::TypeSize PtrElementSize =
+[[maybe_unused]] llvm::TypeSize StructSize =
+CGM.getDataLayout().getTypeAllocSize(STy);
+[[maybe_unused]] llvm::TypeSize PtrElementSize =
CGM.getDataLayout().getTypeAllocSize(ConvertTypeForMem(Ty));
if (STy->containsHomogeneousScalableVectorTypes()) {
assert(StructSize == PtrElementSize &&
@@ -5310,9 +5311,10 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo
,
dyn_cast(ArgInfo.getCoerceToType());
if (STy && ArgInfo.isDirect() && !ArgInfo.getCanBeFlattened()) {
llvm::Type *SrcTy = ConvertTypeForMem(I->Ty);
-llvm::TypeSize SrcTypeSize =
+[[maybe_unused]] llvm::TypeSize SrcTypeSize =
CGM.getDataLayout().getTypeAllocSize(SrcTy);
-llvm::TypeSize DstTypeSize = CGM.getDataLayout().getTypeAllocSize(STy);
+[[maybe_unused]] llvm::TypeSize DstTypeSize =
+CGM.getDataLayout().getTypeAllocSize(STy);
if (STy->containsHomogeneousScalableVectorTypes()) {
assert(SrcTypeSize == DstTypeSize &&
"Only allow non-fractional movement of structure with "
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] 8ce1448 - [clangd][test] Fix -Wmissing-field-initializers in DiagnosticsTests.cpp (NFC)
Author: Jie Fu
Date: 2024-02-15T10:17:58+08:00
New Revision: 8ce144800a7ed7c1e42343b3a9ac5e0ffdbfddbf
URL:
https://github.com/llvm/llvm-project/commit/8ce144800a7ed7c1e42343b3a9ac5e0ffdbfddbf
DIFF:
https://github.com/llvm/llvm-project/commit/8ce144800a7ed7c1e42343b3a9ac5e0ffdbfddbf.diff
LOG: [clangd][test] Fix -Wmissing-field-initializers in DiagnosticsTests.cpp
(NFC)
llvm-project/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:921:45:
error: missing field 'Annotations' initializer
[-Werror,-Wmissing-field-initializers]
TextEdit{Main.range("virtual1"), ""}}};
^
llvm-project/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:926:45:
error: missing field 'Annotations' initializer
[-Werror,-Wmissing-field-initializers]
TextEdit{Main.range("virtual2"), ""}}};
^
2 errors generated.
Added:
Modified:
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
Removed:
diff --git a/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
b/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
index 4839879e1b78c8..2f6dd0611b6621 100644
--- a/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
+++ b/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
@@ -918,12 +918,14 @@ TEST(DiagnosticTest,
ClangTidySelfContainedDiagsFormatting) {
"prefer using 'override' or (rarely) 'final' "
"instead of 'virtual'",
{TextEdit{Main.range("override1"), " override"},
- TextEdit{Main.range("virtual1"), ""}}};
+ TextEdit{Main.range("virtual1"), ""}},
+ {}};
clangd::Fix const ExpectedFix2{
"prefer using 'override' or (rarely) 'final' "
"instead of 'virtual'",
{TextEdit{Main.range("override2"), " override"},
- TextEdit{Main.range("virtual2"), ""}}};
+ TextEdit{Main.range("virtual2"), ""}},
+ {}};
// Note that in the Fix we expect the "virtual" keyword and the following
// whitespace to be deleted
EXPECT_THAT(TU.build().getDiagnostics(),
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 1b60ddd - [Hurd] Fix -Wswitch in Hurd::getDynamicLinker (NFC)
Author: Jie Fu
Date: 2024-01-18T07:34:09+08:00
New Revision: 1b60ddd920e0caadfa85cc7013b559d6453d7e3e
URL:
https://github.com/llvm/llvm-project/commit/1b60ddd920e0caadfa85cc7013b559d6453d7e3e
DIFF:
https://github.com/llvm/llvm-project/commit/1b60ddd920e0caadfa85cc7013b559d6453d7e3e.diff
LOG: [Hurd] Fix -Wswitch in Hurd::getDynamicLinker (NFC)
llvm-project/clang/lib/Driver/ToolChains/Hurd.cpp:137:11:
error: 60 enumeration values not handled in switch: 'UnknownArch', 'arm',
'armeb'... [-Werror,-Wswitch]
switch (getArch()) {
^
1 error generated.
Added:
Modified:
clang/lib/Driver/ToolChains/Hurd.cpp
Removed:
diff --git a/clang/lib/Driver/ToolChains/Hurd.cpp
b/clang/lib/Driver/ToolChains/Hurd.cpp
index 5074eda5f41559..0bc114b90ffc09 100644
--- a/clang/lib/Driver/ToolChains/Hurd.cpp
+++ b/clang/lib/Driver/ToolChains/Hurd.cpp
@@ -139,6 +139,8 @@ std::string Hurd::getDynamicLinker(const ArgList )
const {
return "/lib/ld.so";
case llvm::Triple::x86_64:
return "/lib/ld-x86-64.so.1";
+ default:
+break;
}
llvm_unreachable("unsupported architecture");
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] fbac3b0 - Revert "[clang][dataflow] Remove unused private field 'StmtToEnv' (NFC)"
Author: Jie Fu
Date: 2024-01-12T17:17:39+08:00
New Revision: fbac3b0db5ff1d409f90219aeb6460ec5d14f19a
URL:
https://github.com/llvm/llvm-project/commit/fbac3b0db5ff1d409f90219aeb6460ec5d14f19a
DIFF:
https://github.com/llvm/llvm-project/commit/fbac3b0db5ff1d409f90219aeb6460ec5d14f19a.diff
LOG: Revert "[clang][dataflow] Remove unused private field 'StmtToEnv' (NFC)"
Revert it after 1aacdfe473276ad631db773310fe167ec93fb764
Added:
Modified:
clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
Removed:
diff --git a/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
b/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
index e0a3552a9cde17..faf83a8920d4ea 100644
--- a/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
+++ b/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
@@ -77,7 +77,7 @@ class TerminatorVisitor
public:
TerminatorVisitor(const StmtToEnvMap , Environment ,
int BlockSuccIdx)
- : Env(Env), BlockSuccIdx(BlockSuccIdx) {}
+ : StmtToEnv(StmtToEnv), Env(Env), BlockSuccIdx(BlockSuccIdx) {}
TerminatorVisitorRetTy VisitIfStmt(const IfStmt *S) {
auto *Cond = S->getCond();
@@ -152,6 +152,7 @@ class TerminatorVisitor
return {, ConditionValue};
}
+ const StmtToEnvMap
Environment
int BlockSuccIdx;
};
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] ef156f9 - [clang][dataflow] Remove unused private field 'StmtToEnv' (NFC)
Author: Jie Fu
Date: 2024-01-12T16:26:00+08:00
New Revision: ef156f91262e960eea5ca93f95dd6111cfa3c5cc
URL:
https://github.com/llvm/llvm-project/commit/ef156f91262e960eea5ca93f95dd6111cfa3c5cc
DIFF:
https://github.com/llvm/llvm-project/commit/ef156f91262e960eea5ca93f95dd6111cfa3c5cc.diff
LOG: [clang][dataflow] Remove unused private field 'StmtToEnv' (NFC)
llvm-project/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:148:23:
error: private field 'StmtToEnv' is not used [-Werror,-Wunused-private-field]
148 | const StmtToEnvMap
| ^
1 error generated.
Added:
Modified:
clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
Removed:
diff --git a/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
b/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
index fdb2aeacf063ab..24d1447f09794a 100644
--- a/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
+++ b/clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
@@ -77,7 +77,7 @@ class TerminatorVisitor
public:
TerminatorVisitor(const StmtToEnvMap , Environment ,
int BlockSuccIdx)
- : StmtToEnv(StmtToEnv), Env(Env), BlockSuccIdx(BlockSuccIdx) {}
+ : Env(Env), BlockSuccIdx(BlockSuccIdx) {}
TerminatorVisitorRetTy VisitIfStmt(const IfStmt *S) {
auto *Cond = S->getCond();
@@ -145,7 +145,6 @@ class TerminatorVisitor
return {, ConditionValue};
}
- const StmtToEnvMap
Environment
int BlockSuccIdx;
};
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] dabc901 - [clangd] Use starts_with instead of startswith in CompileCommands.cpp (NFC)
Author: Jie Fu
Date: 2024-01-12T16:18:14+08:00
New Revision: dabc9018ee856dee672fb1035fd3eb1bb39bd7a6
URL:
https://github.com/llvm/llvm-project/commit/dabc9018ee856dee672fb1035fd3eb1bb39bd7a6
DIFF:
https://github.com/llvm/llvm-project/commit/dabc9018ee856dee672fb1035fd3eb1bb39bd7a6.diff
LOG: [clangd] Use starts_with instead of startswith in CompileCommands.cpp (NFC)
llvm-project/clang-tools-extra/clangd/CompileCommands.cpp:324:52:
error: 'startswith' is deprecated: Use starts_with instead
[-Werror,-Wdeprecated-declarations]
324 | Cmd, [&](llvm::StringRef Arg) { return Arg.startswith(Flag); });
|^~
|starts_with
Added:
Modified:
clang-tools-extra/clangd/CompileCommands.cpp
Removed:
diff --git a/clang-tools-extra/clangd/CompileCommands.cpp
b/clang-tools-extra/clangd/CompileCommands.cpp
index 1b4b24d59cb83a..166f17e9b3f712 100644
--- a/clang-tools-extra/clangd/CompileCommands.cpp
+++ b/clang-tools-extra/clangd/CompileCommands.cpp
@@ -321,7 +321,7 @@ void CommandMangler::operator()(tooling::CompileCommand
,
// Check whether the flag appears in the command as a prefix.
auto HasPrefix = [&](llvm::StringRef Flag) {
return llvm::any_of(
-Cmd, [&](llvm::StringRef Arg) { return Arg.startswith(Flag); });
+Cmd, [&](llvm::StringRef Arg) { return Arg.starts_with(Flag); });
};
llvm::erase_if(Cmd, [](llvm::StringRef Elem) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] c7cdf3c - [clang] Use 'starts_with' instead of 'startswith' in Gnu.cpp (NFC)
Author: Jie Fu
Date: 2023-12-18T16:10:49+08:00
New Revision: c7cdf3cd5d748901e1370f1bfe803685ca658fb6
URL:
https://github.com/llvm/llvm-project/commit/c7cdf3cd5d748901e1370f1bfe803685ca658fb6
DIFF:
https://github.com/llvm/llvm-project/commit/c7cdf3cd5d748901e1370f1bfe803685ca658fb6.diff
LOG: [clang] Use 'starts_with' instead of 'startswith' in Gnu.cpp (NFC)
llvm-project/clang/lib/Driver/ToolChains/Gnu.cpp:1757:14:
error: 'startswith' is deprecated: Use starts_with instead
[-Werror,-Wdeprecated-declarations]
1757 | if (Flag.startswith("!march=") || Flag.startswith("-march="))
| ^~
| starts_with
Added:
Modified:
clang/lib/Driver/ToolChains/Gnu.cpp
Removed:
diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp
b/clang/lib/Driver/ToolChains/Gnu.cpp
index 02228e19dcf2ea..7f463ddd17d3d6 100644
--- a/clang/lib/Driver/ToolChains/Gnu.cpp
+++ b/clang/lib/Driver/ToolChains/Gnu.cpp
@@ -1754,7 +1754,7 @@ selectRISCVMultilib(const MultilibSet ,
StringRef Arch,
// Collect all flags except march=*
for (StringRef Flag : Flags) {
-if (Flag.startswith("!march=") || Flag.startswith("-march="))
+if (Flag.starts_with("!march=") || Flag.starts_with("-march="))
continue;
NewFlags.push_back(Flag.str());
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 1095105 - [clang] Remove unused variable 'ExprDependenceBits' in ASTWriterDecl.cpp (NFC)
Author: Jie Fu
Date: 2023-12-11T10:45:56+08:00
New Revision: 10951050b5f371eb3e7cacce1691c4eb2fe2eab5
URL:
https://github.com/llvm/llvm-project/commit/10951050b5f371eb3e7cacce1691c4eb2fe2eab5
DIFF:
https://github.com/llvm/llvm-project/commit/10951050b5f371eb3e7cacce1691c4eb2fe2eab5.diff
LOG: [clang] Remove unused variable 'ExprDependenceBits' in ASTWriterDecl.cpp
(NFC)
llvm-project/clang/lib/Serialization/ASTWriterDecl.cpp:2342:12:
error: unused variable 'ExprDependenceBits' [-Werror,-Wunused-variable]
2342 | unsigned ExprDependenceBits = llvm::BitWidth;
|^~
1 error generated.
Added:
Modified:
clang/lib/Serialization/ASTWriterDecl.cpp
Removed:
diff --git a/clang/lib/Serialization/ASTWriterDecl.cpp
b/clang/lib/Serialization/ASTWriterDecl.cpp
index a5035d5002818..43169b2befc68 100644
--- a/clang/lib/Serialization/ASTWriterDecl.cpp
+++ b/clang/lib/Serialization/ASTWriterDecl.cpp
@@ -2339,7 +2339,6 @@ void ASTWriter::WriteDeclAbbrevs() {
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 6));
DeclCXXMethodAbbrev = Stream.EmitAbbrev(std::move(Abv));
- unsigned ExprDependenceBits = llvm::BitWidth;
// Abbreviation for EXPR_DECL_REF
Abv = std::make_shared();
Abv->Add(BitCodeAbbrevOp(serialization::EXPR_DECL_REF));
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 3ec6c72 - [AST] Fix -Wlogical-op-parentheses in ExprConstant.cpp (NFC)
Author: Jie Fu
Date: 2023-12-09T19:13:30+08:00
New Revision: 3ec6c72551846b8f4143c8c101a1a6203e85a2aa
URL:
https://github.com/llvm/llvm-project/commit/3ec6c72551846b8f4143c8c101a1a6203e85a2aa
DIFF:
https://github.com/llvm/llvm-project/commit/3ec6c72551846b8f4143c8c101a1a6203e85a2aa.diff
LOG: [AST] Fix -Wlogical-op-parentheses in ExprConstant.cpp (NFC)
llvm-project/clang/lib/AST/ExprConstant.cpp:5645:74: error: '&&' within '||'
[-Werror,-Wlogical-op-parentheses]
5645 | (Definition->isConstexpr() ||
Info.CurrentCall->CanEvalMSConstexpr &&
| ~~
~^~
5646 |
Definition->hasAttr()))
|
~~
llvm-project/clang/lib/AST/ExprConstant.cpp:5645:74: note: place parentheses
around the '&&' expression to silence this warning
5645 | (Definition->isConstexpr() ||
Info.CurrentCall->CanEvalMSConstexpr &&
|
^
| (
5646 |
Definition->hasAttr()))
|
|
)
1 error generated.
Added:
Modified:
clang/lib/AST/ExprConstant.cpp
Removed:
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index 9bef70770a544..f035c1419f4c9 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -5642,8 +5642,8 @@ static bool CheckConstexprFunction(EvalInfo ,
SourceLocation CallLoc,
// Can we evaluate this function call?
if (Definition && Body &&
- (Definition->isConstexpr() || Info.CurrentCall->CanEvalMSConstexpr &&
-
Definition->hasAttr()))
+ (Definition->isConstexpr() || (Info.CurrentCall->CanEvalMSConstexpr &&
+
Definition->hasAttr(
return true;
if (Info.getLangOpts().CPlusPlus11) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 5891a8f - [clang] Remove extra ';' in MultiplexExternalSemaSource.cpp (NFC)
Author: Jie Fu
Date: 2023-11-30T15:53:36+08:00
New Revision: 5891a8f7ce0a7b866a5bc06c34092fbdb28dda1c
URL:
https://github.com/llvm/llvm-project/commit/5891a8f7ce0a7b866a5bc06c34092fbdb28dda1c
DIFF:
https://github.com/llvm/llvm-project/commit/5891a8f7ce0a7b866a5bc06c34092fbdb28dda1c.diff
LOG: [clang] Remove extra ';' in MultiplexExternalSemaSource.cpp (NFC)
/llvm-project/clang/lib/Sema/MultiplexExternalSemaSource.cpp:317:2:
error: extra ';' outside of a function is incompatible with C++98
[-Werror,-Wc++98-compat-extra-semi]
};
^
1 error generated.
Added:
Modified:
clang/lib/Sema/MultiplexExternalSemaSource.cpp
Removed:
diff --git a/clang/lib/Sema/MultiplexExternalSemaSource.cpp
b/clang/lib/Sema/MultiplexExternalSemaSource.cpp
index d0d6a3a866d62d2..100794de60ee03d 100644
--- a/clang/lib/Sema/MultiplexExternalSemaSource.cpp
+++ b/clang/lib/Sema/MultiplexExternalSemaSource.cpp
@@ -314,7 +314,7 @@ void
MultiplexExternalSemaSource::ReadPendingInstantiationsOfConstexprEntity(
const NamedDecl *D, llvm::SmallSetVector ) {
for (size_t i = 0; i < Sources.size(); ++i)
Sources[i]->ReadPendingInstantiationsOfConstexprEntity(D, Decls);
-};
+}
void MultiplexExternalSemaSource::ReadLateParsedTemplates(
llvm::MapVector>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 1c12278 - [clang] Remove unused selStructPtrTy in CGObjCGNU.cpp (NFC)
Author: Jie Fu
Date: 2023-11-19T08:19:47+08:00
New Revision: 1c1227846425883a3d39ff56700660236a97152c
URL:
https://github.com/llvm/llvm-project/commit/1c1227846425883a3d39ff56700660236a97152c
DIFF:
https://github.com/llvm/llvm-project/commit/1c1227846425883a3d39ff56700660236a97152c.diff
LOG: [clang] Remove unused selStructPtrTy in CGObjCGNU.cpp (NFC)
/llvm-project/clang/lib/CodeGen/CGObjCGNU.cpp:3674:15: error: variable
'selStructPtrTy' set but not used [-Werror,-Wunused-but-set-variable]
llvm::Type *selStructPtrTy = SelectorTy;
^
1 error generated.
Added:
Modified:
clang/lib/CodeGen/CGObjCGNU.cpp
Removed:
diff --git a/clang/lib/CodeGen/CGObjCGNU.cpp b/clang/lib/CodeGen/CGObjCGNU.cpp
index 68ec457e426a933..4ca1a8cce64d895 100644
--- a/clang/lib/CodeGen/CGObjCGNU.cpp
+++ b/clang/lib/CodeGen/CGObjCGNU.cpp
@@ -3671,11 +3671,9 @@ llvm::Function *CGObjCGNU::ModuleInitFunction() {
GenerateProtocolHolderCategory();
llvm::StructType *selStructTy = dyn_cast(SelectorElemTy);
- llvm::Type *selStructPtrTy = SelectorTy;
if (!selStructTy) {
selStructTy = llvm::StructType::get(CGM.getLLVMContext(),
{ PtrToInt8Ty, PtrToInt8Ty });
-selStructPtrTy = llvm::PointerType::getUnqual(selStructTy);
}
// Generate statics list:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] a737a33 - [clang][dataflow] Fix -Wrange-loop-construct in DataflowAnalysisContext.cpp (NFC)
Author: Jie Fu
Date: 2023-11-07T22:32:11+08:00
New Revision: a737a33eb995cf704f8ae9653811ca503d77ed65
URL:
https://github.com/llvm/llvm-project/commit/a737a33eb995cf704f8ae9653811ca503d77ed65
DIFF:
https://github.com/llvm/llvm-project/commit/a737a33eb995cf704f8ae9653811ca503d77ed65.diff
LOG: [clang][dataflow] Fix -Wrange-loop-construct in
DataflowAnalysisContext.cpp (NFC)
/llvm-project/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:247:10:
note: use reference type 'const llvm::Sma
llVector &' to prevent copying
for (const llvm::SmallVector Class : Info.EquivalentAtoms)
^
&
1 error generated.
Added:
Modified:
clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
Removed:
diff --git a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
index 9c15c8756e9dc15..0a2fcd4ad695a30 100644
--- a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
+++ b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
@@ -244,7 +244,7 @@ void DataflowAnalysisContext::dumpFlowCondition(Atom Token,
}
if (!Info.EquivalentAtoms.empty()) {
OS << "Equivalent atoms:\n";
-for (const llvm::SmallVector Class : Info.EquivalentAtoms)
+for (const llvm::SmallVector : Info.EquivalentAtoms)
printAtomList(Class, OS);
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 407afbf - [clang][examples] Remove unused variable 'key' in LLVMPrintFunctionNames.cpp (NFC)
Author: Jie Fu
Date: 2023-11-07T13:09:20+08:00
New Revision: 407afbf1bc276fb70569da335e5ef57b7cb119db
URL:
https://github.com/llvm/llvm-project/commit/407afbf1bc276fb70569da335e5ef57b7cb119db
DIFF:
https://github.com/llvm/llvm-project/commit/407afbf1bc276fb70569da335e5ef57b7cb119db.diff
LOG: [clang][examples] Remove unused variable 'key' in
LLVMPrintFunctionNames.cpp (NFC)
/llvm-project/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp:33:28:
error: unused variable 'key' [-Werror,-Wunused-variable]
static llvm::AnalysisKey key;
^
1 error generated.
Added:
Modified:
clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp
Removed:
diff --git a/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp
b/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp
index 739740cecdf47d2..6cb87e4b5e19c44 100644
--- a/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp
+++ b/clang/examples/LLVMPrintFunctionNames/LLVMPrintFunctionNames.cpp
@@ -29,9 +29,6 @@ namespace {
class PrintPass final : public llvm::AnalysisInfoMixin {
friend struct llvm::AnalysisInfoMixin;
-private:
- static llvm::AnalysisKey key;
-
public:
using Result = llvm::PreservedAnalyses;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] bceb6a1 - [StaticAnalyzer] Fix -Wunused-variable in SVals.h (NFC)
Author: Jie Fu
Date: 2023-11-05T07:40:44+08:00
New Revision: bceb6a1f2e141be6ed66fa382ee280c2644174fd
URL:
https://github.com/llvm/llvm-project/commit/bceb6a1f2e141be6ed66fa382ee280c2644174fd
DIFF:
https://github.com/llvm/llvm-project/commit/bceb6a1f2e141be6ed66fa382ee280c2644174fd.diff
LOG: [StaticAnalyzer] Fix -Wunused-variable in SVals.h (NFC)
/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:321:14:
error: unused variable 'K' [-Werror,-Wunused-variable]
SValKind K = data.first.getKind();
^
1 error generated.
Added:
Modified:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
Removed:
diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
index 5395cd6167b7ce5..c60528b7685fe82 100644
--- a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
+++ b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
@@ -318,7 +318,7 @@ class LocAsInteger : public NonLoc {
: NonLoc(LocAsIntegerKind, ) {
// We do not need to represent loc::ConcreteInt as LocAsInteger,
// as it'd collapse into a nonloc::ConcreteInt instead.
-SValKind K = data.first.getKind();
+[[maybe_unused]] SValKind K = data.first.getKind();
assert(K == loc::MemRegionValKind || K == loc::GotoLabelKind);
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 3a158cc - [clang] Fix -Wreorder-ctor of DependentFunctionTemplateSpecializationInfo (NFC)
Author: Jie Fu
Date: 2023-10-07T15:33:22+08:00
New Revision: 3a158cc875a383e2d5b8da487633e53d061942f1
URL:
https://github.com/llvm/llvm-project/commit/3a158cc875a383e2d5b8da487633e53d061942f1
DIFF:
https://github.com/llvm/llvm-project/commit/3a158cc875a383e2d5b8da487633e53d061942f1.diff
LOG: [clang] Fix -Wreorder-ctor of DependentFunctionTemplateSpecializationInfo
(NFC)
/llvm-project/clang/lib/AST/Decl.cpp:4182:7: error: field
'TemplateArgumentsAsWritten' will be initialized after field 'NumCandidates'
[-Werror,-Wreorder-ctor]
: TemplateArgumentsAsWritten(TemplateArgsWritten),
^~~
NumCandidates(Candidates.size())
1 error generated.
Added:
Modified:
clang/lib/AST/Decl.cpp
Removed:
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index f4a73f137fcf87a..480639606d22525 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -4179,8 +4179,8 @@ DependentFunctionTemplateSpecializationInfo::
DependentFunctionTemplateSpecializationInfo(
const UnresolvedSetImpl ,
const ASTTemplateArgumentListInfo *TemplateArgsWritten)
-: TemplateArgumentsAsWritten(TemplateArgsWritten),
- NumCandidates(Candidates.size()) {
+: NumCandidates(Candidates.size()),
+ TemplateArgumentsAsWritten(TemplateArgsWritten) {
std::transform(Candidates.begin(), Candidates.end(),
getTrailingObjects(),
[](NamedDecl *ND) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] b191ff0 - [clang] Fix -Wunused-variable in ASTContext.cpp (NFC)
Author: Jie Fu
Date: 2023-09-29T08:38:13+08:00
New Revision: b191ff01dc337e9a44e422b47cdc6d013cdf4bcf
URL:
https://github.com/llvm/llvm-project/commit/b191ff01dc337e9a44e422b47cdc6d013cdf4bcf
DIFF:
https://github.com/llvm/llvm-project/commit/b191ff01dc337e9a44e422b47cdc6d013cdf4bcf.diff
LOG: [clang] Fix -Wunused-variable in ASTContext.cpp (NFC)
/llvm-project/clang/lib/AST/ASTContext.cpp:12938:46: error: unused variable
'DY' [-Werror,-Wunused-variable]
const auto *DX = cast(X), *DY = cast(Y);
^
1 error generated.
Added:
Modified:
clang/lib/AST/ASTContext.cpp
Removed:
diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
index 5ce0b54166e0255..8917662c5336825 100644
--- a/clang/lib/AST/ASTContext.cpp
+++ b/clang/lib/AST/ASTContext.cpp
@@ -12935,7 +12935,8 @@ static QualType getCommonNonSugarTypeNode(ASTContext
, const Type *X,
As, X->getCanonicalTypeInternal());
}
case Type::Decltype: {
-const auto *DX = cast(X), *DY = cast(Y);
+const auto *DX = cast(X);
+[[maybe_unused]] const auto *DY = cast(Y);
assert(DX->isDependentType());
assert(DY->isDependentType());
assert(Ctx.hasSameExpr(DX->getUnderlyingExpr(), DY->getUnderlyingExpr()));
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 5f667a5 - [clang][dataflow] Fix -Wunused-const-variable in WatchedLiteralsSolver.cpp (NFC)
Author: Jie Fu
Date: 2023-09-05T15:03:07+08:00
New Revision: 5f667a57b5329f449d27f514d041d457b1ea9da6
URL:
https://github.com/llvm/llvm-project/commit/5f667a57b5329f449d27f514d041d457b1ea9da6
DIFF:
https://github.com/llvm/llvm-project/commit/5f667a57b5329f449d27f514d041d457b1ea9da6.diff
LOG: [clang][dataflow] Fix -Wunused-const-variable in WatchedLiteralsSolver.cpp
(NFC)
/data/llvm-project/clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:62:26:
error: unused variable 'NullLit' [-Werror,-Wunused-const-variable]
static constexpr Literal NullLit = 0;
Added:
Modified:
clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp
Removed:
diff --git a/clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp
b/clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp
index 05ae36ddbc898e..ab3a8104e31717 100644
--- a/clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp
+++ b/clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp
@@ -59,7 +59,7 @@ using Literal = uint32_t;
/// A null literal is used as a placeholder in various data structures and
/// algorithms.
-static constexpr Literal NullLit = 0;
+[[maybe_unused]] static constexpr Literal NullLit = 0;
/// Returns the positive literal `V`.
static constexpr Literal posLit(Variable V) { return 2 * V; }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] e71bae9 - [clang][dataflow] Fix build failure due to -Wunused-variable in DataflowEnvironment.cpp (NFC)
Author: Jie Fu
Date: 2023-07-24T21:35:52+08:00
New Revision: e71bae94b04391cb47680622666d448418c0d972
URL:
https://github.com/llvm/llvm-project/commit/e71bae94b04391cb47680622666d448418c0d972
DIFF:
https://github.com/llvm/llvm-project/commit/e71bae94b04391cb47680622666d448418c0d972.diff
LOG: [clang][dataflow] Fix build failure due to -Wunused-variable in
DataflowEnvironment.cpp (NFC)
/data/llvm-project/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:125:11:
error: unused variable 'StructVal2' [-Werror,-Wunused-variable]
auto *StructVal2 = cast();
^
1 error generated.
Added:
Modified:
clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
Removed:
diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
index 5514d25df6cc63..3a91025df6e12a 100644
--- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
+++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
@@ -122,7 +122,7 @@ static Value *mergeDistinctValues(QualType Type, Value
,
Value *MergedVal = nullptr;
if (auto *StructVal1 = dyn_cast()) {
-auto *StructVal2 = cast();
+[[maybe_unused]] auto *StructVal2 = cast();
// Values to be merged are always associated with the same location in
// `LocToVal`. The location stored in `StructVal` should therefore also
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 2565887 - [clang][test] Remove unused variable 'SM' (NFC)
Author: Jie Fu
Date: 2023-07-21T07:59:30+08:00
New Revision: 25658879a022ca9a8d91ed214701bfd724d159a8
URL:
https://github.com/llvm/llvm-project/commit/25658879a022ca9a8d91ed214701bfd724d159a8
DIFF:
https://github.com/llvm/llvm-project/commit/25658879a022ca9a8d91ed214701bfd724d159a8.diff
LOG: [clang][test] Remove unused variable 'SM' (NFC)
/data/llvm-project/clang/unittests/AST/DeclTest.cpp:153:18: error: unused
variable 'SM' [-Werror,-Wunused-variable]
SourceManager = Ctx.getSourceManager();
^
1 error generated.
Added:
Modified:
clang/unittests/AST/DeclTest.cpp
Removed:
diff --git a/clang/unittests/AST/DeclTest.cpp
b/clang/unittests/AST/DeclTest.cpp
index 54a1f2c5843548..2ed2ed750941c4 100644
--- a/clang/unittests/AST/DeclTest.cpp
+++ b/clang/unittests/AST/DeclTest.cpp
@@ -150,7 +150,6 @@ TEST(Decl, ConceptDecl) {
auto AST = tooling::buildASTFromCodeWithArgs(Code, {"-std=c++20"});
ASTContext = AST->getASTContext();
- SourceManager = Ctx.getSourceManager();
const auto *Decl =
selectFirst("decl", match(conceptDecl().bind("decl"), Ctx));
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] bd253a6 - [clangd] Fix -Wunused-variable of 'FIDIt' (NFC)
Author: Jie Fu
Date: 2023-07-19T21:59:53+08:00
New Revision: bd253a6a039937fbd0f2ba1f7dd5338a2920e24d
URL:
https://github.com/llvm/llvm-project/commit/bd253a6a039937fbd0f2ba1f7dd5338a2920e24d
DIFF:
https://github.com/llvm/llvm-project/commit/bd253a6a039937fbd0f2ba1f7dd5338a2920e24d.diff
LOG: [clangd] Fix -Wunused-variable of 'FIDIt' (NFC)
/data/llvm-project/clang-tools-extra/clangd/index/SymbolCollector.cpp:878:16:
error: unused variable 'FIDIt' [-Werror,-Wunused-variable]
const auto FIDIt = IncludeFiles.find(SID);
^
1 error generated.
Added:
Modified:
clang-tools-extra/clangd/index/SymbolCollector.cpp
Removed:
diff --git a/clang-tools-extra/clangd/index/SymbolCollector.cpp
b/clang-tools-extra/clangd/index/SymbolCollector.cpp
index 5389a0e31b81bb..214991a0674cc6 100644
--- a/clang-tools-extra/clangd/index/SymbolCollector.cpp
+++ b/clang-tools-extra/clangd/index/SymbolCollector.cpp
@@ -875,8 +875,7 @@ void SymbolCollector::finish() {
const Symbol *S = Symbols.find(SID);
if (!S)
continue;
-const auto FIDIt = IncludeFiles.find(SID);
-assert(FIDIt != IncludeFiles.end());
+assert(IncludeFiles.find(SID) != IncludeFiles.end());
const auto FID = IncludeFiles.at(SID);
// Determine if the FID is #include'd or #import'ed.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] c4fa97f - [clangd] Remove unused private field 'Opts' in UpdateIndexCallbacks (NFC)
Author: Jie Fu
Date: 2023-07-19T15:28:38+08:00
New Revision: c4fa97fca7e92c736fcb09779c84b42c25ffae70
URL:
https://github.com/llvm/llvm-project/commit/c4fa97fca7e92c736fcb09779c84b42c25ffae70
DIFF:
https://github.com/llvm/llvm-project/commit/c4fa97fca7e92c736fcb09779c84b42c25ffae70.diff
LOG: [clangd] Remove unused private field 'Opts' in UpdateIndexCallbacks (NFC)
/Users/jiefu/llvm-project/clang-tools-extra/clangd/ClangdServer.cpp:167:32:
error: private field 'Opts' is not used [-Werror,-Wunused-private-field]
const ClangdServer::Options
^
1 error generated.
Added:
Modified:
clang-tools-extra/clangd/ClangdServer.cpp
Removed:
diff --git a/clang-tools-extra/clangd/ClangdServer.cpp
b/clang-tools-extra/clangd/ClangdServer.cpp
index 52731222ed8264..763fea68360ac9 100644
--- a/clang-tools-extra/clangd/ClangdServer.cpp
+++ b/clang-tools-extra/clangd/ClangdServer.cpp
@@ -67,11 +67,10 @@ struct UpdateIndexCallbacks : public ParsingCallbacks {
UpdateIndexCallbacks(FileIndex *FIndex,
ClangdServer::Callbacks *ServerCallbacks,
const ThreadsafeFS , AsyncTaskRunner *Tasks,
- bool CollectInactiveRegions,
- const ClangdServer::Options )
+ bool CollectInactiveRegions)
: FIndex(FIndex), ServerCallbacks(ServerCallbacks),
TFS(TFS), Stdlib{std::make_shared()}, Tasks(Tasks),
-CollectInactiveRegions(CollectInactiveRegions), Opts(Opts) {}
+CollectInactiveRegions(CollectInactiveRegions) {}
void onPreambleAST(
PathRef Path, llvm::StringRef Version, CapturedASTCtx ASTCtx,
@@ -164,7 +163,6 @@ struct UpdateIndexCallbacks : public ParsingCallbacks {
std::shared_ptr Stdlib;
AsyncTaskRunner *Tasks;
bool CollectInactiveRegions;
- const ClangdServer::Options
};
class DraftStoreFS : public ThreadsafeFS {
@@ -229,7 +227,7 @@ ClangdServer::ClangdServer(const GlobalCompilationDatabase
,
std::make_unique(
DynamicIdx.get(), Callbacks, TFS,
IndexTasks ? &*IndexTasks : nullptr,
-PublishInactiveRegions, Opts));
+PublishInactiveRegions));
// Adds an index to the stack, at higher priority than existing indexes.
auto AddIndex = [&](SymbolIndex *Idx) {
if (this->Index != nullptr) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 12f35b3 - [tools] Use "#pragma GCC" instead of "#pragma clang" to ignore -Wcast-qual in c-index-test.c (NFC)
Author: Jie Fu
Date: 2023-07-19T12:05:05+08:00
New Revision: 12f35b39ee63e932d4bdf6b28cce2e3d07713c4d
URL:
https://github.com/llvm/llvm-project/commit/12f35b39ee63e932d4bdf6b28cce2e3d07713c4d
DIFF:
https://github.com/llvm/llvm-project/commit/12f35b39ee63e932d4bdf6b28cce2e3d07713c4d.diff
LOG: [tools] Use "#pragma GCC" instead of "#pragma clang" to ignore -Wcast-qual
in c-index-test.c (NFC)
Added:
Modified:
clang/tools/c-index-test/c-index-test.c
Removed:
diff --git a/clang/tools/c-index-test/c-index-test.c
b/clang/tools/c-index-test/c-index-test.c
index 9c60e83f0bcf93..9d66a22f3b43b5 100644
--- a/clang/tools/c-index-test/c-index-test.c
+++ b/clang/tools/c-index-test/c-index-test.c
@@ -231,14 +231,14 @@ void free_remapped_files(struct CXUnsavedFile
*unsaved_files,
int num_unsaved_files) {
int i;
for (i = 0; i != num_unsaved_files; ++i) {
-#if defined(__clang__)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wcast-qual"
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-qual"
#endif
free((char *)unsaved_files[i].Filename);
free((char *)unsaved_files[i].Contents);
-#if defined(__clang__)
-#pragma clang diagnostic pop
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
#endif
}
free(unsaved_files);
@@ -3766,13 +3766,13 @@ index_startedTranslationUnit(CXClientData client_data,
void *reserved) {
printCheck(index_data);
printf("[startedTranslationUnit]\n");
-#if defined(__clang__)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wcast-qual"
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-qual"
#endif
return (CXIdxClientContainer)"TU";
-#if defined(__clang__)
-#pragma clang diagnostic pop
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
#endif
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 16d5078 - [tools] Fix buildbot build failure
Author: Jie Fu
Date: 2023-07-19T11:39:00+08:00
New Revision: 16d50781e16374f5bf930ba0b9aa8cbbb034ee6c
URL:
https://github.com/llvm/llvm-project/commit/16d50781e16374f5bf930ba0b9aa8cbbb034ee6c
DIFF:
https://github.com/llvm/llvm-project/commit/16d50781e16374f5bf930ba0b9aa8cbbb034ee6c.diff
LOG: [tools] Fix buildbot build failure
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:234:
warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:235:
warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:236:10:
warning: cast discards 'const' qualifier from pointer target type [-Wcast-qual]
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:237:10:
warning: cast discards 'const' qualifier from pointer target type [-Wcast-qual]
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:238:
warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:3765:
warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:3766:
warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:3767:10:
warning: cast discards 'const' qualifier from pointer target type [-Wcast-qual]
/buildbot/worker/arc-folder/llvm-project/clang/tools/c-index-test/c-index-test.c:3768:
warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
Added:
Modified:
clang/tools/c-index-test/c-index-test.c
Removed:
diff --git a/clang/tools/c-index-test/c-index-test.c
b/clang/tools/c-index-test/c-index-test.c
index 22cea032036977..9c60e83f0bcf93 100644
--- a/clang/tools/c-index-test/c-index-test.c
+++ b/clang/tools/c-index-test/c-index-test.c
@@ -231,11 +231,15 @@ void free_remapped_files(struct CXUnsavedFile
*unsaved_files,
int num_unsaved_files) {
int i;
for (i = 0; i != num_unsaved_files; ++i) {
+#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wcast-qual"
+#endif
free((char *)unsaved_files[i].Filename);
free((char *)unsaved_files[i].Contents);
+#if defined(__clang__)
#pragma clang diagnostic pop
+#endif
}
free(unsaved_files);
}
@@ -3762,10 +3766,14 @@ index_startedTranslationUnit(CXClientData client_data,
void *reserved) {
printCheck(index_data);
printf("[startedTranslationUnit]\n");
+#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wcast-qual"
+#endif
return (CXIdxClientContainer)"TU";
+#if defined(__clang__)
#pragma clang diagnostic pop
+#endif
}
static void index_indexDeclaration(CXClientData client_data,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 0f0c3d4 - [tools] Ignore -Wcast-qual in c-index-test.c after D153911 (NFC)
Author: Jie Fu
Date: 2023-07-19T10:55:12+08:00
New Revision: 0f0c3d45d7d75ba82a955246da654146a7d57a0d
URL:
https://github.com/llvm/llvm-project/commit/0f0c3d45d7d75ba82a955246da654146a7d57a0d
DIFF:
https://github.com/llvm/llvm-project/commit/0f0c3d45d7d75ba82a955246da654146a7d57a0d.diff
LOG: [tools] Ignore -Wcast-qual in c-index-test.c after D153911 (NFC)
/Users/jiefu/llvm-project/clang/tools/c-index-test/c-index-test.c:234:18:
error: cast from 'const char *' to 'char *' drops const qualifier
[-Werror,-Wcast-qual]
free((char *)unsaved_files[i].Filename);
^
/Users/jiefu/llvm-project/clang/tools/c-index-test/c-index-test.c:235:18:
error: cast from 'const char *' to 'char *' drops const qualifier
[-Werror,-Wcast-qual]
free((char *)unsaved_files[i].Contents);
^
/Users/jiefu/llvm-project/clang/tools/c-index-test/c-index-test.c:3762:32:
error: cast from 'const char *' to 'void *' drops const qualifier
[-Werror,-Wcast-qual]
return (CXIdxClientContainer)"TU";
^
3 errors generated.
Added:
Modified:
clang/tools/c-index-test/c-index-test.c
Removed:
diff --git a/clang/tools/c-index-test/c-index-test.c
b/clang/tools/c-index-test/c-index-test.c
index 68a560ca15cf43..22cea032036977 100644
--- a/clang/tools/c-index-test/c-index-test.c
+++ b/clang/tools/c-index-test/c-index-test.c
@@ -231,8 +231,11 @@ void free_remapped_files(struct CXUnsavedFile
*unsaved_files,
int num_unsaved_files) {
int i;
for (i = 0; i != num_unsaved_files; ++i) {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wcast-qual"
free((char *)unsaved_files[i].Filename);
free((char *)unsaved_files[i].Contents);
+#pragma clang diagnostic pop
}
free(unsaved_files);
}
@@ -3759,7 +3762,10 @@ index_startedTranslationUnit(CXClientData client_data,
void *reserved) {
printCheck(index_data);
printf("[startedTranslationUnit]\n");
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wcast-qual"
return (CXIdxClientContainer)"TU";
+#pragma clang diagnostic pop
}
static void index_indexDeclaration(CXClientData client_data,
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 405889e - [RISCV] Remove unused private field 'HasFRMRoundModeOp' in RVVIntrinsic (NFC)
Author: Jie Fu
Date: 2023-07-13T16:17:03+08:00
New Revision: 405889ebad95956b4b6db92c92cd15607840f94b
URL:
https://github.com/llvm/llvm-project/commit/405889ebad95956b4b6db92c92cd15607840f94b
DIFF:
https://github.com/llvm/llvm-project/commit/405889ebad95956b4b6db92c92cd15607840f94b.diff
LOG: [RISCV] Remove unused private field 'HasFRMRoundModeOp' in RVVIntrinsic
(NFC)
/data/llvm-project/clang/include/clang/Support/RISCVVIntrinsicUtils.h:390:8:
error: private field 'HasFRMRoundModeOp' is not used
[-Werror,-Wunused-private-field]
bool HasFRMRoundModeOp;
^
1 error generated.
Added:
Modified:
clang/include/clang/Support/RISCVVIntrinsicUtils.h
clang/lib/Support/RISCVVIntrinsicUtils.cpp
Removed:
diff --git a/clang/include/clang/Support/RISCVVIntrinsicUtils.h
b/clang/include/clang/Support/RISCVVIntrinsicUtils.h
index 1c216b4ee53714..e985a9bef888c4 100644
--- a/clang/include/clang/Support/RISCVVIntrinsicUtils.h
+++ b/clang/include/clang/Support/RISCVVIntrinsicUtils.h
@@ -387,7 +387,6 @@ class RVVIntrinsic {
std::vector IntrinsicTypes;
unsigned NF = 1;
Policy PolicyAttrs;
- bool HasFRMRoundModeOp;
public:
RVVIntrinsic(llvm::StringRef Name, llvm::StringRef Suffix,
diff --git a/clang/lib/Support/RISCVVIntrinsicUtils.cpp
b/clang/lib/Support/RISCVVIntrinsicUtils.cpp
index 12b9ca38faa0fe..20c4ee3e151870 100644
--- a/clang/lib/Support/RISCVVIntrinsicUtils.cpp
+++ b/clang/lib/Support/RISCVVIntrinsicUtils.cpp
@@ -886,8 +886,7 @@ RVVIntrinsic::RVVIntrinsic(
: IRName(IRName), IsMasked(IsMasked),
HasMaskedOffOperand(HasMaskedOffOperand), HasVL(HasVL), Scheme(Scheme),
SupportOverloading(SupportOverloading), HasBuiltinAlias(HasBuiltinAlias),
- ManualCodegen(ManualCodegen.str()), NF(NF), PolicyAttrs(NewPolicyAttrs),
- HasFRMRoundModeOp(HasFRMRoundModeOp) {
+ ManualCodegen(ManualCodegen.str()), NF(NF), PolicyAttrs(NewPolicyAttrs) {
// Init BuiltinName, Name and OverloadedName
BuiltinName = NewName.str();
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] b10899d - [clang] Fix -Wlogical-op-parentheses in Clang.cpp (NFC)
Author: Jie Fu Date: 2023-07-12T07:53:50+08:00 New Revision: b10899d869954e1426684cbc20a43d7303075d49 URL: https://github.com/llvm/llvm-project/commit/b10899d869954e1426684cbc20a43d7303075d49 DIFF: https://github.com/llvm/llvm-project/commit/b10899d869954e1426684cbc20a43d7303075d49.diff LOG: [clang] Fix -Wlogical-op-parentheses in Clang.cpp (NFC) /Users/jiefu/llvm-project/clang/lib/Driver/ToolChains/Clang.cpp:7345:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses] (WholeProgramVTables || SanitizeArgs.needsLTO()) && ~^~ /Users/jiefu/llvm-project/clang/lib/Driver/ToolChains/Clang.cpp:7345:56: note: place parentheses around the '&&' expression to silence this warning (WholeProgramVTables || SanitizeArgs.needsLTO()) && ^ ( 1 error generated. Added: Modified: clang/lib/Driver/ToolChains/Clang.cpp Removed: diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 796c60f0739285..bf09fc859a16df 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -7342,8 +7342,8 @@ void Clang::ConstructJob(Compilation , const JobAction , } bool DefaultsSplitLTOUnit = - (WholeProgramVTables || SanitizeArgs.needsLTO()) && - (LTOMode == LTOK_Full || TC.canSplitThinLTOUnit()) || + ((WholeProgramVTables || SanitizeArgs.needsLTO()) && + (LTOMode == LTOK_Full || TC.canSplitThinLTOUnit())) || (!Triple.isPS4() && UnifiedLTO); bool SplitLTOUnit = Args.hasFlag(options::OPT_fsplit_lto_unit, ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] f10b1c5 - [Clang][OpenMP] Fix -Wcovered-switch-default in CGOpenMPRuntime.cpp (NFC)
Author: Jie Fu
Date: 2023-06-07T20:23:48+08:00
New Revision: f10b1c5f3cbef76b189566332eebabd017296655
URL:
https://github.com/llvm/llvm-project/commit/f10b1c5f3cbef76b189566332eebabd017296655
DIFF:
https://github.com/llvm/llvm-project/commit/f10b1c5f3cbef76b189566332eebabd017296655.diff
LOG: [Clang][OpenMP] Fix -Wcovered-switch-default in CGOpenMPRuntime.cpp (NFC)
/data/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp:1621:3: error: default
label in switch which covers all enumeration values
[-Werror,-Wcovered-switch-default]
default:
^
/data/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp:1643:3: error: default
label in switch which covers all enumeration values
[-Werror,-Wcovered-switch-default]
default:
^
2 errors generated.
Added:
Modified:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
Removed:
diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp
b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
index 6958ed28bffb2..c7d62fc075fbb 100644
--- a/clang/lib/CodeGen/CGOpenMPRuntime.cpp
+++ b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
@@ -1608,7 +1608,7 @@ convertDeviceClause(const VarDecl *VD) {
if (!DevTy)
return llvm::OffloadEntriesInfoManager::OMPTargetDeviceClauseNone;
- switch (*DevTy) {
+ switch ((int)*DevTy) { // Avoid -Wcovered-switch-default
case OMPDeclareTargetDeclAttr::DT_Host:
return llvm::OffloadEntriesInfoManager::OMPTargetDeviceClauseHost;
break;
@@ -1630,7 +1630,7 @@ convertCaptureClause(const VarDecl *VD) {
OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(VD);
if (!MapType)
return llvm::OffloadEntriesInfoManager::OMPTargetGlobalVarEntryNone;
- switch (*MapType) {
+ switch ((int)*MapType) { // Avoid -Wcovered-switch-default
case OMPDeclareTargetDeclAttr::MapTypeTy::MT_To:
return llvm::OffloadEntriesInfoManager::OMPTargetGlobalVarEntryTo;
break;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 749aeea - [clang][ExtractAPI] Fix -Wpessimizing-move in DeclarationFragments.h (NFC)
Author: Jie Fu
Date: 2023-05-31T07:20:24+08:00
New Revision: 749aeeaf66a483345e12f69cc1f55dad4e997297
URL:
https://github.com/llvm/llvm-project/commit/749aeeaf66a483345e12f69cc1f55dad4e997297
DIFF:
https://github.com/llvm/llvm-project/commit/749aeeaf66a483345e12f69cc1f55dad4e997297.diff
LOG: [clang][ExtractAPI] Fix -Wpessimizing-move in DeclarationFragments.h (NFC)
/Users/jiefu/llvm-project/clang/include/clang/ExtractAPI/DeclarationFragments.h:118:26:
error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
^
/Users/jiefu/llvm-project/clang/include/clang/ExtractAPI/DeclarationFragments.h:118:26:
note: remove std::move call here
Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
^~
1 error generated.
Added:
Modified:
clang/include/clang/ExtractAPI/DeclarationFragments.h
Removed:
diff --git a/clang/include/clang/ExtractAPI/DeclarationFragments.h
b/clang/include/clang/ExtractAPI/DeclarationFragments.h
index 4c1b83080704..3b909b066866 100644
--- a/clang/include/clang/ExtractAPI/DeclarationFragments.h
+++ b/clang/include/clang/ExtractAPI/DeclarationFragments.h
@@ -115,8 +115,8 @@ class DeclarationFragments {
FragmentKind Kind,
StringRef PreciseIdentifier = "",
const Decl *Declaration = nullptr) {
-Fragments.insert(It, std::move(Fragment(Spelling, Kind, PreciseIdentifier,
-Declaration)));
+Fragments.insert(It, Fragment(Spelling, Kind, PreciseIdentifier,
+Declaration));
return *this;
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] 1d097ad - [clang] Fix -Wimplicit-fallthrough in UnsafeBufferUsage.cpp [NFC]
Author: Jie Fu
Date: 2023-04-25T07:34:39+08:00
New Revision: 1d097ad73b3fe38ff301f471356d15f093a2dbef
URL:
https://github.com/llvm/llvm-project/commit/1d097ad73b3fe38ff301f471356d15f093a2dbef
DIFF:
https://github.com/llvm/llvm-project/commit/1d097ad73b3fe38ff301f471356d15f093a2dbef.diff
LOG: [clang] Fix -Wimplicit-fallthrough in UnsafeBufferUsage.cpp [NFC]
/Users/jiefu/llvm-project/clang/lib/Analysis/UnsafeBufferUsage.cpp:1272:5:
error: unannotated fall-through between switch labels
[-Werror,-Wimplicit-fallthrough]
case Strategy::Kind::Wontfix:
^
/Users/jiefu/llvm-project/clang/lib/Analysis/UnsafeBufferUsage.cpp:1272:5:
note: insert 'LLVM_FALLTHROUGH;' to silence this warning
case Strategy::Kind::Wontfix:
^
LLVM_FALLTHROUGH;
/Users/jiefu/llvm-project/clang/lib/Analysis/UnsafeBufferUsage.cpp:1272:5:
note: insert 'break;' to avoid fall-through
case Strategy::Kind::Wontfix:
^
break;
1 error generated.
Added:
Modified:
clang/lib/Analysis/UnsafeBufferUsage.cpp
Removed:
diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp
b/clang/lib/Analysis/UnsafeBufferUsage.cpp
index 037efc9c5d00..3b58a51195f8 100644
--- a/clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1269,6 +1269,7 @@ std::optional
UPCStandalonePointerGadget::getFixits(const Strategy
return FixItList{{FixItHint::CreateInsertion(
*EndOfOperand, ".data()")}};
}
+ [[fallthrough]];
case Strategy::Kind::Wontfix:
case Strategy::Kind::Iterator:
case Strategy::Kind::Array:
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] c107231 - [clang][dataflow] Fix -Wdeprecated-declarations after D147302 (NFC)
Author: Jie Fu
Date: 2023-04-04T16:17:25+08:00
New Revision: c107231cde99c0b8cdda5c5befe6354750ca03f2
URL:
https://github.com/llvm/llvm-project/commit/c107231cde99c0b8cdda5c5befe6354750ca03f2
DIFF:
https://github.com/llvm/llvm-project/commit/c107231cde99c0b8cdda5c5befe6354750ca03f2.diff
LOG: [clang][dataflow] Fix -Wdeprecated-declarations after D147302 (NFC)
Replace:
1. createAtomicBoolValue() --> create()
2. createTopBoolValue()--> create()
/Users/jiefu/llvm-project/clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:386:19:
error: 'createAtomicBoolValue' is deprecated: use create
instead [-Werror,-Wdeprecated-declarations]
return DACtx->createAtomicBoolValue();
^
create
/Users/jiefu/llvm-project/clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:215:3:
note: 'createAtomicBoolValue' has been explicitly marked deprecated here
LLVM_DEPRECATED("use create instead",
^
/Users/jiefu/llvm-project/llvm/include/llvm/Support/Compiler.h:143:50: note:
expanded from macro 'LLVM_DEPRECATED'
^
In file included from
/Users/jiefu/llvm-project/clang/lib/Analysis/FlowSensitive/Transfer.cpp:14:
In file included from
/Users/jiefu/llvm-project/clang/include/clang/Analysis/FlowSensitive/Transfer.h:19:
/Users/jiefu/llvm-project/clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:391:19:
error: 'createTopBoolValue' is deprecated: use create instead
[-Werror,-Wdeprecated-declarations]
return DACtx->createTopBoolValue();
^~
create
/Users/jiefu/llvm-project/clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:227:3:
note: 'createTopBoolValue' has been explicitly marked deprecated here
LLVM_DEPRECATED("use create instead", "create")
^
/Users/jiefu/llvm-project/llvm/include/llvm/Support/Compiler.h:143:50: note:
expanded from macro 'LLVM_DEPRECATED'
^
2 errors generated.
Added:
Modified:
clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h
clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
clang/unittests/Analysis/FlowSensitive/DataflowAnalysisContextTest.cpp
Removed:
diff --git a/clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h
b/clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h
index ce11fc1c2b2d7..97ea6a573cffd 100644
--- a/clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h
+++ b/clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h
@@ -383,12 +383,12 @@ class Environment {
/// Returns an atomic boolean value.
BoolValue () const {
-return DACtx->createAtomicBoolValue();
+return DACtx->create();
}
/// Returns a unique instance of boolean Top.
BoolValue () const {
-return DACtx->createTopBoolValue();
+return DACtx->create();
}
/// Returns a boolean value that represents the conjunction of `LHS` and
diff --git a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
index 5a49ef195c0b1..4d8a42c1390c2 100644
--- a/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
+++ b/clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
@@ -157,7 +157,7 @@ BoolValue
::getOrCreateIff(BoolValue ,
}
AtomicBoolValue ::makeFlowConditionToken() {
- return createAtomicBoolValue();
+ return create();
}
void DataflowAnalysisContext::addFlowConditionConstraint(
@@ -378,8 +378,8 @@ DataflowAnalysisContext::getControlFlowContext(const
FunctionDecl *F) {
DataflowAnalysisContext::DataflowAnalysisContext(std::unique_ptr S,
Options Opts)
-: S(std::move(S)), TrueVal(createAtomicBoolValue()),
- FalseVal(createAtomicBoolValue()), Opts(Opts) {
+: S(std::move(S)), TrueVal(create()),
+ FalseVal(create()), Opts(Opts) {
assert(this->S != nullptr);
// If the -dataflow-log command-line flag was set, synthesize a logger.
// This is ugly but provides a uniform method for ad-hoc debugging dataflow-
diff --git
a/clang/unittests/Analysis/FlowSensitive/DataflowAnalysisContextTest.cpp
b/clang/unittests/Analysis/FlowSensitive/DataflowAnalysisContextTest.cpp
index 0efb341cc06e7..52b2d5c7a33a3 100644
--- a/clang/unittests/Analysis/FlowSensitive/DataflowAnalysisContextTest.cpp
+++ b/clang/unittests/Analysis/FlowSensitive/DataflowAnalysisContextTest.cpp
@@ -27,35 +27,35 @@ class DataflowAnalysisContextTest : public ::testing::Test {
TEST_F(DataflowAnalysisContextTest,
CreateAtomicBoolValueReturnsDistinctValues) {
- auto = Context.createAtomicBoolValue();
- auto = Context.createAtomicBoolValue();
+ auto = Context.create();
+ auto = Context.create();
[clang] 35537ae - [Modules][Test][NFC] Fix -Wsign-compare in clang/unittests/Lex/ModuleDeclStateTest.cpp
Author: Jie Fu
Date: 2023-02-10T10:51:21+08:00
New Revision: 35537aea1228df29c4e32049e4750029c5f0693b
URL:
https://github.com/llvm/llvm-project/commit/35537aea1228df29c4e32049e4750029c5f0693b
DIFF:
https://github.com/llvm/llvm-project/commit/35537aea1228df29c4e32049e4750029c5f0693b.diff
LOG: [Modules][Test][NFC] Fix -Wsign-compare in
clang/unittests/Lex/ModuleDeclStateTest.cpp
In file included from
/data/jiefu/llvm-project/clang/unittests/Lex/ModuleDeclStateTest.cpp:22:
/data/jiefu/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1526:11:
error: comparison of integers of different signs: 'const unsigned long' and
'const int' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^ ~~~
/data/jiefu/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1553:12:
note: in instantiation of function template specialization
'testing::internal::CmpHelperEQ' requested here
return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
^
/data/jiefu/llvm-project/clang/unittests/Lex/ModuleDeclStateTest.cpp:124:3:
note: in instantiation of function template specialization
'testing::internal::EqHelper::Compare' requested
here
EXPECT_EQ(Callback->importNamedModuleNum(), 0);
^
/data/jiefu/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2027:54:
note: expanded from macro 'EXPECT_EQ'
EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
^
1 error generated.
Added:
Modified:
clang/unittests/Lex/ModuleDeclStateTest.cpp
Removed:
diff --git a/clang/unittests/Lex/ModuleDeclStateTest.cpp
b/clang/unittests/Lex/ModuleDeclStateTest.cpp
index a8695391556f5..246d653a6c73a 100644
--- a/clang/unittests/Lex/ModuleDeclStateTest.cpp
+++ b/clang/unittests/Lex/ModuleDeclStateTest.cpp
@@ -121,7 +121,7 @@ export module foo;
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 0);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
@@ -140,7 +140,7 @@ module foo;
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 0);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_TRUE(PP->isInImplementationUnit());
@@ -159,7 +159,7 @@ module foo:part;
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 0);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
@@ -178,7 +178,7 @@ export module foo:part;
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 0);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
@@ -197,7 +197,7 @@ export module foo.dot:part.dot;
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 0);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
@@ -216,7 +216,7 @@ TEST_F(ModuleDeclStateTest, NotModule) {
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 0);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)0);
EXPECT_FALSE(PP->isInNamedModule());
EXPECT_FALSE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
@@ -242,7 +242,7 @@ import :another;
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 2);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)2);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
@@ -269,7 +269,7 @@ import :another;
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 2);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)2);
EXPECT_TRUE(PP->isInNamedModule());
EXPECT_TRUE(PP->isInNamedInterfaceUnit());
EXPECT_FALSE(PP->isInImplementationUnit());
@@ -295,7 +295,7 @@ import :another;
auto *Callback =
static_cast(PP->getPPCallbacks());
- EXPECT_EQ(Callback->importNamedModuleNum(), 1);
+ EXPECT_EQ(Callback->importNamedModuleNum(), (size_t)1);
EXPECT_FALSE(PP->isInNamedModule());
