[PATCH] D102306: Add gfx1034

[Mark Searles via Phabricator via cfe-commits]

msearles added a comment.

In D102306#2758166 , @JonChesterfield 
wrote:

> Is there documentation for the mapping from product names to gfx numbers?

See the Processors section of https://llvm.org/docs/AMDGPUUsage.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102306/new/

https://reviews.llvm.org/D102306

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96906: [AMDGPU] gfx90a support

[Mark Searles via Phabricator via cfe-commits]

msearles added a comment.

In D96906#2572749 , @kzhuravl wrote:

>> The point is that nobody upstream even got a chance to chime in.
>
> We are and will be taking care of any feedback provided in this review 
> post-commit.

To be fair to @rampitec , it was not his desire to push this up in 1 big patch. 
We needed this upstreamed and no time was given to him to break it up into 
reasonably sized pieces. If it appears to be his doing/his intent, well, it 
should not. There have been a couple comments; I believe most addressed; 
comments will continue to be addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96906/new/

https://reviews.llvm.org/D96906

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

[Mark Searles via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL332854: [Clang Tablegen] Add llvm_unreachable() to 
getModifierName() (authored by msearles, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D47150?vs=147809&id=147814#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D47150

Files:
  cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp


Index: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
===
--- cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,8 @@
   case MT_Unknown:
 llvm_unreachable("invalid modifier type");
   }
+  // Unhandled case
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {


Index: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
===
--- cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,8 @@
   case MT_Unknown:
 llvm_unreachable("invalid modifier type");
   }
+  // Unhandled case
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

[Mark Searles via Phabricator via cfe-commits]

msearles updated this revision to Diff 147809.
msearles added a comment.

Add comment per reviewer suggestion.


https://reviews.llvm.org/D47150

Files:
  utils/TableGen/ClangDiagnosticsEmitter.cpp


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,8 @@
   case MT_Unknown:
 llvm_unreachable("invalid modifier type");
   }
+  // Unhandled case
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,8 @@
   case MT_Unknown:
 llvm_unreachable("invalid modifier type");
   }
+  // Unhandled case
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

[Mark Searles via Phabricator via cfe-commits]

msearles updated this revision to Diff 147807.
msearles retitled this revision from "[Clang Tablegen] Add default case to 
getModifierName()" to "[Clang Tablegen]  Add llvm_unreachable() to 
getModifierName()".
msearles added a comment.

Ah, yes. Adding llvm_unreachable() is better. Done.


https://reviews.llvm.org/D47150

Files:
  utils/TableGen/ClangDiagnosticsEmitter.cpp


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,7 @@
   case MT_Unknown:
 llvm_unreachable("invalid modifier type");
   }
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,7 @@
   case MT_Unknown:
 llvm_unreachable("invalid modifier type");
   }
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47150: [Clang Tablegen] Add default case to getModifierName()

[Mark Searles via Phabricator via cfe-commits]

msearles created this revision.
msearles added reviewers: b-sumner, kzhuravl, EricWF, rjmccall.
Herald added subscribers: ioeric, ilya-biryukov.

  Fix internal build failure:
  
  ../../../ClangDiagnosticsEmitter.cpp -o ClangDiagnosticsEmitter.o
  ../../../ClangDiagnosticsEmitter.cpp: In function 'llvm::StringRef 
  {anonymous}::getModifierName({anonymous}::ModifierType)':
  ../../../ClangDiagnosticsEmitter.cpp:495:1: error: control reaches end of 
non-void function [-Werror=return-type]
  }
  ^
  
  Build failure triggered by git-svn-id: 
https://llvm.org/svn/llvm-project/cfe/trunk@332799 
91177308-0d34-0410-b5e6-96231b3b80d8


https://reviews.llvm.org/D47150

Files:
  utils/TableGen/ClangDiagnosticsEmitter.cpp


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -490,6 +490,7 @@
   case MT_ObjCInstance:
 return "objcinstance";
   case MT_Unknown:
+  default:
 llvm_unreachable("invalid modifier type");
   }
 }


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -490,6 +490,7 @@
   case MT_ObjCInstance:
 return "objcinstance";
   case MT_Unknown:
+  default:
 llvm_unreachable("invalid modifier type");
   }
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

[Mark Searles via Phabricator via cfe-commits]

msearles accepted this revision.
msearles added a comment.
This revision is now accepted and ready to land.

LGTM


https://reviews.llvm.org/D43094



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits