[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.
chfast added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5320 + if (!(Cleanup && Cleanup->getCleanup()->isRedundantBeforeReturn())) +CGM.ErrorUnsupported(MustTailCall, "tail call skipping over cleanups"); +} I reported a related issue. I wander if this is easy to fix. https://github.com/llvm/llvm-project/issues/53087. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D18914: [clang-tidy] new readability-redundant-inline
chfast added a comment. This check can be useful in other case like this: inline constexpr const int x = 1; where `inline` and `const` are redundant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18914/new/ https://reviews.llvm.org/D18914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D14104: clang-format: Add an additional value to AlignAfterOpenBracket: AlwaysBreak.
chfast added inline comments. Comment at: cfe/trunk/docs/ClangFormatStyleOptions.rst:173 + + someLongFunction(argument1, + argument2); I think this example is not achievable. clang-format seems to prefer putting all arguments on the next line if they all fit there. So this one will be formatted the same as the example for `AlwaysBreak`. Repository: rL LLVM https://reviews.llvm.org/D14104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
