[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

2021-04-21 Thread Yifeng Dong via Phabricator via cfe-commits 
dongAxis1944 accepted this revision.
dongAxis1944 added a comment.

LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100298/new/

https://reviews.llvm.org/D100298

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

2021-04-15 Thread Yifeng Dong via Phabricator via cfe-commits 
dongAxis1944 added a comment.

@jmorse I am not familiar with CHECK-DAG. And @probinson 's suggestion might be 
useful, any ideas?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100298/new/

https://reviews.llvm.org/D100298

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35383: [coroutines] Add serialization/deserialization of coroutines

2020-12-29 Thread Yifeng Dong via Phabricator via cfe-commits 
dongAxis1944 added inline comments.
Herald added a subscriber: lxfind.



Comment at: cfe/trunk/lib/AST/StmtCXX.cpp:107-108
+  Result->NumParams = NumParams;
+  auto *ParamBegin = Result->getStoredStmts() + SubStmt::FirstParamMove;
+  std::uninitialized_fill(ParamBegin, ParamBegin + NumParams,
+  static_cast(nullptr));

hello, i have a question about that why clang commit info of parameters again 
in coroutine body?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D35383/new/

https://reviews.llvm.org/D35383

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits