[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-18 Thread Yuki Okushi via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7eb046624f2a: Prefer `getCurrentFileOrBufferName` in 
`FrontendAction::EndSourceFile` (authored by JohnTitor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127509/new/

https://reviews.llvm.org/D127509

Files:
  clang/lib/Frontend/FrontendAction.cpp


Index: clang/lib/Frontend/FrontendAction.cpp
===
--- clang/lib/Frontend/FrontendAction.cpp
+++ clang/lib/Frontend/FrontendAction.cpp
@@ -1075,7 +1075,7 @@
   }
 
   if (CI.getFrontendOpts().ShowStats) {
-llvm::errs() << "\nSTATISTICS FOR '" << getCurrentFile() << "':\n";
+llvm::errs() << "\nSTATISTICS FOR '" << getCurrentFileOrBufferName() << 
"':\n";
 CI.getPreprocessor().PrintStats();
 CI.getPreprocessor().getIdentifierTable().PrintStats();
 CI.getPreprocessor().getHeaderSearchInfo().PrintStats();


Index: clang/lib/Frontend/FrontendAction.cpp
===
--- clang/lib/Frontend/FrontendAction.cpp
+++ clang/lib/Frontend/FrontendAction.cpp
@@ -1075,7 +1075,7 @@
   }
 
   if (CI.getFrontendOpts().ShowStats) {
-llvm::errs() << "\nSTATISTICS FOR '" << getCurrentFile() << "':\n";
+llvm::errs() << "\nSTATISTICS FOR '" << getCurrentFileOrBufferName() << "':\n";
 CI.getPreprocessor().PrintStats();
 CI.getPreprocessor().getIdentifierTable().PrintStats();
 CI.getPreprocessor().getHeaderSearchInfo().PrintStats();
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-18 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor added a comment.

Alright, let's go ahead then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127509/new/

https://reviews.llvm.org/D127509

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-17 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor added a comment.

I've re-triggered it several times but it shows the same failure, maybe they're 
valid?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127509/new/

https://reviews.llvm.org/D127509

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

2022-06-12 Thread Yuki Okushi via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe43a85a363cf: [docs][clang] Fix a broken link on the 
APINotes doc (authored by JohnTitor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126599/new/

https://reviews.llvm.org/D126599

Files:
  clang/docs/APINotes.rst


Index: clang/docs/APINotes.rst
===
--- clang/docs/APINotes.rst
+++ clang/docs/APINotes.rst
@@ -22,11 +22,11 @@
 That's API notes.
 
 API notes use a YAML-based file format. YAML is a format best explained by
-example, so here is a `small example`__ from the compiler test suite of API
+example, so here is a `small example
+`_
+from the compiler test suite of API
 notes for a hypothetical "SomeKit" framework.
 
-__ test/APINotes/Inputs/Frameworks/SomeKit.framework/Headers/SomeKit.apinotes
-
 
 Usage
 =


Index: clang/docs/APINotes.rst
===
--- clang/docs/APINotes.rst
+++ clang/docs/APINotes.rst
@@ -22,11 +22,11 @@
 That's API notes.
 
 API notes use a YAML-based file format. YAML is a format best explained by
-example, so here is a `small example`__ from the compiler test suite of API
+example, so here is a `small example
+`_
+from the compiler test suite of API
 notes for a hypothetical "SomeKit" framework.
 
-__ test/APINotes/Inputs/Frameworks/SomeKit.framework/Headers/SomeKit.apinotes
-
 
 Usage
 =
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

2022-06-12 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor added a comment.

> It seems that other docs are following the GitHub URLs as well. I wish we 
> could do the relative document link instead of embedding the URL, but if that 
> is not possible, then this makes sense to do.

I couldn't find the URL serving that file and I'm not familiar with doing that. 
Let's use a GitHub URL for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126599/new/

https://reviews.llvm.org/D126599

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-10 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

`getCurrentFile` here causes an assertion on some condition.
`getCurrentFileOrBufferName` is preferrable instead.

llvm#55950


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127509

Files:
  clang/lib/Frontend/FrontendAction.cpp


Index: clang/lib/Frontend/FrontendAction.cpp
===
--- clang/lib/Frontend/FrontendAction.cpp
+++ clang/lib/Frontend/FrontendAction.cpp
@@ -1075,7 +1075,7 @@
   }
 
   if (CI.getFrontendOpts().ShowStats) {
-llvm::errs() << "\nSTATISTICS FOR '" << getCurrentFile() << "':\n";
+llvm::errs() << "\nSTATISTICS FOR '" << getCurrentFileOrBufferName() << 
"':\n";
 CI.getPreprocessor().PrintStats();
 CI.getPreprocessor().getIdentifierTable().PrintStats();
 CI.getPreprocessor().getHeaderSearchInfo().PrintStats();


Index: clang/lib/Frontend/FrontendAction.cpp
===
--- clang/lib/Frontend/FrontendAction.cpp
+++ clang/lib/Frontend/FrontendAction.cpp
@@ -1075,7 +1075,7 @@
   }
 
   if (CI.getFrontendOpts().ShowStats) {
-llvm::errs() << "\nSTATISTICS FOR '" << getCurrentFile() << "':\n";
+llvm::errs() << "\nSTATISTICS FOR '" << getCurrentFileOrBufferName() << "':\n";
 CI.getPreprocessor().PrintStats();
 CI.getPreprocessor().getIdentifierTable().PrintStats();
 CI.getPreprocessor().getHeaderSearchInfo().PrintStats();
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127411: [AST Matchers] Make dump_ast_matchers.py work on Python 3

2022-06-09 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.

...Also updates the output HTML.
Fixes llvm#46446


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127411

Files:
  clang/docs/LibASTMatchersReference.html
  clang/docs/tools/dump_ast_matchers.py

Index: clang/docs/tools/dump_ast_matchers.py
===
--- clang/docs/tools/dump_ast_matchers.py
+++ clang/docs/tools/dump_ast_matchers.py
@@ -12,7 +12,7 @@
 
 CLASS_INDEX_PAGE_URL = 'https://clang.llvm.org/doxygen/classes.html'
 try:
-  CLASS_INDEX_PAGE = urlopen(CLASS_INDEX_PAGE_URL).read()
+  CLASS_INDEX_PAGE = str(urlopen(CLASS_INDEX_PAGE_URL).read())
 except Exception as e:
   raise Exception('Unable to get %s: %s' % (CLASS_INDEX_PAGE_URL, e))
 
@@ -403,7 +403,7 @@
 
 # Parse free standing matcher functions, like:
 #   Matcher Name(Matcher InnerMatcher) {
-m = re.match(r"""^\s*(?:template\s+<\s*(?:class|typename)\s+(.+)\s*>\s+)?   
+m = re.match(r"""^\s*(?:template\s+<\s*(?:class|typename)\s+(.+)\s*>\s+)?
  (.*)\s+
  ([^\s\(]+)\s*\(
  (.*)
@@ -422,7 +422,7 @@
   m = re.match(r'(?:^|.*\s+)internal::(?:Bindable)?Matcher<([^>]+)>$', result)
   if m:
 result_types = [m.group(1)]
-if template_name and len(result_types) is 1 and result_types[0] == template_name:
+if template_name and len(result_types) == 1 and result_types[0] == template_name:
   result_types = ['*']
   else:
 result_types = extract_result_types(comment)
@@ -479,7 +479,7 @@
 comment += re.sub(r'^/+\s?', '', line) + '\n'
   else:
 declaration += ' ' + line
-if ((not line.strip()) or 
+if ((not line.strip()) or
 line.rstrip()[-1] == ';' or
 (line.rstrip()[-1] == '{' and line.rstrip()[-3:] != '= {')):
   if line.strip() and line.rstrip()[-1] == '{':
@@ -502,6 +502,5 @@
 reference = re.sub(r'',
traversal_matcher_table, reference, flags=re.S)
 
-with open('../LibASTMatchersReference.html', 'wb') as output:
+with open('../LibASTMatchersReference.html', 'w') as output:
   output.write(reference)
-
Index: clang/docs/LibASTMatchersReference.html
===
--- clang/docs/LibASTMatchersReference.html
+++ clang/docs/LibASTMatchersReference.html
@@ -1236,7 +1236,7 @@
   #pragma omp parallel
 
 ``ompDefaultClause()`` matches ``default(none)``, ``default(shared)``,
-``default(private)`` and ``default(firstprivate)``
+`` default(private)`` and ``default(firstprivate)``
 
 
 
@@ -4716,8 +4716,8 @@
 
 
 
-Matcherhttps://clang.llvm.org/doxygen/classclang_1_1OMPDefaultClause.html;>OMPDefaultClauseisFirstPrivateKind
-Matches if the OpenMP ``default`` clause has ``private`` kind
+Matcherhttps://clang.llvm.org/doxygen/classclang_1_1OMPDefaultClause.html;>OMPDefaultClauseisFirstPrivateKind
+Matches if the OpenMP ``default`` clause has ``firstprivate`` kind
 specified.
 
 Given
@@ -4729,12 +4729,12 @@
   #pragma omp parallel default(firstprivate)
 
 ``ompDefaultClause(isFirstPrivateKind())`` matches only
-``default(private)``.
+``default(firstprivate)``.
 
 
-Matcherhttps://clang.llvm.org/doxygen/classclang_1_1OMPDefaultClause.html;>OMPDefaultClauseisFirstPrivateKind
-Matches if the OpenMP ``default`` clause has ``firstprivate`` kind
-specified.
+
+Matcherhttps://clang.llvm.org/doxygen/classclang_1_1OMPDefaultClause.html;>OMPDefaultClauseisNoneKind
+Matches if the OpenMP ``default`` clause has ``none`` kind specified.
 
 Given
 
@@ -4744,13 +4744,13 @@
   #pragma omp parallel default(private)
   #pragma omp parallel default(firstprivate)
 
-``ompDefaultClause(isFirstPrivateKind())`` matches only
-``default(firstprivate)``.
+``ompDefaultClause(isNoneKind())`` matches only ``default(none)``.
 
 
 
-Matcherhttps://clang.llvm.org/doxygen/classclang_1_1OMPDefaultClause.html;>OMPDefaultClauseisNoneKind
-Matches if the OpenMP ``default`` clause has ``none`` kind specified.
+Matcherhttps://clang.llvm.org/doxygen/classclang_1_1OMPDefaultClause.html;>OMPDefaultClauseisPrivateKind
+Matches if the OpenMP ``default`` clause has ``private`` kind
+specified.
 
 Given
 
@@ -4760,7 +4760,8 @@
   #pragma omp parallel default(private)
   #pragma omp parallel default(firstprivate)
 
-``ompDefaultClause(isNoneKind())`` matches only ``default(none)``.
+``ompDefaultClause(isPrivateKind())`` matches only
+``default(private)``.
 
 
 
@@ -7411,8 +7412,9 @@
 
 
 
-Matcherhttps://clang.llvm.org/doxygen/classclang_1_1ClassTemplateSpecializationDecl.html;>ClassTemplateSpecializationDeclforEachTemplateArgumentMatcherhttps://clang.llvm.org/doxygen/classclang_1_1TemplateArgument.html;>TemplateArgument InnerMatcher
-Matches classTemplateSpecialization,

[PATCH] D127407: [ubsan][docs] Clarify `objc-cast` is not part of `-fsanitize=undefined`

2022-06-09 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

It was missed on https://reviews.llvm.org/D71491.
Fixes llvm#54880


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127407

Files:
  clang/docs/UndefinedBehaviorSanitizer.rst


Index: clang/docs/UndefinedBehaviorSanitizer.rst
===
--- clang/docs/UndefinedBehaviorSanitizer.rst
+++ clang/docs/UndefinedBehaviorSanitizer.rst
@@ -184,8 +184,8 @@
 You can also use the following check groups:
   -  ``-fsanitize=undefined``: All of the checks listed above other than
  ``float-divide-by-zero``, ``unsigned-integer-overflow``,
- ``implicit-conversion``, ``local-bounds`` and the ``nullability-*`` group
- of checks.
+ ``implicit-conversion``, ``local-bounds``, ``objc-cast``, and
+ the ``nullability-*`` group of checks.
   -  ``-fsanitize=undefined-trap``: Deprecated alias of
  ``-fsanitize=undefined``.
   -  ``-fsanitize=implicit-integer-truncation``: Catches lossy integral


Index: clang/docs/UndefinedBehaviorSanitizer.rst
===
--- clang/docs/UndefinedBehaviorSanitizer.rst
+++ clang/docs/UndefinedBehaviorSanitizer.rst
@@ -184,8 +184,8 @@
 You can also use the following check groups:
   -  ``-fsanitize=undefined``: All of the checks listed above other than
  ``float-divide-by-zero``, ``unsigned-integer-overflow``,
- ``implicit-conversion``, ``local-bounds`` and the ``nullability-*`` group
- of checks.
+ ``implicit-conversion``, ``local-bounds``, ``objc-cast``, and
+ the ``nullability-*`` group of checks.
   -  ``-fsanitize=undefined-trap``: Deprecated alias of
  ``-fsanitize=undefined``.
   -  ``-fsanitize=implicit-integer-truncation``: Catches lossy integral
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127065: [docs] Update supported language standards list for C++

2022-06-09 Thread Yuki Okushi via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcedfb5462cd8: [docs] Update supported language standards 
list for C++ (authored by JohnTitor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127065/new/

https://reviews.llvm.org/D127065

Files:
  clang/docs/CommandGuide/clang.rst


Index: clang/docs/CommandGuide/clang.rst
===
--- clang/docs/CommandGuide/clang.rst
+++ clang/docs/CommandGuide/clang.rst
@@ -185,13 +185,21 @@
 
ISO C++ 2017 with amendments and GNU extensions
 
-  | ``c++2a``
+  | ``c++20``
 
-   Working draft for ISO C++ 2020
+   ISO C++ 2020 with amendments
 
-  | ``gnu++2a``
+  | ``gnu++20``
 
-   Working draft for ISO C++ 2020 with GNU extensions
+   ISO C++ 2020 with amendments and GNU extensions
+
+  | ``c++2b``
+
+   Working draft for ISO C++ 2023
+
+  | ``gnu++2b``
+
+   Working draft for ISO C++ 2023 with GNU extensions
 
  The default C++ language standard is ``gnu++14``.
 


Index: clang/docs/CommandGuide/clang.rst
===
--- clang/docs/CommandGuide/clang.rst
+++ clang/docs/CommandGuide/clang.rst
@@ -185,13 +185,21 @@
 
ISO C++ 2017 with amendments and GNU extensions
 
-  | ``c++2a``
+  | ``c++20``
 
-   Working draft for ISO C++ 2020
+   ISO C++ 2020 with amendments
 
-  | ``gnu++2a``
+  | ``gnu++20``
 
-   Working draft for ISO C++ 2020 with GNU extensions
+   ISO C++ 2020 with amendments and GNU extensions
+
+  | ``c++2b``
+
+   Working draft for ISO C++ 2023
+
+  | ``gnu++2b``
+
+   Working draft for ISO C++ 2023 with GNU extensions
 
  The default C++ language standard is ``gnu++14``.
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

2022-06-07 Thread Yuki Okushi via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaa9b3389ffd8: [clang] Remove some `U+C2AD`s in 
`__cpp_multidimensional_subscript` (authored by JohnTitor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127066/new/

https://reviews.llvm.org/D127066

Files:
  clang/lib/Frontend/InitPreprocessor.cpp


Index: clang/lib/Frontend/InitPreprocessor.cpp
===
--- clang/lib/Frontend/InitPreprocessor.cpp
+++ clang/lib/Frontend/InitPreprocessor.cpp
@@ -690,7 +690,7 @@
 Builder.defineMacro("__cpp_implicit_move", "202011L");
 Builder.defineMacro("__cpp_size_t_suffix", "202011L");
 Builder.defineMacro("__cpp_if_consteval", "202106L");
-Builder.defineMacro("__cpp_­multidimensional_­subscript", "202110L");
+Builder.defineMacro("__cpp_multidimensional_subscript", "202110L");
   }
   if (LangOpts.Char8)
 Builder.defineMacro("__cpp_char8_t", "201811L");


Index: clang/lib/Frontend/InitPreprocessor.cpp
===
--- clang/lib/Frontend/InitPreprocessor.cpp
+++ clang/lib/Frontend/InitPreprocessor.cpp
@@ -690,7 +690,7 @@
 Builder.defineMacro("__cpp_implicit_move", "202011L");
 Builder.defineMacro("__cpp_size_t_suffix", "202011L");
 Builder.defineMacro("__cpp_if_consteval", "202106L");
-Builder.defineMacro("__cpp_­multidimensional_­subscript", "202110L");
+Builder.defineMacro("__cpp_multidimensional_subscript", "202110L");
   }
   if (LangOpts.Char8)
 Builder.defineMacro("__cpp_char8_t", "201811L");
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

2022-06-07 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor added a comment.

> It took me a moment, but this actually removes a 0xC2AD and not a 0x00AD. 
> It's still correct, but I was wondering why no character was printed in the 
> text -- 0xC2AD is not a defined Unicode character.

Oh, my editor said it 0x00AD, it's weird. Anyway thanks for clarifying.

> can you correct the patch title + summary when committing?

Sure!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127066/new/

https://reviews.llvm.org/D127066

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

2022-06-04 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The `Builder.defineMacro("__cpp_multidimensional_subscript", "202110L");` line 
has
some `U+00AD`s that shouldn't necessary here. So removed them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127066

Files:
  clang/lib/Frontend/InitPreprocessor.cpp


Index: clang/lib/Frontend/InitPreprocessor.cpp
===
--- clang/lib/Frontend/InitPreprocessor.cpp
+++ clang/lib/Frontend/InitPreprocessor.cpp
@@ -690,7 +690,7 @@
 Builder.defineMacro("__cpp_implicit_move", "202011L");
 Builder.defineMacro("__cpp_size_t_suffix", "202011L");
 Builder.defineMacro("__cpp_if_consteval", "202106L");
-Builder.defineMacro("__cpp_­multidimensional_­subscript", "202110L");
+Builder.defineMacro("__cpp_multidimensional_subscript", "202110L");
   }
   if (LangOpts.Char8)
 Builder.defineMacro("__cpp_char8_t", "201811L");


Index: clang/lib/Frontend/InitPreprocessor.cpp
===
--- clang/lib/Frontend/InitPreprocessor.cpp
+++ clang/lib/Frontend/InitPreprocessor.cpp
@@ -690,7 +690,7 @@
 Builder.defineMacro("__cpp_implicit_move", "202011L");
 Builder.defineMacro("__cpp_size_t_suffix", "202011L");
 Builder.defineMacro("__cpp_if_consteval", "202106L");
-Builder.defineMacro("__cpp_­multidimensional_­subscript", "202110L");
+Builder.defineMacro("__cpp_multidimensional_subscript", "202110L");
   }
   if (LangOpts.Char8)
 Builder.defineMacro("__cpp_char8_t", "201811L");
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127065: [docs] Update supported language standards list for C++

2022-06-04 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127065

Files:
  clang/docs/CommandGuide/clang.rst


Index: clang/docs/CommandGuide/clang.rst
===
--- clang/docs/CommandGuide/clang.rst
+++ clang/docs/CommandGuide/clang.rst
@@ -185,13 +185,21 @@
 
ISO C++ 2017 with amendments and GNU extensions
 
-  | ``c++2a``
+  | ``c++20``
 
-   Working draft for ISO C++ 2020
+   ISO C++ 2020 with amendments
 
-  | ``gnu++2a``
+  | ``gnu++20``
 
-   Working draft for ISO C++ 2020 with GNU extensions
+   ISO C++ 2020 with amendments and GNU extensions
+
+  | ``c++2b``
+
+   Working draft for ISO C++ 2023
+
+  | ``gnu++2b``
+
+   Working draft for ISO C++ 2023 with GNU extensions
 
  The default C++ language standard is ``gnu++14``.
 


Index: clang/docs/CommandGuide/clang.rst
===
--- clang/docs/CommandGuide/clang.rst
+++ clang/docs/CommandGuide/clang.rst
@@ -185,13 +185,21 @@
 
ISO C++ 2017 with amendments and GNU extensions
 
-  | ``c++2a``
+  | ``c++20``
 
-   Working draft for ISO C++ 2020
+   ISO C++ 2020 with amendments
 
-  | ``gnu++2a``
+  | ``gnu++20``
 
-   Working draft for ISO C++ 2020 with GNU extensions
+   ISO C++ 2020 with amendments and GNU extensions
+
+  | ``c++2b``
+
+   Working draft for ISO C++ 2023
+
+  | ``gnu++2b``
+
+   Working draft for ISO C++ 2023 with GNU extensions
 
  The default C++ language standard is ``gnu++14``.
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126608: [clangd] Remove a test with a duplicate of FileCacheTests

2022-05-31 Thread Yuki Okushi via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5c1494039491: [clangd] Remove a test with a duplicate of 
FileCacheTests (authored by JohnTitor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126608/new/

https://reviews.llvm.org/D126608

Files:
  clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp


Index: clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
===
--- clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
+++ clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
@@ -178,44 +178,6 @@
   EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("bar", "baz"));
 }
 
-// FIXME: delete this test, it's covered by FileCacheTests.
-TEST(ProviderTest, Staleness) {
-  MockFS FS;
-
-  auto StartTime = std::chrono::steady_clock::now();
-  Params StaleOK;
-  StaleOK.FreshTime = StartTime;
-  Params MustBeFresh;
-  MustBeFresh.FreshTime = StartTime + std::chrono::hours(1);
-  CapturedDiags Diags;
-  auto P = Provider::fromYAMLFile(testPath("foo.yaml"), /*Directory=*/"", FS);
-
-  // Initial query always reads, regardless of policy.
-  FS.Files["foo.yaml"] = AddFooWithErr;
-  auto Cfg = P->getConfig(StaleOK, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics,
-  ElementsAre(diagMessage("Unknown CompileFlags key 'Unknown'")));
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("foo"));
-  Diags.clear();
-
-  // Stale value reused by policy.
-  FS.Files["foo.yaml"] = AddBarBaz;
-  Cfg = P->getConfig(StaleOK, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty()) << "Cached, not re-parsed";
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("foo"));
-
-  // Cache revalidated by policy.
-  Cfg = P->getConfig(MustBeFresh, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty()) << "New config, no errors";
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("bar", "baz"));
-
-  // Cache revalidated by (default) policy.
-  FS.Files.erase("foo.yaml");
-  Cfg = P->getConfig(Params(), Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty());
-  EXPECT_THAT(getAddedArgs(Cfg), IsEmpty());
-}
-
 TEST(ProviderTest, SourceInfo) {
   MockFS FS;
 


Index: clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
===
--- clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
+++ clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
@@ -178,44 +178,6 @@
   EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("bar", "baz"));
 }
 
-// FIXME: delete this test, it's covered by FileCacheTests.
-TEST(ProviderTest, Staleness) {
-  MockFS FS;
-
-  auto StartTime = std::chrono::steady_clock::now();
-  Params StaleOK;
-  StaleOK.FreshTime = StartTime;
-  Params MustBeFresh;
-  MustBeFresh.FreshTime = StartTime + std::chrono::hours(1);
-  CapturedDiags Diags;
-  auto P = Provider::fromYAMLFile(testPath("foo.yaml"), /*Directory=*/"", FS);
-
-  // Initial query always reads, regardless of policy.
-  FS.Files["foo.yaml"] = AddFooWithErr;
-  auto Cfg = P->getConfig(StaleOK, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics,
-  ElementsAre(diagMessage("Unknown CompileFlags key 'Unknown'")));
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("foo"));
-  Diags.clear();
-
-  // Stale value reused by policy.
-  FS.Files["foo.yaml"] = AddBarBaz;
-  Cfg = P->getConfig(StaleOK, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty()) << "Cached, not re-parsed";
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("foo"));
-
-  // Cache revalidated by policy.
-  Cfg = P->getConfig(MustBeFresh, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty()) << "New config, no errors";
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("bar", "baz"));
-
-  // Cache revalidated by (default) policy.
-  FS.Files.erase("foo.yaml");
-  Cfg = P->getConfig(Params(), Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty());
-  EXPECT_THAT(getAddedArgs(Cfg), IsEmpty());
-}
-
 TEST(ProviderTest, SourceInfo) {
   MockFS FS;
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126608: [clangd] Remove a test with a duplicate of FileCacheTests

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

FIXME says it should be removed so followed it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126608

Files:
  clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp


Index: clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
===
--- clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
+++ clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
@@ -178,44 +178,6 @@
   EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("bar", "baz"));
 }
 
-// FIXME: delete this test, it's covered by FileCacheTests.
-TEST(ProviderTest, Staleness) {
-  MockFS FS;
-
-  auto StartTime = std::chrono::steady_clock::now();
-  Params StaleOK;
-  StaleOK.FreshTime = StartTime;
-  Params MustBeFresh;
-  MustBeFresh.FreshTime = StartTime + std::chrono::hours(1);
-  CapturedDiags Diags;
-  auto P = Provider::fromYAMLFile(testPath("foo.yaml"), /*Directory=*/"", FS);
-
-  // Initial query always reads, regardless of policy.
-  FS.Files["foo.yaml"] = AddFooWithErr;
-  auto Cfg = P->getConfig(StaleOK, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics,
-  ElementsAre(diagMessage("Unknown CompileFlags key 'Unknown'")));
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("foo"));
-  Diags.clear();
-
-  // Stale value reused by policy.
-  FS.Files["foo.yaml"] = AddBarBaz;
-  Cfg = P->getConfig(StaleOK, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty()) << "Cached, not re-parsed";
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("foo"));
-
-  // Cache revalidated by policy.
-  Cfg = P->getConfig(MustBeFresh, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty()) << "New config, no errors";
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("bar", "baz"));
-
-  // Cache revalidated by (default) policy.
-  FS.Files.erase("foo.yaml");
-  Cfg = P->getConfig(Params(), Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty());
-  EXPECT_THAT(getAddedArgs(Cfg), IsEmpty());
-}
-
 TEST(ProviderTest, SourceInfo) {
   MockFS FS;
 


Index: clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
===
--- clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
+++ clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
@@ -178,44 +178,6 @@
   EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("bar", "baz"));
 }
 
-// FIXME: delete this test, it's covered by FileCacheTests.
-TEST(ProviderTest, Staleness) {
-  MockFS FS;
-
-  auto StartTime = std::chrono::steady_clock::now();
-  Params StaleOK;
-  StaleOK.FreshTime = StartTime;
-  Params MustBeFresh;
-  MustBeFresh.FreshTime = StartTime + std::chrono::hours(1);
-  CapturedDiags Diags;
-  auto P = Provider::fromYAMLFile(testPath("foo.yaml"), /*Directory=*/"", FS);
-
-  // Initial query always reads, regardless of policy.
-  FS.Files["foo.yaml"] = AddFooWithErr;
-  auto Cfg = P->getConfig(StaleOK, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics,
-  ElementsAre(diagMessage("Unknown CompileFlags key 'Unknown'")));
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("foo"));
-  Diags.clear();
-
-  // Stale value reused by policy.
-  FS.Files["foo.yaml"] = AddBarBaz;
-  Cfg = P->getConfig(StaleOK, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty()) << "Cached, not re-parsed";
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("foo"));
-
-  // Cache revalidated by policy.
-  Cfg = P->getConfig(MustBeFresh, Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty()) << "New config, no errors";
-  EXPECT_THAT(getAddedArgs(Cfg), ElementsAre("bar", "baz"));
-
-  // Cache revalidated by (default) policy.
-  FS.Files.erase("foo.yaml");
-  Cfg = P->getConfig(Params(), Diags.callback());
-  EXPECT_THAT(Diags.Diagnostics, IsEmpty());
-  EXPECT_THAT(getAddedArgs(Cfg), IsEmpty());
-}
-
 TEST(ProviderTest, SourceInfo) {
   MockFS FS;
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126607: [docs] Remove some unavailable modindex links

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a subscriber: arphaman.
Herald added projects: Flang, All.
JohnTitor requested review of this revision.
Herald added subscribers: cfe-commits, jdoerfert.
Herald added a project: clang.

These return 404 and I think it's fine to remove them until we can build.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126607

Files:
  clang/docs/index.rst
  flang/docs/index.md


Index: flang/docs/index.md
===
--- flang/docs/index.md
+++ flang/docs/index.md
@@ -68,6 +68,5 @@
 
 ```eval_rst
 * :ref:`genindex`
-* :ref:`modindex`
 * :ref:`search`
 ```
Index: clang/docs/index.rst
===
--- clang/docs/index.rst
+++ clang/docs/index.rst
@@ -109,6 +109,5 @@
 ==
 
 * :ref:`genindex`
-* :ref:`modindex`
 * :ref:`search`
 


Index: flang/docs/index.md
===
--- flang/docs/index.md
+++ flang/docs/index.md
@@ -68,6 +68,5 @@
 
 ```eval_rst
 * :ref:`genindex`
-* :ref:`modindex`
 * :ref:`search`
 ```
Index: clang/docs/index.rst
===
--- clang/docs/index.rst
+++ clang/docs/index.rst
@@ -109,6 +109,5 @@
 ==
 
 * :ref:`genindex`
-* :ref:`modindex`
 * :ref:`search`
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126597: [clang] Remove `rm` script which is no longer necessary

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG41a054ef7885: [clang] Remove `rm` script which is no longer 
necessary (authored by JohnTitor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126597/new/

https://reviews.llvm.org/D126597

Files:
  clang/test/Sema/test-wunaligned-access.c


Index: clang/test/Sema/test-wunaligned-access.c
===
--- clang/test/Sema/test-wunaligned-access.c
+++ clang/test/Sema/test-wunaligned-access.c
@@ -1,6 +1,3 @@
-// FIXME: Remove rm after a few days.
-// RUN: rm -f %S/test-wunaligned-access.ll
-
 // RUN: %clang_cc1 %s -triple=armv7-none-none-eabi -verify -Wunaligned-access 
-S -emit-llvm -o %t
 // REQUIRES: arm-registered-target
 //


Index: clang/test/Sema/test-wunaligned-access.c
===
--- clang/test/Sema/test-wunaligned-access.c
+++ clang/test/Sema/test-wunaligned-access.c
@@ -1,6 +1,3 @@
-// FIXME: Remove rm after a few days.
-// RUN: rm -f %S/test-wunaligned-access.ll
-
 // RUN: %clang_cc1 %s -triple=armv7-none-none-eabi -verify -Wunaligned-access -S -emit-llvm -o %t
 // REQUIRES: arm-registered-target
 //
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This patch replaces a link with a GitHub one.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126599

Files:
  clang/docs/APINotes.rst


Index: clang/docs/APINotes.rst
===
--- clang/docs/APINotes.rst
+++ clang/docs/APINotes.rst
@@ -22,11 +22,11 @@
 That's API notes.
 
 API notes use a YAML-based file format. YAML is a format best explained by
-example, so here is a `small example`__ from the compiler test suite of API
+example, so here is a `small example
+`_
+from the compiler test suite of API
 notes for a hypothetical "SomeKit" framework.
 
-__ test/APINotes/Inputs/Frameworks/SomeKit.framework/Headers/SomeKit.apinotes
-
 
 Usage
 =


Index: clang/docs/APINotes.rst
===
--- clang/docs/APINotes.rst
+++ clang/docs/APINotes.rst
@@ -22,11 +22,11 @@
 That's API notes.
 
 API notes use a YAML-based file format. YAML is a format best explained by
-example, so here is a `small example`__ from the compiler test suite of API
+example, so here is a `small example
+`_
+from the compiler test suite of API
 notes for a hypothetical "SomeKit" framework.
 
-__ test/APINotes/Inputs/Frameworks/SomeKit.framework/Headers/SomeKit.apinotes
-
 
 Usage
 =
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126597: [clang] Remove `rm` script which is no longer necessary

2022-05-28 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

8b4fa2c98e07997469f53bee30c0d24a61dc7c8c 
 added 
this to remove left-over files on January.
Now we could assume they're cleaned up and this `rm` script is no longer 
necessary as FIXME states.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126597

Files:
  clang/test/Sema/test-wunaligned-access.c


Index: clang/test/Sema/test-wunaligned-access.c
===
--- clang/test/Sema/test-wunaligned-access.c
+++ clang/test/Sema/test-wunaligned-access.c
@@ -1,6 +1,3 @@
-// FIXME: Remove rm after a few days.
-// RUN: rm -f %S/test-wunaligned-access.ll
-
 // RUN: %clang_cc1 %s -triple=armv7-none-none-eabi -verify -Wunaligned-access 
-S -emit-llvm -o %t
 // REQUIRES: arm-registered-target
 //


Index: clang/test/Sema/test-wunaligned-access.c
===
--- clang/test/Sema/test-wunaligned-access.c
+++ clang/test/Sema/test-wunaligned-access.c
@@ -1,6 +1,3 @@
-// FIXME: Remove rm after a few days.
-// RUN: rm -f %S/test-wunaligned-access.ll
-
 // RUN: %clang_cc1 %s -triple=armv7-none-none-eabi -verify -Wunaligned-access -S -emit-llvm -o %t
 // REQUIRES: arm-registered-target
 //
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

2022-05-27 Thread Yuki Okushi via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd3d3e2528e60: [CompilerInstance] Fix weird condition on 
`createCodeCompletionConsumer` (authored by JohnTitor).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126524/new/

https://reviews.llvm.org/D126524

Files:
  clang/lib/Frontend/CompilerInstance.cpp


Index: clang/lib/Frontend/CompilerInstance.cpp
===
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -710,13 +710,10 @@
 void CompilerInstance::createCodeCompletionConsumer() {
   const ParsedSourceLocation  = getFrontendOpts().CodeCompletionAt;
   if (!CompletionConsumer) {
-setCodeCompletionConsumer(
-  createCodeCompletionConsumer(getPreprocessor(),
-   Loc.FileName, Loc.Line, Loc.Column,
-   getFrontendOpts().CodeCompleteOpts,
-   llvm::outs()));
-if (!CompletionConsumer)
-  return;
+setCodeCompletionConsumer(createCodeCompletionConsumer(
+getPreprocessor(), Loc.FileName, Loc.Line, Loc.Column,
+getFrontendOpts().CodeCompleteOpts, llvm::outs()));
+return;
   } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
   Loc.Line, Loc.Column)) {
 setCodeCompletionConsumer(nullptr);


Index: clang/lib/Frontend/CompilerInstance.cpp
===
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -710,13 +710,10 @@
 void CompilerInstance::createCodeCompletionConsumer() {
   const ParsedSourceLocation  = getFrontendOpts().CodeCompletionAt;
   if (!CompletionConsumer) {
-setCodeCompletionConsumer(
-  createCodeCompletionConsumer(getPreprocessor(),
-   Loc.FileName, Loc.Line, Loc.Column,
-   getFrontendOpts().CodeCompleteOpts,
-   llvm::outs()));
-if (!CompletionConsumer)
-  return;
+setCodeCompletionConsumer(createCodeCompletionConsumer(
+getPreprocessor(), Loc.FileName, Loc.Line, Loc.Column,
+getFrontendOpts().CodeCompleteOpts, llvm::outs()));
+return;
   } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
   Loc.Line, Loc.Column)) {
 setCodeCompletionConsumer(nullptr);
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

2022-05-27 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor updated this revision to Diff 432527.
JohnTitor added a comment.

Fix the indention


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126524/new/

https://reviews.llvm.org/D126524

Files:
  clang/lib/Frontend/CompilerInstance.cpp


Index: clang/lib/Frontend/CompilerInstance.cpp
===
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -710,13 +710,10 @@
 void CompilerInstance::createCodeCompletionConsumer() {
   const ParsedSourceLocation  = getFrontendOpts().CodeCompletionAt;
   if (!CompletionConsumer) {
-setCodeCompletionConsumer(
-  createCodeCompletionConsumer(getPreprocessor(),
-   Loc.FileName, Loc.Line, Loc.Column,
-   getFrontendOpts().CodeCompleteOpts,
-   llvm::outs()));
-if (!CompletionConsumer)
-  return;
+setCodeCompletionConsumer(createCodeCompletionConsumer(
+getPreprocessor(), Loc.FileName, Loc.Line, Loc.Column,
+getFrontendOpts().CodeCompleteOpts, llvm::outs()));
+return;
   } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
   Loc.Line, Loc.Column)) {
 setCodeCompletionConsumer(nullptr);


Index: clang/lib/Frontend/CompilerInstance.cpp
===
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -710,13 +710,10 @@
 void CompilerInstance::createCodeCompletionConsumer() {
   const ParsedSourceLocation  = getFrontendOpts().CodeCompletionAt;
   if (!CompletionConsumer) {
-setCodeCompletionConsumer(
-  createCodeCompletionConsumer(getPreprocessor(),
-   Loc.FileName, Loc.Line, Loc.Column,
-   getFrontendOpts().CodeCompleteOpts,
-   llvm::outs()));
-if (!CompletionConsumer)
-  return;
+setCodeCompletionConsumer(createCodeCompletionConsumer(
+getPreprocessor(), Loc.FileName, Loc.Line, Loc.Column,
+getFrontendOpts().CodeCompleteOpts, llvm::outs()));
+return;
   } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
   Loc.Line, Loc.Column)) {
 setCodeCompletionConsumer(nullptr);
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

2022-05-27 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor updated this revision to Diff 432526.
JohnTitor added a comment.

[CompilerInstance] Tweak the condition on `createCodeCompletionConsumer`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126524/new/

https://reviews.llvm.org/D126524

Files:
  clang/lib/Frontend/CompilerInstance.cpp


Index: clang/lib/Frontend/CompilerInstance.cpp
===
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -710,15 +710,12 @@
 void CompilerInstance::createCodeCompletionConsumer() {
   const ParsedSourceLocation  = getFrontendOpts().CodeCompletionAt;
   if (!CompletionConsumer) {
-setCodeCompletionConsumer(
-  createCodeCompletionConsumer(getPreprocessor(),
-   Loc.FileName, Loc.Line, Loc.Column,
-   getFrontendOpts().CodeCompleteOpts,
-   llvm::outs()));
-if (!CompletionConsumer)
-  return;
-  } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
-  Loc.Line, Loc.Column)) {
+setCodeCompletionConsumer(createCodeCompletionConsumer(
+getPreprocessor(), Loc.FileName, Loc.Line, Loc.Column,
+getFrontendOpts().CodeCompleteOpts, llvm::outs()));
+return;
+  } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName, Loc.Line,
+  Loc.Column)) {
 setCodeCompletionConsumer(nullptr);
 return;
   }


Index: clang/lib/Frontend/CompilerInstance.cpp
===
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -710,15 +710,12 @@
 void CompilerInstance::createCodeCompletionConsumer() {
   const ParsedSourceLocation  = getFrontendOpts().CodeCompletionAt;
   if (!CompletionConsumer) {
-setCodeCompletionConsumer(
-  createCodeCompletionConsumer(getPreprocessor(),
-   Loc.FileName, Loc.Line, Loc.Column,
-   getFrontendOpts().CodeCompleteOpts,
-   llvm::outs()));
-if (!CompletionConsumer)
-  return;
-  } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
-  Loc.Line, Loc.Column)) {
+setCodeCompletionConsumer(createCodeCompletionConsumer(
+getPreprocessor(), Loc.FileName, Loc.Line, Loc.Column,
+getFrontendOpts().CodeCompleteOpts, llvm::outs()));
+return;
+  } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName, Loc.Line,
+  Loc.Column)) {
 setCodeCompletionConsumer(nullptr);
 return;
   }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

2022-05-27 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
Herald added a project: All.
JohnTitor requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Fixes llvm#53545


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126524

Files:
  clang/lib/Frontend/CompilerInstance.cpp


Index: clang/lib/Frontend/CompilerInstance.cpp
===
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -710,15 +710,13 @@
 void CompilerInstance::createCodeCompletionConsumer() {
   const ParsedSourceLocation  = getFrontendOpts().CodeCompletionAt;
   if (!CompletionConsumer) {
-setCodeCompletionConsumer(
-  createCodeCompletionConsumer(getPreprocessor(),
-   Loc.FileName, Loc.Line, Loc.Column,
-   getFrontendOpts().CodeCompleteOpts,
-   llvm::outs()));
-if (!CompletionConsumer)
-  return;
-  } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
-  Loc.Line, Loc.Column)) {
+setCodeCompletionConsumer(createCodeCompletionConsumer(
+getPreprocessor(), Loc.FileName, Loc.Line, Loc.Column,
+getFrontendOpts().CodeCompleteOpts, llvm::outs()));
+return;
+  } else if (!CompletionConsumer &&
+ EnableCodeCompletion(getPreprocessor(), Loc.FileName, Loc.Line,
+  Loc.Column)) {
 setCodeCompletionConsumer(nullptr);
 return;
   }


Index: clang/lib/Frontend/CompilerInstance.cpp
===
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -710,15 +710,13 @@
 void CompilerInstance::createCodeCompletionConsumer() {
   const ParsedSourceLocation  = getFrontendOpts().CodeCompletionAt;
   if (!CompletionConsumer) {
-setCodeCompletionConsumer(
-  createCodeCompletionConsumer(getPreprocessor(),
-   Loc.FileName, Loc.Line, Loc.Column,
-   getFrontendOpts().CodeCompleteOpts,
-   llvm::outs()));
-if (!CompletionConsumer)
-  return;
-  } else if (EnableCodeCompletion(getPreprocessor(), Loc.FileName,
-  Loc.Line, Loc.Column)) {
+setCodeCompletionConsumer(createCodeCompletionConsumer(
+getPreprocessor(), Loc.FileName, Loc.Line, Loc.Column,
+getFrontendOpts().CodeCompleteOpts, llvm::outs()));
+return;
+  } else if (!CompletionConsumer &&
+ EnableCodeCompletion(getPreprocessor(), Loc.FileName, Loc.Line,
+  Loc.Column)) {
 setCodeCompletionConsumer(nullptr);
 return;
   }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68891: Remove unnecessary triple from test

2021-06-15 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor added a subscriber: rnk.
JohnTitor added a comment.

ping @rnk Seems you added this.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68891/new/

https://reviews.llvm.org/D68891

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68891: Remove unnecessary triple from test

2021-04-22 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor added a comment.

Ping @cfe-commits


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68891/new/

https://reviews.llvm.org/D68891

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68891: Remove unnecessary triple from test

2019-10-18 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor added a comment.

ping @rsmith


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68891/new/

https://reviews.llvm.org/D68891



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68891: Remove unnecessary triple from test

2019-10-11 Thread Yuki Okushi via Phabricator via cfe-commits 
JohnTitor created this revision.
JohnTitor added a reviewer: rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

PR27098(https://bugs.llvm.org/show_bug.cgi?id=27098) has been fixed so the 
avoidance seems unnecessary.


Repository:
  rC Clang

https://reviews.llvm.org/D68891

Files:
  clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp


Index: clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp
===
--- clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp
+++ clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp
@@ -1,7 +1,6 @@
 // RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
 // RUN: %clang_cc1 -std=c++14 -fsyntax-only -verify %s
-// FIXME: Remove the triple when PR27098 is fixed.
-// RUN: %clang_cc1 -std=c++1z -fsyntax-only -verify %s -triple 
%itanium_abi_triple
+// RUN: %clang_cc1 -std=c++1z -fsyntax-only -verify %s

 namespace std {
   typedef decltype(sizeof(int)) size_t;


Index: clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp
===
--- clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp
+++ clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp
@@ -1,7 +1,6 @@
 // RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
 // RUN: %clang_cc1 -std=c++14 -fsyntax-only -verify %s
-// FIXME: Remove the triple when PR27098 is fixed.
-// RUN: %clang_cc1 -std=c++1z -fsyntax-only -verify %s -triple %itanium_abi_triple
+// RUN: %clang_cc1 -std=c++1z -fsyntax-only -verify %s

 namespace std {
   typedef decltype(sizeof(int)) size_t;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits