[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

[pmor via Phabricator via cfe-commits]

pmor13 added a comment.

@aaron.ballman

> block scope variable to have *internal* linkage instead of *no* linkage

  static int x;
  
  void f(void)
  {
  extern int x;  // block scope, internal linkage 
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133088/new/

https://reviews.llvm.org/D133088

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

[pmor via Phabricator via cfe-commits]

pmor13 added a comment.

Looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133088/new/

https://reviews.llvm.org/D133088

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

[pmor via Phabricator via cfe-commits]

pmor13 added a comment.

Note that this code:

  int x;
  
  void f(void)
  {
  extern int x = 1;
  }

needs to produce:

  error" declaration of block scope identifier with external linkage shall have 
no initializer

So, `err_block_extern_cant_init` needs to be updated too (I think).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133088/new/

https://reviews.llvm.org/D133088

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits