[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

2021-04-27 Thread Adrian McCarthy via Phabricator via cfe-commits 
amccarth added a comment.

A drive-by look.




Comment at: clang/include/clang/Tooling/Transformer/Parsing.h:24
 #include 
-#include 
 

`` appears unnecessary as well.

And while this doesn't require `` it does require 
`llvm/ADT/StringRef.h`.



Comment at: llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h:72
   template 
   TypeIndex insertRecordAs(GloballyHashedType Hash, size_t RecordSize,
CreateFunc Create) {

`size_t` may have been coming indirectly from ``.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101378/new/

https://reviews.llvm.org/D101378

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

2021-04-27 Thread Nico Weber via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG21da04f70173: [llvm, clang] Remove stdlib includes from .h 
files without `std::` (authored by thakis).
Herald added a project: clang.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101378/new/

https://reviews.llvm.org/D101378

Files:
  clang/include/clang/AST/DeclContextInternals.h
  clang/include/clang/Driver/Options.h
  clang/include/clang/Index/CommentToXML.h
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicType.h
  clang/include/clang/Tooling/Refactoring/RefactoringActionRule.h
  clang/include/clang/Tooling/Transformer/Parsing.h
  llvm/include/llvm/CodeGen/MachineInstrBuilder.h
  llvm/include/llvm/CodeGen/TileShapeInfo.h
  llvm/include/llvm/DebugInfo/CodeView/AppendingTypeTableBuilder.h
  llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
  llvm/include/llvm/DebugInfo/CodeView/MergingTypeTableBuilder.h
  llvm/include/llvm/DebugInfo/GSYM/FileEntry.h
  llvm/include/llvm/DebugInfo/GSYM/StringTable.h
  llvm/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
  llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.h
  llvm/include/llvm/Target/CGPassBuilderOption.h
  llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h

Index: llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h
===
--- llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h
+++ llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h
@@ -15,7 +15,6 @@
 #include "llvm/IR/Function.h"
 #include "llvm/IR/PassManager.h"
 #include "llvm/Support/Compiler.h"
-#include 
 
 namespace llvm {
 
Index: llvm/include/llvm/Target/CGPassBuilderOption.h
===
--- llvm/include/llvm/Target/CGPassBuilderOption.h
+++ llvm/include/llvm/Target/CGPassBuilderOption.h
@@ -17,7 +17,6 @@
 #include "llvm/ADT/Optional.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/Target/TargetOptions.h"
-#include 
 
 namespace llvm {
 class TargetMachine;
Index: llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.h
===
--- llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.h
+++ llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.h
@@ -16,7 +16,6 @@
 
 #include "llvm/ExecutionEngine/Orc/Shared/TargetProcessControlTypes.h"
 #include "llvm/Support/Error.h"
-#include 
 
 namespace llvm {
 namespace orc {
Index: llvm/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
===
--- llvm/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
+++ llvm/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
@@ -21,7 +21,6 @@
 #include "llvm/Support/Error.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/MathExtras.h"
-#include 
 #include 
 
 namespace llvm {
Index: llvm/include/llvm/DebugInfo/GSYM/StringTable.h
===
--- llvm/include/llvm/DebugInfo/GSYM/StringTable.h
+++ llvm/include/llvm/DebugInfo/GSYM/StringTable.h
@@ -13,8 +13,6 @@
 #include "llvm/ADT/StringRef.h"
 #include "llvm/DebugInfo/GSYM/Range.h"
 #include 
-#include 
-
 
 namespace llvm {
 namespace gsym {
Index: llvm/include/llvm/DebugInfo/GSYM/FileEntry.h
===
--- llvm/include/llvm/DebugInfo/GSYM/FileEntry.h
+++ llvm/include/llvm/DebugInfo/GSYM/FileEntry.h
@@ -13,7 +13,6 @@
 #include "llvm/ADT/Hashing.h"
 #include 
 #include 
-#include 
 
 namespace llvm {
 namespace gsym {
Index: llvm/include/llvm/DebugInfo/CodeView/MergingTypeTableBuilder.h
===
--- llvm/include/llvm/DebugInfo/CodeView/MergingTypeTableBuilder.h
+++ llvm/include/llvm/DebugInfo/CodeView/MergingTypeTableBuilder.h
@@ -19,7 +19,6 @@
 #include "llvm/DebugInfo/CodeView/TypeIndex.h"
 #include "llvm/Support/Allocator.h"
 #include 
-#include 
 
 namespace llvm {
 namespace codeview {
Index: llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
===
--- llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
+++ llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
@@ -20,7 +20,6 @@
 #include "llvm/Support/Allocator.h"
 #include 
 #include 
-#include 
 
 namespace llvm {
 namespace codeview {
Index: llvm/include/llvm/DebugInfo/CodeView/AppendingTypeTableBuilder.h
===
--- llvm/include/llvm/DebugInfo/CodeView/AppendingTypeTableBuilder.h
+++ llvm/include/llvm/DebugInfo/CodeView/AppendingTypeTableBuilder.h
@@ -17,7 +17,6 @@
 #include "llvm/DebugInfo/CodeView/TypeIndex.h"
 #include

[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

2021-04-27 Thread Arthur Eubanks via Phabricator via cfe-commits 
aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

lgtm


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101378/new/

https://reviews.llvm.org/D101378

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

2021-04-27 Thread Nico Weber via Phabricator via cfe-commits 
thakis created this revision.
thakis added a reviewer: hans.
Herald added a subscriber: arphaman.
thakis requested review of this revision.
Herald added a project: LLVM.

Found files not containing `std::` with:

  
INCL="algorithm|array|list|map|memory|queue|set|string|utility|vector|unordered_map|unordered_set"
  git ls-files llvm/include/llvm | grep '\.h$' | xargs grep -L std:: | \
  xargs grep -El "#include <($INCL)>$" > to_process.txt
  git ls-files clang/include/clang | grep '\.h$' | xargs grep -L std:: | \
  xargs grep -El "#include <($INCL)>$" >> to_process.txt

Then removed these headers from those files with

  INCL_ESCAPED="$(echo $INCL|sed 's/|/\\|/g')"
  cat to_process.txt | xargs sed -i "/^#include <\($INCL_ESCAPED\)>$/d"
  cat to_process.txt | xargs sed -i '/^$/N;/^\n$/D'

No behavior change.


https://reviews.llvm.org/D101378

Files:
  clang/include/clang/AST/DeclContextInternals.h
  clang/include/clang/Driver/Options.h
  clang/include/clang/Index/CommentToXML.h
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicType.h
  clang/include/clang/Tooling/Refactoring/RefactoringActionRule.h
  clang/include/clang/Tooling/Transformer/Parsing.h
  llvm/include/llvm/CodeGen/MachineInstrBuilder.h
  llvm/include/llvm/CodeGen/TileShapeInfo.h
  llvm/include/llvm/DebugInfo/CodeView/AppendingTypeTableBuilder.h
  llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
  llvm/include/llvm/DebugInfo/CodeView/MergingTypeTableBuilder.h
  llvm/include/llvm/DebugInfo/GSYM/FileEntry.h
  llvm/include/llvm/DebugInfo/GSYM/StringTable.h
  llvm/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
  llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.h
  llvm/include/llvm/Target/CGPassBuilderOption.h
  llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h

Index: llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h
===
--- llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h
+++ llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h
@@ -15,7 +15,6 @@
 #include "llvm/IR/Function.h"
 #include "llvm/IR/PassManager.h"
 #include "llvm/Support/Compiler.h"
-#include 
 
 namespace llvm {
 
Index: llvm/include/llvm/Target/CGPassBuilderOption.h
===
--- llvm/include/llvm/Target/CGPassBuilderOption.h
+++ llvm/include/llvm/Target/CGPassBuilderOption.h
@@ -17,7 +17,6 @@
 #include "llvm/ADT/Optional.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/Target/TargetOptions.h"
-#include 
 
 namespace llvm {
 class TargetMachine;
Index: llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.h
===
--- llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.h
+++ llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.h
@@ -16,7 +16,6 @@
 
 #include "llvm/ExecutionEngine/Orc/Shared/TargetProcessControlTypes.h"
 #include "llvm/Support/Error.h"
-#include 
 
 namespace llvm {
 namespace orc {
Index: llvm/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
===
--- llvm/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
+++ llvm/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
@@ -21,7 +21,6 @@
 #include "llvm/Support/Error.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/MathExtras.h"
-#include 
 #include 
 
 namespace llvm {
Index: llvm/include/llvm/DebugInfo/GSYM/StringTable.h
===
--- llvm/include/llvm/DebugInfo/GSYM/StringTable.h
+++ llvm/include/llvm/DebugInfo/GSYM/StringTable.h
@@ -13,8 +13,6 @@
 #include "llvm/ADT/StringRef.h"
 #include "llvm/DebugInfo/GSYM/Range.h"
 #include 
-#include 
-
 
 namespace llvm {
 namespace gsym {
Index: llvm/include/llvm/DebugInfo/GSYM/FileEntry.h
===
--- llvm/include/llvm/DebugInfo/GSYM/FileEntry.h
+++ llvm/include/llvm/DebugInfo/GSYM/FileEntry.h
@@ -13,7 +13,6 @@
 #include "llvm/ADT/Hashing.h"
 #include 
 #include 
-#include 
 
 namespace llvm {
 namespace gsym {
Index: llvm/include/llvm/DebugInfo/CodeView/MergingTypeTableBuilder.h
===
--- llvm/include/llvm/DebugInfo/CodeView/MergingTypeTableBuilder.h
+++ llvm/include/llvm/DebugInfo/CodeView/MergingTypeTableBuilder.h
@@ -19,7 +19,6 @@
 #include "llvm/DebugInfo/CodeView/TypeIndex.h"
 #include "llvm/Support/Allocator.h"
 #include 
-#include 
 
 namespace llvm {
 namespace codeview {
Index: llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
===
--- llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
+++ llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
@@ -20,7 +20,6 @@
 #include "llvm/Support/Allocator.h"
 #include