[PATCH] D106813: [clang-repl] Build and install clang-repl by default

[Sylvestre Ledru via Phabricator via cfe-commits]

sylvestre.ledru added a comment.

Maybe add this to the release notes of clang 13 or 14?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106813/new/

https://reviews.llvm.org/D106813

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

[Vassil Vassilev via Phabricator via cfe-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGda58ca51f0cf: [clang-repl] Build and install clang-repl by 
default. (authored by v.g.vassilev).
Herald added a project: clang.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106813/new/

https://reviews.llvm.org/D106813

Files:
  clang/tools/clang-repl/CMakeLists.txt


Index: clang/tools/clang-repl/CMakeLists.txt
===
--- clang/tools/clang-repl/CMakeLists.txt
+++ clang/tools/clang-repl/CMakeLists.txt
@@ -7,7 +7,6 @@
   )
 
 add_clang_executable(clang-repl
-  EXCLUDE_FROM_ALL
   ClangRepl.cpp
   )
 


Index: clang/tools/clang-repl/CMakeLists.txt
===
--- clang/tools/clang-repl/CMakeLists.txt
+++ clang/tools/clang-repl/CMakeLists.txt
@@ -7,7 +7,6 @@
   )
 
 add_clang_executable(clang-repl
-  EXCLUDE_FROM_ALL
   ClangRepl.cpp
   )
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

[Raphael Isemann via Phabricator via cfe-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

I think my concerns from D96033  are all 
addressed by now, so this LGTM. Thanks!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106813/new/

https://reviews.llvm.org/D106813

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

[Vassil Vassilev via Phabricator via cfe-commits]

v.g.vassilev created this revision.
v.g.vassilev added reviewers: teemperor, rsmith, lhames, hfinkel, sgraenitz.
Herald added a subscriber: mgorny.
v.g.vassilev requested review of this revision.

We have the basic infrastructure in place. We can recover from simple errors 
(recovering from errors in template instantiations is not yet supported). It 
looks like we are in a reasonably functional state for llvm13.


Repository:
  rC Clang

https://reviews.llvm.org/D106813

Files:
  clang/tools/clang-repl/CMakeLists.txt


Index: clang/tools/clang-repl/CMakeLists.txt
===
--- clang/tools/clang-repl/CMakeLists.txt
+++ clang/tools/clang-repl/CMakeLists.txt
@@ -7,7 +7,6 @@
   )
 
 add_clang_executable(clang-repl
-  EXCLUDE_FROM_ALL
   ClangRepl.cpp
   )
 


Index: clang/tools/clang-repl/CMakeLists.txt
===
--- clang/tools/clang-repl/CMakeLists.txt
+++ clang/tools/clang-repl/CMakeLists.txt
@@ -7,7 +7,6 @@
   )
 
 add_clang_executable(clang-repl
-  EXCLUDE_FROM_ALL
   ClangRepl.cpp
   )
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits