[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

[Henry Linjamäki via Phabricator via cfe-commits]

linjamaki abandoned this revision.
linjamaki added a comment.

D109818  includes the change in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108367/new/

https://reviews.llvm.org/D108367

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

[Pekka Jääskeläinen via Phabricator via cfe-commits]

pekka.jaaskelainen added a comment.

In D108367#2966746 , 
@pekka.jaaskelainen wrote:

> @Anastasia  I used to have svn commit access, but haven't committed anything 
> for a long while in LLVM, so don't know if I can get them back to github by 
> just asking. So, can you please commit these HIPSPV patches for us?

@Anastasia - or do you think there's someone else more suitable for pushing 
these patches in for us? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108367/new/

https://reviews.llvm.org/D108367

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

[Pekka Jääskeläinen via Phabricator via cfe-commits]

pekka.jaaskelainen added a comment.

@Anastasia  I used to have svn commit access, but haven't committed anything 
for a long while in LLVM, so don't know if I can get them back to github by 
just asking. So, can you please commit these HIPSPV patches for us?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108367/new/

https://reviews.llvm.org/D108367

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

[Henry Linjamäki via Phabricator via cfe-commits]

linjamaki added a comment.

Thanks for the review.

In an upcoming HIPSPV patch there will be a test that depends on this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108367/new/

https://reviews.llvm.org/D108367

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks.

Do you think we can test this somehow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108367/new/

https://reviews.llvm.org/D108367

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

[Henry Linjamäki via Phabricator via cfe-commits]

linjamaki created this revision.
linjamaki requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Make computeSPIRKernelABIInfo() to use SPIRABIInfo instead of
DefaultABIInfo.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108367

Files:
  clang/lib/CodeGen/TargetInfo.cpp


Index: clang/lib/CodeGen/TargetInfo.cpp
===
--- clang/lib/CodeGen/TargetInfo.cpp
+++ clang/lib/CodeGen/TargetInfo.cpp
@@ -10214,7 +10214,7 @@
 namespace clang {
 namespace CodeGen {
 void computeSPIRKernelABIInfo(CodeGenModule &CGM, CGFunctionInfo &FI) {
-  DefaultABIInfo SPIRABI(CGM.getTypes());
+  SPIRABIInfo SPIRABI(CGM.getTypes());
   SPIRABI.computeInfo(FI);
 }
 }


Index: clang/lib/CodeGen/TargetInfo.cpp
===
--- clang/lib/CodeGen/TargetInfo.cpp
+++ clang/lib/CodeGen/TargetInfo.cpp
@@ -10214,7 +10214,7 @@
 namespace clang {
 namespace CodeGen {
 void computeSPIRKernelABIInfo(CodeGenModule &CGM, CGFunctionInfo &FI) {
-  DefaultABIInfo SPIRABI(CGM.getTypes());
+  SPIRABIInfo SPIRABI(CGM.getTypes());
   SPIRABI.computeInfo(FI);
 }
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits