[PATCH] D120454: clang/www: Add links to tracking issues for C++20 features

[Arthur O'Dwyer via Phabricator via cfe-commits]

Quuxplusone added inline comments.



Comment at: clang/www/cxx_status.html:106
+automatically fetch status information from the issue in the tracker. For 
Example:
+a class='autoupdate' 
href='https://github.com/llvm/llvm-project/issues/54006'No/a
+

HTML nit: these attributes should use `"` instead of `'` (ooh, and ditto in the 
actual HTML on lines 961 etc.)



Comment at: clang/www/cxx_status.html:1308-1313

 https://wg21.link/p2082r1;>P2082R1
+  
+No
+  
   

Have you eyeballed the new rendering of this table here? (I haven't.) The 
indentation on these HTML lines is wonky now; looks like lines 1308, 1309, and 
1313 are overindented by 2 spaces?



Comment at: clang/www/cxx_status.html:1652
+ * in the link text field. e.g.
+ * No
+ *

`s/'/"/g`



Comment at: clang/www/cxx_status.html:1660-1664
+Array.from(document.getElementsByClassName("autoupdate")).forEach(element => {
+  if (element.innerHTML != "No")
+return;
+  updateIssueCell(element);
+})

Does this need to be in a `document.onload` or 

[PATCH] D120454: clang/www: Add links to tracking issues for C++20 features

[Tom Stellard via Phabricator via cfe-commits]

tstellar created this revision.
tstellar requested review of this revision.
Herald added a project: clang.

Also add some javascript to automatically change that status to
"In Progress" when the issue is assigned to someone, and "Clang ToT"
when the issue is closed.

Note that the feature entries will still need to be manually updated
with the first version of clang that they appear in once they have
been completed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120454

Files:
  clang/www/cxx_status.html

Index: clang/www/cxx_status.html
===
--- clang/www/cxx_status.html
+++ clang/www/cxx_status.html
@@ -58,7 +58,7 @@
 
  C++20
  -std=c++20
- Partial
+ Partial
 
 
  C++2b (tentatively C++23)
@@ -80,6 +80,36 @@
 the "c++" label, as well as mode-specific labels such as "c++11", "c++14",
 and so on, to track known bugs with Clang's language conformance.
 
+There should also be an issue created in the
+https://github.com/llvm/llvm-project/issues/;>LLVM bug tracker for
+each new C++ standard feature.  Please use this template when creating a new bug:
+
+
+Title:
+Clang C++20 Feature: paper id - paper title
+
+Body:
+optional description
+---
+id: paper id
+paper: link to paper
+
+
+
+Also be sure to add the issue to the appropriate milestone e.g. "Clang C++20"
+and add the relevant tags.
+
+
+Once you've created an issue for a new feature, add the link to the issue in the
+tables below.  Set the 'class' attribute on the 'a' tag equal to 'autoupdate' to
+automatically fetch status information from the issue in the tracker. For Example:
+a class='autoupdate' href='https://github.com/llvm/llvm-project/issues/54006'No/a
+
+
+Once the feature has been implemented, close the corresponding issue and update
+the table with first version of clang that will contain this feature.
+
+
 C++98 implementation status
 
 Clang implements all of the ISO C++ 1998 standard
@@ -927,7 +957,9 @@
   

 https://wg21.link/p0848r3;>P0848R3
-No
+
+  No
+
   
   
 https://wg21.link/p1616r1;>P1616R1
@@ -938,16 +970,27 @@
   

 https://wg21.link/p1972r0;>P1972R0
-No
+
+  No
+
   
   
 https://wg21.link/p1980r0;>P1980R0
+
+  No
+
   

 https://wg21.link/p2103r0;>P2103R0
+
+  No
+
   

 https://wg21.link/p2493r0;>P2493R0
+
+  No
+
   
   
 https://wg21.link/p2092r0;>P2092R0
@@ -959,7 +1002,9 @@
   
   
 https://wg21.link/p2113r0;>P2113R0
-No
+
+  No
+
   
 
 
@@ -1040,7 +1085,9 @@
 
   typename optional in more contexts
   https://wg21.link/p0634r3;>P0634R3
-  No
+  
+No
+  
 
 
   Pack expansion in lambda init-capture
@@ -1156,10 +1203,15 @@
 
   Parenthesized initialization of aggregates
   https://wg21.link/p0960r3;>P0960R3
-  No
+  
+No
+  
 

 https://wg21.link/p1975r0;>P1975R0
+
+  No
+
   
 
   Modules
@@ -1172,10 +1224,15 @@
   
   
 https://wg21.link/p1811r0;>P1811R0
-No
+
+  No
+
   
   
 https://wg21.link/p1703r1;>P1703R1
+
+  No
+
   

 https://wg21.link/p1874r1;>P1874R1
@@ -1183,13 +1240,21 @@
   

 https://wg21.link/p1979r0;>P1979R0
-No
+
+  No
+
   

 https://wg21.link/p1779r3;>P1779R3
+
+  No
+
   
   
 https://wg21.link/p1857r3;>P1857R3
+
+  No
+
   
   
 https://wg21.link/p2115r0;>P2115R0
@@ -1197,7 +1262,9 @@
   
   
 https://wg21.link/p1815r2;>P1815R2
-No
+
+  No
+
   
 
   Coroutines
@@ -1234,15 +1301,22 @@
 
   Class template argument deduction for aggregates
   https://wg21.link/p1816r0;>P1816R0
-  No
+  
+No
+  
 

 https://wg21.link/p2082r1;>P2082R1
+  
+No
+  
   
 
   Class template argument deduction for alias templates
   https://wg21.link/p1814r0;>P1814R0
-  No
+  
+No
+  
 
 
   Permit conversions to arrays of unknown bound
@@ -1542,5 +1616,52 @@
 
 
 
+
+async function getIssue(issueNumber) {
+  var response = await fetch('https://api.github.com/repos/llvm/llvm-project/issues/' + issueNumber);
+  return response.json();
+}
+
+async function updateIssueCell(element) {
+  var status = "No";
+  var className = "none";
+  var issueNumber =