[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D123074#3430789 , 
@AaronSiddharthaMondal wrote:

> Ahh I didn't know that. After fixing my settings it is now linked correctly. 
> No need to revert.

I'm glad that worked for you!

> Thanks a lot for the help!

Any time, thank you so much for the fix!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Siddhartha Mondal via Phabricator via cfe-commits]

AaronSiddharthaMondal added a comment.

Ahh I didn't know that. After fixing my settings it is now linked correctly. No 
need to revert.

Thanks a lot for the help!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D123074#3430705 , 
@AaronSiddharthaMondal wrote:

> @aaron.ballman There may have been something wrong with the commit. On GitHub 
> it does not link to my user account. Would it be possible to change that?
> The github name is aaronmondal.

Sorry for the trouble -- the option to land with attribution takes `name 
` form, not a GitHub username.

I can reland with different attribution, but that churns the git history and 
makes git blame harder for code archeology, so it's nice to avoid if possible. 
I think adding your secondary email address to your GitHub account should also 
address the issue 
(https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-user-account/managing-email-preferences/adding-an-email-address-to-your-github-account).
 But if it doesn't and you'd still like the attribution changed, I can revert 
and recommit (probably tomorrow at this point, I'm just about done for the day 
today).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Siddhartha Mondal via Phabricator via cfe-commits]

AaronSiddharthaMondal added a comment.

@aaron.ballman There may have been something wrong with the commit. On GitHub 
it does not link to my user account. Would it be possible to change that?
The github name is aaronmondal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman closed this revision.
aaron.ballman added a comment.

In D123074#3430623 , 
@AaronSiddharthaMondal wrote:

> In D123074#3430355 , @aaron.ballman 
> wrote:
>
>> In D123074#3430351 , 
>> @aaron.ballman wrote:
>>
>>> LGTM, thank you for the fix!
>>
>> If you need me to commit on your behalf, what name and email address would 
>> you like me to use for patch attribution?
>
> Thanks, yes that would be nice :)
>
> Name is Aaron Siddhartha Mondal. Email .
> On GitHub its aaronmondal. I created the issue with another account.

Thank you for the fix! I've commit on your behalf in 
04b42c99f62216263662d1033fa9b3e12c65563e 
.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Siddhartha Mondal via Phabricator via cfe-commits]

AaronSiddharthaMondal added a comment.

In D123074#3430355 , @aaron.ballman 
wrote:

> In D123074#3430351 , @aaron.ballman 
> wrote:
>
>> LGTM, thank you for the fix!
>
> If you need me to commit on your behalf, what name and email address would 
> you like me to use for patch attribution?

Name is Aaron Siddhartha Mondal. Email .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D123074#3430351 , @aaron.ballman 
wrote:

> LGTM, thank you for the fix!

If you need me to commit on your behalf, what name and email address would you 
like me to use for patch attribution?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thank you for the fix!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123074/new/

https://reviews.llvm.org/D123074

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

[Aaron Siddhartha Mondal via Phabricator via cfe-commits]

AaronSiddharthaMondal created this revision.
AaronSiddharthaMondal added a reviewer: aaron.ballman.
AaronSiddharthaMondal added a project: clang-tools-extra.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
AaronSiddharthaMondal requested review of this revision.
Herald added a subscriber: cfe-commits.

The new `-config-file` option introduced by 9e1f4f1 
 was 
accidentally referenced
as `args.config_path` on the python side. This patch renames `args.config_path`
to `args.config_file`.

To avoid confusion with python `file` objects, the input argument for
`get_tidy_invocation` has been renamed from `config_path` to `config_file_path`.

See GitHub issue #54728  for 
a discussion.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123074

Files:
  clang-tools-extra/clang-tidy/tool/run-clang-tidy.py


Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
===
--- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -90,7 +90,7 @@
 
 def get_tidy_invocation(f, clang_tidy_binary, checks, tmpdir, build_path,
 header_filter, allow_enabling_alpha_checkers,
-extra_arg, extra_arg_before, quiet, config_path,
+extra_arg, extra_arg_before, quiet, config_file_path,
 config, line_filter, use_color):
   """Gets a command line for clang-tidy."""
   start = [clang_tidy_binary]
@@ -121,8 +121,8 @@
   start.append('-p=' + build_path)
   if quiet:
   start.append('-quiet')
-  if config_path:
-  start.append('--config-file=' + config_path)
+  if config_file_path:
+  start.append('--config-file=' + config_file_path)
   elif config:
   start.append('-config=' + config)
   start.append(f)
@@ -194,7 +194,7 @@
  tmpdir, build_path, args.header_filter,
  args.allow_enabling_alpha_checkers,
  args.extra_arg, args.extra_arg_before,
- args.quiet, args.config_path, args.config,
+ args.quiet, args.config_file, args.config,
  args.line_filter, args.use_color)
 
 proc = subprocess.Popen(invocation, stdout=subprocess.PIPE, 
stderr=subprocess.PIPE)
@@ -304,7 +304,7 @@
  None, build_path, args.header_filter,
  args.allow_enabling_alpha_checkers,
  args.extra_arg, args.extra_arg_before,
- args.quiet, args.config_path, args.config,
+ args.quiet, args.config_file, args.config,
  args.line_filter, args.use_color)
 invocation.append('-list-checks')
 invocation.append('-')


Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
===
--- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -90,7 +90,7 @@
 
 def get_tidy_invocation(f, clang_tidy_binary, checks, tmpdir, build_path,
 header_filter, allow_enabling_alpha_checkers,
-extra_arg, extra_arg_before, quiet, config_path,
+extra_arg, extra_arg_before, quiet, config_file_path,
 config, line_filter, use_color):
   """Gets a command line for clang-tidy."""
   start = [clang_tidy_binary]
@@ -121,8 +121,8 @@
   start.append('-p=' + build_path)
   if quiet:
   start.append('-quiet')
-  if config_path:
-  start.append('--config-file=' + config_path)
+  if config_file_path:
+  start.append('--config-file=' + config_file_path)
   elif config:
   start.append('-config=' + config)
   start.append(f)
@@ -194,7 +194,7 @@
  tmpdir, build_path, args.header_filter,
  args.allow_enabling_alpha_checkers,
  args.extra_arg, args.extra_arg_before,
- args.quiet, args.config_path, args.config,
+ args.quiet, args.config_file, args.config,
  args.line_filter, args.use_color)
 
 proc = subprocess.Popen(invocation, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
@@ -304,7 +304,7 @@
  None, build_path, args.header_filter,
  args.allow_enabling_alpha_checkers,
  args.extra_arg, args.extra_arg_before,
-