[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

[David Spickett via Phabricator via cfe-commits]

DavidSpickett abandoned this revision.
DavidSpickett added a comment.

People are leaning toward fixes on the buildkite side.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123601/new/

https://reviews.llvm.org/D123601

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

[Tom Stellard via Phabricator via cfe-commits]

tstellar added a comment.

Ok, so maybe my concerns about testing overhead are not that legitimate.  
That's just something I've heard mentioned in the past.  However,  I still 
think this should be fixed in buildkite.  It's seems much more sustainable to 
just bump the timeout in buildkite rather than having to go through the code 
and split tests every time they get too long.  It sounds like the maintainers 
have been contacted about this, but haven't responded?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123601/new/

https://reviews.llvm.org/D123601

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

[Florian Hahn via Phabricator via cfe-commits]

fhahn added a comment.

(splitting up huge monolithic tests likely also speeds up overall testing time 
on multi-core systems)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123601/new/

https://reviews.llvm.org/D123601

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

[Florian Hahn via Phabricator via cfe-commits]

fhahn added a comment.

In D123601#3445601 , @tstellar wrote:

> Can't we add a timeout exception for this test in buildkite?  Splitting the 
> file in two actually increases the runtime, due to the overhead of setting up 
> each test.

I don't know, this is a recurring issue which impacts multiple tests and we've 
not really heard from people maintaining build kite integration AFAIK.

Given that the split up files still contain many functions, I'd expect the 
setup cost to have a relatively small effect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123601/new/

https://reviews.llvm.org/D123601

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

[Tom Stellard via Phabricator via cfe-commits]

tstellar added a comment.

Can't we add a timeout exception for this test in buildkite?  Splitting the 
file in two actually increases the runtime, due to the overhead of setting up 
each test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123601/new/

https://reviews.llvm.org/D123601

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

[David Spickett via Phabricator via cfe-commits]

DavidSpickett added a comment.

For https://github.com/llvm/llvm-project/issues/54821.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123601/new/

https://reviews.llvm.org/D123601

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

[David Spickett via Phabricator via cfe-commits]

DavidSpickett created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This should reduce the per test execution time and prevent
timeouts in pre-commit buildkite builds.

(for #54821)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123601

Files:
  clang/test/CodeGen/arm_neon_intrinsics.c
  clang/test/CodeGen/arm_neon_intrinsics_2.c

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits