[PATCH] D126725: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC

[Sam McCall via Phabricator via cfe-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa43fef05d4fa: [pseudo] rename pseudo-gen - 
clang-pseudo-gen. NFC (authored by sammccall).

Changed prior to commit:
  https://reviews.llvm.org/D126725?vs=433204=434092#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126725/new/

https://reviews.llvm.org/D126725

Files:
  clang-tools-extra/pseudo/gen/CMakeLists.txt
  clang-tools-extra/pseudo/include/CMakeLists.txt
  llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn


Index: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
===
--- llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
+++ llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
@@ -1,4 +1,4 @@
-executable("pseudo-gen") {
+executable("clang-pseudo-gen") {
   configs += [ "//llvm/utils/gn/build:clang_code" ]
   deps = [
 "//clang-tools-extra/pseudo/lib/grammar",
Index: clang-tools-extra/pseudo/include/CMakeLists.txt
===
--- clang-tools-extra/pseudo/include/CMakeLists.txt
+++ clang-tools-extra/pseudo/include/CMakeLists.txt
@@ -2,11 +2,11 @@
 set(cxx_bnf ${CMAKE_CURRENT_SOURCE_DIR}/../lib/cxx.bnf)
 
 if(LLVM_USE_HOST_TOOLS)
-  build_native_tool(pseudo-gen pseudo_gen)
+  build_native_tool(clang-pseudo-gen pseudo_gen)
   set(pseudo_gen_target "${pseudo_gen}")
 else()
-  set(pseudo_gen $)
-  set(pseudo_gen_target pseudo-gen)
+  set(pseudo_gen $)
+  set(pseudo_gen_target clang-pseudo-gen)
 endif()
 
 # Generate inc files.
Index: clang-tools-extra/pseudo/gen/CMakeLists.txt
===
--- clang-tools-extra/pseudo/gen/CMakeLists.txt
+++ clang-tools-extra/pseudo/gen/CMakeLists.txt
@@ -1,11 +1,11 @@
 set(LLVM_LINK_COMPONENTS Support)
 list(REMOVE_ITEM LLVM_COMMON_DEPENDS clang-tablegen-targets)
 
-add_clang_executable(pseudo-gen
+add_clang_executable(clang-pseudo-gen
   Main.cpp
   )
 
-target_link_libraries(pseudo-gen
+target_link_libraries(clang-pseudo-gen
   PRIVATE
   clangPseudoGrammar
   )


Index: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
===
--- llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
+++ llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
@@ -1,4 +1,4 @@
-executable("pseudo-gen") {
+executable("clang-pseudo-gen") {
   configs += [ "//llvm/utils/gn/build:clang_code" ]
   deps = [
 "//clang-tools-extra/pseudo/lib/grammar",
Index: clang-tools-extra/pseudo/include/CMakeLists.txt
===
--- clang-tools-extra/pseudo/include/CMakeLists.txt
+++ clang-tools-extra/pseudo/include/CMakeLists.txt
@@ -2,11 +2,11 @@
 set(cxx_bnf ${CMAKE_CURRENT_SOURCE_DIR}/../lib/cxx.bnf)
 
 if(LLVM_USE_HOST_TOOLS)
-  build_native_tool(pseudo-gen pseudo_gen)
+  build_native_tool(clang-pseudo-gen pseudo_gen)
   set(pseudo_gen_target "${pseudo_gen}")
 else()
-  set(pseudo_gen $)
-  set(pseudo_gen_target pseudo-gen)
+  set(pseudo_gen $)
+  set(pseudo_gen_target clang-pseudo-gen)
 endif()
 
 # Generate inc files.
Index: clang-tools-extra/pseudo/gen/CMakeLists.txt
===
--- clang-tools-extra/pseudo/gen/CMakeLists.txt
+++ clang-tools-extra/pseudo/gen/CMakeLists.txt
@@ -1,11 +1,11 @@
 set(LLVM_LINK_COMPONENTS Support)
 list(REMOVE_ITEM LLVM_COMMON_DEPENDS clang-tablegen-targets)
 
-add_clang_executable(pseudo-gen
+add_clang_executable(clang-pseudo-gen
   Main.cpp
   )
 
-target_link_libraries(pseudo-gen
+target_link_libraries(clang-pseudo-gen
   PRIVATE
   clangPseudoGrammar
   )
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126725: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

Renaming this seems like a great change to me fwiw :)




Comment at: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn:1
-executable("pseudo-gen") {
+executable("clang-pseudo-gen") {
   configs += [ "//llvm/utils/gn/build:clang_code" ]

hokein wrote:
> I was skeptical there should be an additional change in the gn build 
> (building the inc file), but it looks like the gn file is incomplete, the 
> `cxx` doesn't compile in gn build, there is a 
> [fixme](https://github.com/llvm/llvm-project/blob/main/llvm/utils/gn/secondary/clang-tools-extra/pseudo/cxx/BUILD.gn#L2),
>  I think it is ok.
(fwiw we usually only add things to the gn build covered by tests. nothing in 
the test suite needs this at the moment, so i haven't ported it. i have a local 
branch ready to go in case it's needed, it looks like D126966.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126725/new/

https://reviews.llvm.org/D126725

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126725: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.



Comment at: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn:1
-executable("pseudo-gen") {
+executable("clang-pseudo-gen") {
   configs += [ "//llvm/utils/gn/build:clang_code" ]

I was skeptical there should be an additional change in the gn build (building 
the inc file), but it looks like the gn file is incomplete, the `cxx` doesn't 
compile in gn build, there is a 
[fixme](https://github.com/llvm/llvm-project/blob/main/llvm/utils/gn/secondary/clang-tools-extra/pseudo/cxx/BUILD.gn#L2),
 I think it is ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126725/new/

https://reviews.llvm.org/D126725

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126725: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added a subscriber: mgorny.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, llvm-commits, alextsao1999.
Herald added projects: LLVM, clang-tools-extra.

This name is not namespaced. Requested in D126717 



Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126725

Files:
  clang-tools-extra/pseudo/gen/CMakeLists.txt
  clang-tools-extra/pseudo/include/CMakeLists.txt
  llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn


Index: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
===
--- llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
+++ llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
@@ -1,4 +1,4 @@
-executable("pseudo-gen") {
+executable("clang-pseudo-gen") {
   configs += [ "//llvm/utils/gn/build:clang_code" ]
   deps = [
 "//clang-tools-extra/pseudo/lib/grammar",
Index: clang-tools-extra/pseudo/include/CMakeLists.txt
===
--- clang-tools-extra/pseudo/include/CMakeLists.txt
+++ clang-tools-extra/pseudo/include/CMakeLists.txt
@@ -2,11 +2,11 @@
 set(cxx_bnf ${CMAKE_CURRENT_SOURCE_DIR}/../lib/cxx.bnf)
 
 if(LLVM_USE_HOST_TOOLS)
-  build_native_tool(pseudo-gen pseudo_gen)
+  build_native_tool(clang-pseudo-gen pseudo_gen)
   set(pseudo_gen_target "${pseudo_gen}")
 else()
-  set(pseudo_gen $)
-  set(pseudo_gen_target pseudo-gen)
+  set(pseudo_gen $)
+  set(pseudo_gen_target clang-pseudo-gen)
 endif()
 
 # Generate inc files.
Index: clang-tools-extra/pseudo/gen/CMakeLists.txt
===
--- clang-tools-extra/pseudo/gen/CMakeLists.txt
+++ clang-tools-extra/pseudo/gen/CMakeLists.txt
@@ -1,10 +1,10 @@
 set(LLVM_LINK_COMPONENTS Support)
 
-add_clang_executable(pseudo-gen
+add_clang_executable(clang-pseudo-gen
   Main.cpp
   )
 
-target_link_libraries(pseudo-gen
+target_link_libraries(clang-pseudo-gen
   PRIVATE
   clangPseudoGrammar
   )


Index: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
===
--- llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
+++ llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn
@@ -1,4 +1,4 @@
-executable("pseudo-gen") {
+executable("clang-pseudo-gen") {
   configs += [ "//llvm/utils/gn/build:clang_code" ]
   deps = [
 "//clang-tools-extra/pseudo/lib/grammar",
Index: clang-tools-extra/pseudo/include/CMakeLists.txt
===
--- clang-tools-extra/pseudo/include/CMakeLists.txt
+++ clang-tools-extra/pseudo/include/CMakeLists.txt
@@ -2,11 +2,11 @@
 set(cxx_bnf ${CMAKE_CURRENT_SOURCE_DIR}/../lib/cxx.bnf)
 
 if(LLVM_USE_HOST_TOOLS)
-  build_native_tool(pseudo-gen pseudo_gen)
+  build_native_tool(clang-pseudo-gen pseudo_gen)
   set(pseudo_gen_target "${pseudo_gen}")
 else()
-  set(pseudo_gen $)
-  set(pseudo_gen_target pseudo-gen)
+  set(pseudo_gen $)
+  set(pseudo_gen_target clang-pseudo-gen)
 endif()
 
 # Generate inc files.
Index: clang-tools-extra/pseudo/gen/CMakeLists.txt
===
--- clang-tools-extra/pseudo/gen/CMakeLists.txt
+++ clang-tools-extra/pseudo/gen/CMakeLists.txt
@@ -1,10 +1,10 @@
 set(LLVM_LINK_COMPONENTS Support)
 
-add_clang_executable(pseudo-gen
+add_clang_executable(clang-pseudo-gen
   Main.cpp
   )
 
-target_link_libraries(pseudo-gen
+target_link_libraries(clang-pseudo-gen
   PRIVATE
   clangPseudoGrammar
   )
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits