[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2023-03-20 Thread Artem Belevich via Phabricator via cfe-commits 
tra added a comment.

Would it make sense to also introduce a `ClangTargetBuiltin` for the cases 
where we use TARGET_BUILTIN on LLVM side now?

A lot of the builtins we have in clang  are TARGET_BUILTIN() with constrained 
availability (~5K, if my grep-foo works correctly).

Right now we attempt to keep things in sync manually, but we don't always 
manage to do that correctly. Having one-shot for such a common case would help 
with that a bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Amanieu d'Antras via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd0a4450ecdaf: Rename GCCBuiltin into ClangBuiltin (authored 
by GuillaumeGomez, committed by Amanieu).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

Files:
  clang/lib/CodeGen/CGBuiltin.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/IntrinsicsAArch64.td
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/include/llvm/IR/IntrinsicsBPF.td
  llvm/include/llvm/IR/IntrinsicsHexagon.td
  llvm/include/llvm/IR/IntrinsicsMips.td
  llvm/include/llvm/IR/IntrinsicsNVVM.td
  llvm/include/llvm/IR/IntrinsicsPowerPC.td
  llvm/include/llvm/IR/IntrinsicsSystemZ.td
  llvm/include/llvm/IR/IntrinsicsVE.td
  llvm/include/llvm/IR/IntrinsicsVEVL.gen.td
  llvm/include/llvm/IR/IntrinsicsX86.td
  llvm/include/llvm/IR/IntrinsicsXCore.td
  llvm/lib/IR/Function.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez updated this revision to Diff 439115.
GuillaumeGomez added a comment.

- Rename GCCBuiltin into ClangBuiltin
- Update #define name as well
- Rename `IsGCC` function parameter into `IsClang`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

Files:
  clang/lib/CodeGen/CGBuiltin.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/IntrinsicsAArch64.td
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/include/llvm/IR/IntrinsicsBPF.td
  llvm/include/llvm/IR/IntrinsicsHexagon.td
  llvm/include/llvm/IR/IntrinsicsMips.td
  llvm/include/llvm/IR/IntrinsicsNVVM.td
  llvm/include/llvm/IR/IntrinsicsPowerPC.td
  llvm/include/llvm/IR/IntrinsicsSystemZ.td
  llvm/include/llvm/IR/IntrinsicsVE.td
  llvm/include/llvm/IR/IntrinsicsVEVL.gen.td
  llvm/include/llvm/IR/IntrinsicsX86.td
  llvm/include/llvm/IR/IntrinsicsXCore.td
  llvm/lib/IR/Function.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added a comment.

So from the documentation:

> Prior to obtaining commit access, it is common practice to request that 
> someone with commit access commits on your behalf. When doing so, please 
> provide the name and email address you would like to use in the Author 
> property of the commit.

So as git commit author I use:

"Guillaume Gomez "

Can someone commit on my behalf please?

Thanks in advance!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added a comment.

In D127460#3601193 , @xbolva00 wrote:

> Patch description needs to be added, especially answer the question why we 
> should rename it, why we want it..

I updated the description to explain why it is needed. I'm not sure how big 
it's supposed to be so I didn't enter into the details though.

In D127460#3601205 , @xbolva00 wrote:

> In D127460#3601152 , 
> @GuillaumeGomez wrote:
>
>> This is my first LLVM contribution so I don't think I do? If I do have a 
>> commit access anyway, do you have a link to the documentation where it 
>> explains what I'm supposed to do by any chance?
>
> https://llvm.org/docs/DeveloperPolicy.html#id17

Thanks! Once this is approved, I'll do it then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez updated this revision to Diff 438989.
GuillaumeGomez added a comment.

Rename GCCBuiltin into ClangBuiltin.

This patch is needeed because developers expect "GCCBuiltin" items to be the 
GCC intrinsics equivalent and not the Clang internals.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

Files:
  clang/lib/CodeGen/CGBuiltin.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/IntrinsicsAArch64.td
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/include/llvm/IR/IntrinsicsBPF.td
  llvm/include/llvm/IR/IntrinsicsHexagon.td
  llvm/include/llvm/IR/IntrinsicsMips.td
  llvm/include/llvm/IR/IntrinsicsNVVM.td
  llvm/include/llvm/IR/IntrinsicsPowerPC.td
  llvm/include/llvm/IR/IntrinsicsSystemZ.td
  llvm/include/llvm/IR/IntrinsicsVE.td
  llvm/include/llvm/IR/IntrinsicsVEVL.gen.td
  llvm/include/llvm/IR/IntrinsicsX86.td
  llvm/include/llvm/IR/IntrinsicsXCore.td
  llvm/lib/IR/Function.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Dávid Bolvanský via Phabricator via cfe-commits 
xbolva00 added a comment.

In D127460#3601152 , @GuillaumeGomez 
wrote:

> This is my first LLVM contribution so I don't think I do? If I do have a 
> commit access anyway, do you have a link to the documentation where it 
> explains what I'm supposed to do by any chance?

https://llvm.org/docs/DeveloperPolicy.html#id17


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Dávid Bolvanský via Phabricator via cfe-commits 
xbolva00 requested changes to this revision.
xbolva00 added a comment.
This revision now requires changes to proceed.

Patch description needs to be added, especially answer the question why we 
should rename it, why we want it..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added a comment.

This is my first LLVM contribution so I don't think I do? If I do have a commit 
access anyway, do you have a link to the documentation where it explains what 
I'm supposed to do by any chance?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Simon Pilgrim via Phabricator via cfe-commits 
RKSimon added a comment.

It looks like this is good to go - do you have commit access?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-22 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez marked an inline comment as done.
GuillaumeGomez added a comment.

Is there anything else for me to do in here so it gets merged? (Sorry if I 
missed it but I couldn't find out the exact merge process in the documentation)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-15 Thread Simon Pilgrim via Phabricator via cfe-commits 
RKSimon added a comment.

I don't think this is really blocked on the libc team any more?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-15 Thread Simon Pilgrim via Phabricator via cfe-commits 
RKSimon accepted this revision.
RKSimon added a comment.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez marked an inline comment as done.
GuillaumeGomez added a comment.

Fixed @spatel's comment.




Comment at: llvm/include/llvm/IR/Intrinsics.td:387
 
-/// GCCBuiltin - If this intrinsic exactly corresponds to a GCC builtin, this
+/// ClangBuiltin - If this intrinsic exactly corresponds to a GCC builtin, this
 /// specifies the name of the builtin.  This provides automatic CBE and CFE

spatel wrote:
> Replace "GCC" with "Clang" ?
Good catch, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez updated this revision to Diff 436876.
GuillaumeGomez added a comment.

- Update #define name as well
- Rename `IsGCC` function parameter into `IsClang`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

Files:
  clang/lib/CodeGen/CGBuiltin.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/IntrinsicsAArch64.td
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/include/llvm/IR/IntrinsicsBPF.td
  llvm/include/llvm/IR/IntrinsicsHexagon.td
  llvm/include/llvm/IR/IntrinsicsMips.td
  llvm/include/llvm/IR/IntrinsicsNVVM.td
  llvm/include/llvm/IR/IntrinsicsPowerPC.td
  llvm/include/llvm/IR/IntrinsicsSystemZ.td
  llvm/include/llvm/IR/IntrinsicsVE.td
  llvm/include/llvm/IR/IntrinsicsVEVL.gen.td
  llvm/include/llvm/IR/IntrinsicsX86.td
  llvm/include/llvm/IR/IntrinsicsXCore.td
  llvm/lib/IR/Function.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Sanjay Patel via Phabricator via cfe-commits 
spatel added inline comments.



Comment at: llvm/include/llvm/IR/Intrinsics.td:387
 
-/// GCCBuiltin - If this intrinsic exactly corresponds to a GCC builtin, this
+/// ClangBuiltin - If this intrinsic exactly corresponds to a GCC builtin, this
 /// specifies the name of the builtin.  This provides automatic CBE and CFE

Replace "GCC" with "Clang" ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Eli Friedman via Phabricator via cfe-commits 
efriedma added a comment.

No other comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Simon Pilgrim via Phabricator via cfe-commits 
RKSimon added a comment.

LGTM (with one minor) - @efriedma any more feedback?




Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:82
 
 // Emit code to translate GCC builtins into LLVM intrinsics.
 EmitIntrinsicToBuiltinMap(Ints, true, OS);

"Clang builtins"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added a comment.

Applied @RKSimon's suggestion.




Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:883
 void IntrinsicEmitter::EmitIntrinsicToBuiltinMap(
 const CodeGenIntrinsicTable , bool IsGCC, raw_ostream ) {
+  StringRef CompilerName = (IsGCC ? "Clang" : "MS");

RKSimon wrote:
> IsGCC?
I didn't even notice when updating it... Updating to `IsClang`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez updated this revision to Diff 436778.
GuillaumeGomez added a comment.

Rename `IsGCC` function parameter into `IsClang`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

Files:
  clang/lib/CodeGen/CGBuiltin.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/IntrinsicsAArch64.td
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/include/llvm/IR/IntrinsicsBPF.td
  llvm/include/llvm/IR/IntrinsicsHexagon.td
  llvm/include/llvm/IR/IntrinsicsMips.td
  llvm/include/llvm/IR/IntrinsicsNVVM.td
  llvm/include/llvm/IR/IntrinsicsPowerPC.td
  llvm/include/llvm/IR/IntrinsicsSystemZ.td
  llvm/include/llvm/IR/IntrinsicsVE.td
  llvm/include/llvm/IR/IntrinsicsVEVL.gen.td
  llvm/include/llvm/IR/IntrinsicsX86.td
  llvm/include/llvm/IR/IntrinsicsXCore.td
  llvm/lib/IR/Function.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Simon Pilgrim via Phabricator via cfe-commits 
RKSimon added inline comments.



Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:883
 void IntrinsicEmitter::EmitIntrinsicToBuiltinMap(
 const CodeGenIntrinsicTable , bool IsGCC, raw_ostream ) {
+  StringRef CompilerName = (IsGCC ? "Clang" : "MS");

IsGCC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added a comment.

I applied the changes suggested by @RKSimon and @efriedma.




Comment at: llvm/include/llvm/ADT/Triple.h:1031
   /// @}
   /// @name Static helpers for IDs.
   /// @{

ldionne wrote:
> Comment applies to `test_demangle.pass.cpp` (it's a binary file so I can't 
> comment on it). The test is currently failing because you need to change 
> `_ZN4llvm9Intrinsic25getIntrinsicForClangBuiltinEPKcS2_` to 
> `_ZN4llvm9Intrinsic27getIntrinsicForClangBuiltinEPKcS2_`.
You're right, I removed this change as it's unrelated.



Comment at: llvm/lib/IR/Function.cpp:1430
+// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method.
 #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN
 #include "llvm/IR/IntrinsicImpl.inc"

GuillaumeGomez wrote:
> GuillaumeGomez wrote:
> > RKSimon wrote:
> > > Should this be updated to use GET_LLVM_INTRINSIC_FOR_CLANG_BUILTIN?
> > I think it should for coherency. I'll send an update.
> When replacing with `CLANG`, it cannot build. After some investigations, it's 
> because of this:
> 
> ```
> llvm/utils/TableGen/IntrinsicEmitter.cpp:908:  OS << "#ifdef 
> GET_LLVM_INTRINSIC_FOR_" << CompilerName << "_BUILTIN\n";
> ```
> 
> So I'll let it as is for the time.
I fixed the error so it's now done. Thanks for the suggestion!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez updated this revision to Diff 436774.
GuillaumeGomez added a comment.

Update #define as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

Files:
  clang/lib/CodeGen/CGBuiltin.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/IntrinsicsAArch64.td
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/include/llvm/IR/IntrinsicsBPF.td
  llvm/include/llvm/IR/IntrinsicsHexagon.td
  llvm/include/llvm/IR/IntrinsicsMips.td
  llvm/include/llvm/IR/IntrinsicsNVVM.td
  llvm/include/llvm/IR/IntrinsicsPowerPC.td
  llvm/include/llvm/IR/IntrinsicsSystemZ.td
  llvm/include/llvm/IR/IntrinsicsVE.td
  llvm/include/llvm/IR/IntrinsicsVEVL.gen.td
  llvm/include/llvm/IR/IntrinsicsX86.td
  llvm/include/llvm/IR/IntrinsicsXCore.td
  llvm/lib/IR/Function.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added inline comments.



Comment at: llvm/lib/IR/Function.cpp:1430
+// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method.
 #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN
 #include "llvm/IR/IntrinsicImpl.inc"

RKSimon wrote:
> Should this be updated to use GET_LLVM_INTRINSIC_FOR_CLANG_BUILTIN?
I think it should for coherency. I'll send an update.



Comment at: llvm/lib/IR/Function.cpp:1430
+// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method.
 #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN
 #include "llvm/IR/IntrinsicImpl.inc"

GuillaumeGomez wrote:
> RKSimon wrote:
> > Should this be updated to use GET_LLVM_INTRINSIC_FOR_CLANG_BUILTIN?
> I think it should for coherency. I'll send an update.
When replacing with `CLANG`, it cannot build. After some investigations, it's 
because of this:

```
llvm/utils/TableGen/IntrinsicEmitter.cpp:908:  OS << "#ifdef 
GET_LLVM_INTRINSIC_FOR_" << CompilerName << "_BUILTIN\n";
```

So I'll let it as is for the time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Simon Pilgrim via Phabricator via cfe-commits 
RKSimon added inline comments.



Comment at: llvm/lib/IR/Function.cpp:1430
+// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method.
 #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN
 #include "llvm/IR/IntrinsicImpl.inc"

Should this be updated to use GET_LLVM_INTRINSIC_FOR_CLANG_BUILTIN?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-14 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added a comment.

@efriedma It was falling the tests because of that, which is why I updated it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-13 Thread Eli Friedman via Phabricator via cfe-commits 
efriedma added a comment.

Why are you messing with test_demangle.pass.cpp?  The demangler doesn't care 
what symbols we actually define in LLVM... it's just a bunch of hardcoded 
testcases.  So it doesn't matter if it continues to refer to GCCBuiltin.

Other changes look fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-13 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added 1 blocking reviewer(s): libc++abi.
GuillaumeGomez added a comment.

I finally took time to fix the failing test.

For some reason, I can't seem to push without marking 
`libcxxabi/test/test_demangle.pass.cpp` as a binary file with `arc diff HEAD~2 
--update D127460`. I hope this is fine...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-13 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez updated this revision to Diff 436527.
GuillaumeGomez added a comment.

Fix libcxxabi mangling test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

Files:
  clang/lib/CodeGen/CGBuiltin.cpp
  libcxxabi/test/test_demangle.pass.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/IntrinsicsAArch64.td
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/include/llvm/IR/IntrinsicsBPF.td
  llvm/include/llvm/IR/IntrinsicsHexagon.td
  llvm/include/llvm/IR/IntrinsicsMips.td
  llvm/include/llvm/IR/IntrinsicsNVVM.td
  llvm/include/llvm/IR/IntrinsicsPowerPC.td
  llvm/include/llvm/IR/IntrinsicsSystemZ.td
  llvm/include/llvm/IR/IntrinsicsVE.td
  llvm/include/llvm/IR/IntrinsicsVEVL.gen.td
  llvm/include/llvm/IR/IntrinsicsX86.td
  llvm/include/llvm/IR/IntrinsicsXCore.td
  llvm/lib/IR/Function.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-13 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez updated this revision to Diff 436525.
GuillaumeGomez added a comment.

Fix libcxxabi mangling test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

Files:
  libcxxabi/test/test_demangle.pass.cpp




___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-13 Thread Louis Dionne via Phabricator via cfe-commits 
ldionne accepted this revision as: libc++abi.
ldionne added a comment.

LGTM for libc++abi once my comment is addressed, which should make the libc++ 
CI pass. Please don't submit this until you have a green check-mark from the 
libc++ CI.




Comment at: llvm/include/llvm/ADT/Triple.h:1031
   /// @}
   /// @name Static helpers for IDs.
   /// @{

Comment applies to `test_demangle.pass.cpp` (it's a binary file so I can't 
comment on it). The test is currently failing because you need to change 
`_ZN4llvm9Intrinsic25getIntrinsicForClangBuiltinEPKcS2_` to 
`_ZN4llvm9Intrinsic27getIntrinsicForClangBuiltinEPKcS2_`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-09 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez added a subscriber: craig.topper.
GuillaumeGomez added a comment.

As mentioned in https://reviews.llvm.org/D127409, it would avoid confusions to 
name it `ClangBuiltin` instead of keeping `GCCBuiltin`.

cc @craig.topper


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127460/new/

https://reviews.llvm.org/D127460

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

2022-06-09 Thread Guillaume Gomez via Phabricator via cfe-commits 
GuillaumeGomez created this revision.
Herald added subscribers: kosarev, mattd, gchakrabarti, kerbowa, atanasyan, 
jrtc27, hiraditya, jvesely, nemanjai, sdardis.
Herald added a project: All.
GuillaumeGomez requested review of this revision.
Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits, jdoerfert, 
jholewinski.
Herald added projects: clang, libc++abi, LLVM.
Herald added a reviewer: libc++abi.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127460

Files:
  clang/lib/CodeGen/CGBuiltin.cpp
  libcxxabi/test/test_demangle.pass.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/IntrinsicsAArch64.td
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/include/llvm/IR/IntrinsicsBPF.td
  llvm/include/llvm/IR/IntrinsicsHexagon.td
  llvm/include/llvm/IR/IntrinsicsMips.td
  llvm/include/llvm/IR/IntrinsicsNVVM.td
  llvm/include/llvm/IR/IntrinsicsPowerPC.td
  llvm/include/llvm/IR/IntrinsicsSystemZ.td
  llvm/include/llvm/IR/IntrinsicsVE.td
  llvm/include/llvm/IR/IntrinsicsVEVL.gen.td
  llvm/include/llvm/IR/IntrinsicsX86.td
  llvm/include/llvm/IR/IntrinsicsXCore.td
  llvm/lib/IR/Function.cpp
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/CodeGenTarget.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits