[PATCH] D135558: [Clang][NFC]Use isa instead of dyn_cast in shouldAddReversedEqEq

[Liao Chunyu via Phabricator via cfe-commits]

liaolucy abandoned this revision.
liaolucy added a comment.

In D135558#3848649 , @tbaeder wrote:

> This was fixed as 
> https://github.com/llvm/llvm-project/commit/6c49d5db30227d21e929bb12dc046c36ede67fad.
>  Note that for such patches, you don't need to wait for review, like Erich 
> didn't.

thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135558/new/

https://reviews.llvm.org/D135558

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135558: [Clang][NFC]Use isa instead of dyn_cast in shouldAddReversedEqEq

[Timm Bäder via Phabricator via cfe-commits]

tbaeder added a comment.

This was fixed as 
https://github.com/llvm/llvm-project/commit/6c49d5db30227d21e929bb12dc046c36ede67fad.
 Note that for such patches, you don't need to wait for review, like Erich 
didn't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135558/new/

https://reviews.llvm.org/D135558

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135558: [Clang][NFC]Use isa instead of dyn_cast in shouldAddReversedEqEq

[Liao Chunyu via Phabricator via cfe-commits]

liaolucy created this revision.
liaolucy added a reviewer: usaxena95.
Herald added a project: All.
liaolucy requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Fix warning: unused variable ‘MD’


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135558

Files:
  clang/lib/Sema/SemaOverload.cpp


Index: clang/lib/Sema/SemaOverload.cpp
===
--- clang/lib/Sema/SemaOverload.cpp
+++ clang/lib/Sema/SemaOverload.cpp
@@ -931,7 +931,7 @@
   // target.
   DeclarationName NotEqOp = S.Context.DeclarationNames.getCXXOperatorName(
   OverloadedOperatorKind::OO_ExclaimEqual);
-  if (auto *MD = dyn_cast(EqFD)) {
+  if (isa(EqFD)) {
 // If F is a class member, search scope is class type of first operand.
 QualType RHS = FirstOperand->getType();
 auto *RHSRec = RHS->getAs();


Index: clang/lib/Sema/SemaOverload.cpp
===
--- clang/lib/Sema/SemaOverload.cpp
+++ clang/lib/Sema/SemaOverload.cpp
@@ -931,7 +931,7 @@
   // target.
   DeclarationName NotEqOp = S.Context.DeclarationNames.getCXXOperatorName(
   OverloadedOperatorKind::OO_ExclaimEqual);
-  if (auto *MD = dyn_cast(EqFD)) {
+  if (isa(EqFD)) {
 // If F is a class member, search scope is class type of first operand.
 QualType RHS = FirstOperand->getType();
 auto *RHSRec = RHS->getAs();
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits