[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

Thanks for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135931/new/

https://reviews.llvm.org/D135931

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

[Volodymyr Sapsai via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG1783253c41f1: [Attributes] Improve writing `ExprArgument` 
value. (authored by vsapsai).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135931/new/

https://reviews.llvm.org/D135931

Files:
  clang/test/SemaCXX/attr-print.cpp
  clang/utils/TableGen/ClangAttrEmitter.cpp


Index: clang/utils/TableGen/ClangAttrEmitter.cpp
===
--- clang/utils/TableGen/ClangAttrEmitter.cpp
+++ clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -1216,6 +1216,13 @@
   OS << "  }\n";
 }
 
+void writeValue(raw_ostream ) const override {
+  OS << "\";\n";
+  OS << "get" << getUpperName()
+ << "()->printPretty(OS, nullptr, Policy);\n";
+  OS << "OS << \"";
+}
+
 void writeDump(raw_ostream ) const override {}
 
 void writeDumpChildren(raw_ostream ) const override {
Index: clang/test/SemaCXX/attr-print.cpp
===
--- clang/test/SemaCXX/attr-print.cpp
+++ clang/test/SemaCXX/attr-print.cpp
@@ -43,3 +43,6 @@
 
 // CHECK: class __virtual_inheritance VirtualInheritance;
 class __virtual_inheritance VirtualInheritance;
+
+// CHECK: typedef double *aligned_double __attribute__((align_value(64)));
+typedef double * __attribute__((align_value(64))) aligned_double;


Index: clang/utils/TableGen/ClangAttrEmitter.cpp
===
--- clang/utils/TableGen/ClangAttrEmitter.cpp
+++ clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -1216,6 +1216,13 @@
   OS << "  }\n";
 }
 
+void writeValue(raw_ostream ) const override {
+  OS << "\";\n";
+  OS << "get" << getUpperName()
+ << "()->printPretty(OS, nullptr, Policy);\n";
+  OS << "OS << \"";
+}
+
 void writeDump(raw_ostream ) const override {}
 
 void writeDumpChildren(raw_ostream ) const override {
Index: clang/test/SemaCXX/attr-print.cpp
===
--- clang/test/SemaCXX/attr-print.cpp
+++ clang/test/SemaCXX/attr-print.cpp
@@ -43,3 +43,6 @@
 
 // CHECK: class __virtual_inheritance VirtualInheritance;
 class __virtual_inheritance VirtualInheritance;
+
+// CHECK: typedef double *aligned_double __attribute__((align_value(64)));
+typedef double * __attribute__((align_value(64))) aligned_double;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135931/new/

https://reviews.llvm.org/D135931

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai created this revision.
vsapsai added reviewers: aaron.ballman, erichkeane, rtrieu.
Herald added a subscriber: ributzka.
Herald added a project: All.
vsapsai requested review of this revision.
Herald added a project: clang.

Instead of dumping `Expr*` memory address, output `Expr` representation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135931

Files:
  clang/test/SemaCXX/attr-print.cpp
  clang/utils/TableGen/ClangAttrEmitter.cpp


Index: clang/utils/TableGen/ClangAttrEmitter.cpp
===
--- clang/utils/TableGen/ClangAttrEmitter.cpp
+++ clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -1216,6 +1216,13 @@
   OS << "  }\n";
 }
 
+void writeValue(raw_ostream ) const override {
+  OS << "\";\n";
+  OS << "get" << getUpperName()
+ << "()->printPretty(OS, nullptr, Policy);\n";
+  OS << "OS << \"";
+}
+
 void writeDump(raw_ostream ) const override {}
 
 void writeDumpChildren(raw_ostream ) const override {
Index: clang/test/SemaCXX/attr-print.cpp
===
--- clang/test/SemaCXX/attr-print.cpp
+++ clang/test/SemaCXX/attr-print.cpp
@@ -43,3 +43,6 @@
 
 // CHECK: class __virtual_inheritance VirtualInheritance;
 class __virtual_inheritance VirtualInheritance;
+
+// CHECK: typedef double *aligned_double __attribute__((align_value(64)));
+typedef double * __attribute__((align_value(64))) aligned_double;


Index: clang/utils/TableGen/ClangAttrEmitter.cpp
===
--- clang/utils/TableGen/ClangAttrEmitter.cpp
+++ clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -1216,6 +1216,13 @@
   OS << "  }\n";
 }
 
+void writeValue(raw_ostream ) const override {
+  OS << "\";\n";
+  OS << "get" << getUpperName()
+ << "()->printPretty(OS, nullptr, Policy);\n";
+  OS << "OS << \"";
+}
+
 void writeDump(raw_ostream ) const override {}
 
 void writeDumpChildren(raw_ostream ) const override {
Index: clang/test/SemaCXX/attr-print.cpp
===
--- clang/test/SemaCXX/attr-print.cpp
+++ clang/test/SemaCXX/attr-print.cpp
@@ -43,3 +43,6 @@
 
 // CHECK: class __virtual_inheritance VirtualInheritance;
 class __virtual_inheritance VirtualInheritance;
+
+// CHECK: typedef double *aligned_double __attribute__((align_value(64)));
+typedef double * __attribute__((align_value(64))) aligned_double;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits