[PATCH] D137309: [clang] Added Swift support for RISCV

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.



Comment at: clang/lib/CodeGen/TargetInfo.cpp:10555
 namespace {
-class RISCVABIInfo : public DefaultABIInfo {
+class RISCVABIInfo : public SwiftABIInfo {
 private:

SwiftABIInfo doesn't inherit from ABIInfo and hasn't since August last year. 
D130394


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137309/new/

https://reviews.llvm.org/D137309

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137309: [clang] Added Swift support for RISCV

[Jessica Clarke via Phabricator via cfe-commits]

jrtc27 added inline comments.



Comment at: clang/lib/CodeGen/TargetInfo.cpp:10557
 private:
+  DefaultABIInfo defaultInfo;
   // Size of the integer ('x') registers in bits.

Huh? This is unused.



Comment at: clang/lib/CodeGen/TargetInfo.cpp:10601
+bool asReturnValue) const override {
+return occupiesMoreThan(CGT, scalars, /*total*/ 4);
+  }

The argument's called maxAllRegisters?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137309/new/

https://reviews.llvm.org/D137309

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137309: [clang] Added Swift support for RISCV

[Alsey Coleman Miller via Phabricator via cfe-commits]

colemancda added a comment.

In D137309#3914550 , @asb wrote:

> In D137309#3914494 , @colemancda 
> wrote:
>
>> RV32 is enabled as well. I'll add unit tests.
>
> Great, thanks. Is it really the case that shouldPassIndirectlyForSwift has 
> the same result regardless of native word size?

Yes, if you check other implementations like Arm and AArch64, the 
implementation is the same.
Where is a good place to start for the unit test development for this ABI?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137309/new/

https://reviews.llvm.org/D137309

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137309: [clang] Added Swift support for RISCV

[Alex Bradbury via Phabricator via cfe-commits]

asb added a comment.

In D137309#3914494 , @colemancda 
wrote:

> RV32 is enabled as well. I'll add unit tests.

Great, thanks. Is it really the case that shouldPassIndirectlyForSwift has the 
same result regardless of native word size?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137309/new/

https://reviews.llvm.org/D137309

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137309: [clang] Added Swift support for RISCV

[Alsey Coleman Miller via Phabricator via cfe-commits]

colemancda added a comment.

RV32 is enabled as well. I'll add unit tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137309/new/

https://reviews.llvm.org/D137309

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits