[PATCH] D139547: [NFC] Correct argument comment typo

2023-01-30 Thread Fangrui Song via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9f5d881206ce: [NFC] Correct argument comment typo (authored 
by gAlfonso-bit, committed by MaskRay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139547/new/

https://reviews.llvm.org/D139547

Files:
  clang/lib/Driver/ToolChains/Darwin.cpp


Index: clang/lib/Driver/ToolChains/Darwin.cpp
===
--- clang/lib/Driver/ToolChains/Darwin.cpp
+++ clang/lib/Driver/ToolChains/Darwin.cpp
@@ -1772,7 +1772,7 @@
  ->getAsString(Args);
 }
 return DarwinPlatform::createOSVersionArg(Darwin::MacOS, macOSVersion,
-  /*IsImulator=*/false);
+  /*IsSimulator=*/false);
   } else if (iOSVersion) {
 if (TvOSVersion || WatchOSVersion) {
   TheDriver.Diag(diag::err_drv_argument_not_allowed_with)


Index: clang/lib/Driver/ToolChains/Darwin.cpp
===
--- clang/lib/Driver/ToolChains/Darwin.cpp
+++ clang/lib/Driver/ToolChains/Darwin.cpp
@@ -1772,7 +1772,7 @@
  ->getAsString(Args);
 }
 return DarwinPlatform::createOSVersionArg(Darwin::MacOS, macOSVersion,
-  /*IsImulator=*/false);
+  /*IsSimulator=*/false);
   } else if (iOSVersion) {
 if (TvOSVersion || WatchOSVersion) {
   TheDriver.Diag(diag::err_drv_argument_not_allowed_with)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139547: [NFC] Correct argument comment typo

2023-01-25 Thread Alf via Phabricator via cfe-commits 
gAlfonso-bit added a comment.

@MaskRay Could you please commit this for me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139547/new/

https://reviews.llvm.org/D139547

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139547: [NFC] Correct argument comment typo

2022-12-08 Thread Alf via Phabricator via cfe-commits 
gAlfonso-bit added a comment.

@MaskRay How may I get commit permissions if I may ask?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139547/new/

https://reviews.llvm.org/D139547

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139547: [NFC] Correct argument comment typo

2022-12-07 Thread Alf via Phabricator via cfe-commits 
gAlfonso-bit added a comment.

@MaskRay This should be a quickie


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139547/new/

https://reviews.llvm.org/D139547

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139547: [NFC] Correct argument comment typo

2022-12-07 Thread Alf via Phabricator via cfe-commits 
gAlfonso-bit created this revision.
gAlfonso-bit added a reviewer: MaskRay.
gAlfonso-bit added projects: clang, LLVM.
Herald added a subscriber: StephenFan.
Herald added a project: All.
gAlfonso-bit requested review of this revision.
Herald added a subscriber: cfe-commits.

For Darwin, the boolean being passed is called IsSimulator, not "IsImulator"


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139547

Files:
  clang/lib/Driver/ToolChains/Darwin.cpp


Index: clang/lib/Driver/ToolChains/Darwin.cpp
===
--- clang/lib/Driver/ToolChains/Darwin.cpp
+++ clang/lib/Driver/ToolChains/Darwin.cpp
@@ -1765,7 +1765,7 @@
  ->getAsString(Args);
 }
 return DarwinPlatform::createOSVersionArg(Darwin::MacOS, macOSVersion,
-  /*IsImulator=*/false);
+  /*IsSimulator=*/false);
   } else if (iOSVersion) {
 if (TvOSVersion || WatchOSVersion) {
   TheDriver.Diag(diag::err_drv_argument_not_allowed_with)


Index: clang/lib/Driver/ToolChains/Darwin.cpp
===
--- clang/lib/Driver/ToolChains/Darwin.cpp
+++ clang/lib/Driver/ToolChains/Darwin.cpp
@@ -1765,7 +1765,7 @@
  ->getAsString(Args);
 }
 return DarwinPlatform::createOSVersionArg(Darwin::MacOS, macOSVersion,
-  /*IsImulator=*/false);
+  /*IsSimulator=*/false);
   } else if (iOSVersion) {
 if (TvOSVersion || WatchOSVersion) {
   TheDriver.Diag(diag::err_drv_argument_not_allowed_with)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits