Re: [PATCH] D14311: [Clang] Fix some Clang-tidy modernize warnings, other minor fixes
This revision was automatically updated to reflect the committed changes. Closed by commit rL252081: Fix some Clang-tidy modernize warnings, other minor fixes. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D14311?vs=39134&id=39252#toc Repository: rL LLVM http://reviews.llvm.org/D14311 Files: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/lib/Driver/Tools.h cfe/trunk/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp cfe/trunk/lib/StaticAnalyzer/Core/LoopWidening.cpp Index: cfe/trunk/lib/StaticAnalyzer/Core/LoopWidening.cpp === --- cfe/trunk/lib/StaticAnalyzer/Core/LoopWidening.cpp +++ cfe/trunk/lib/StaticAnalyzer/Core/LoopWidening.cpp @@ -23,7 +23,7 @@ static const Expr *getLoopCondition(const Stmt *LoopStmt) { switch (LoopStmt->getStmtClass()) { default: -return NULL; +return nullptr; case Stmt::ForStmtClass: return cast(LoopStmt)->getCond(); case Stmt::WhileStmtClass: Index: cfe/trunk/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp === --- cfe/trunk/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp +++ cfe/trunk/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp @@ -32,9 +32,9 @@ LockState(Kind K) : K(K) {} public: - static LockState getLocked(void) { return LockState(Locked); } - static LockState getUnlocked(void) { return LockState(Unlocked); } - static LockState getDestroyed(void) { return LockState(Destroyed); } + static LockState getLocked() { return LockState(Locked); } + static LockState getUnlocked() { return LockState(Unlocked); } + static LockState getDestroyed() { return LockState(Destroyed); } bool operator==(const LockState &X) const { return K == X.K; Index: cfe/trunk/lib/Driver/Tools.cpp === --- cfe/trunk/lib/Driver/Tools.cpp +++ cfe/trunk/lib/Driver/Tools.cpp @@ -1,4 +1,4 @@ -//===--- Tools.cpp - Tools Implementations ===// +//===--- Tools.cpp - Tools Implementations --*- C++ -*-===// // // The LLVM Compiler Infrastructure // @@ -10107,7 +10107,7 @@ if (!Args.hasArg(options::OPT_nostdlib) && !Args.hasArg(options::OPT_nostartfiles)) { -const char *crt1 = NULL; +const char *crt1 = nullptr; if (!Args.hasArg(options::OPT_shared)) { if (Args.hasArg(options::OPT_pg)) crt1 = "gcrt1.o"; @@ -10121,7 +10121,7 @@ CmdArgs.push_back(Args.MakeArgString(ToolChain.GetFilePath("crti.o"))); -const char *crtbegin = NULL; +const char *crtbegin = nullptr; if (Args.hasArg(options::OPT_static)) crtbegin = "crtbeginT.o"; else if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_pie)) Index: cfe/trunk/lib/Driver/Tools.h === --- cfe/trunk/lib/Driver/Tools.h +++ cfe/trunk/lib/Driver/Tools.h @@ -255,7 +255,7 @@ void appendEBLinkFlags(const llvm::opt::ArgList &Args, ArgStringList &CmdArgs, const llvm::Triple &Triple); -} +} // end namespace arm namespace mips { typedef enum { NanLegacy = 1, Nan2008 = 2 } NanEncoding; @@ -278,11 +278,11 @@ bool shouldUseFPXX(const llvm::opt::ArgList &Args, const llvm::Triple &Triple, StringRef CPUName, StringRef ABIName, mips::FloatABI FloatABI); -} +} // end namespace mips namespace ppc { bool hasPPCAbiArg(const llvm::opt::ArgList &Args, const char *Value); -} +} // end namespace ppc /// cloudabi -- Directly call GNU Binutils linker namespace cloudabi { @@ -396,7 +396,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; -} +} // end namespace darwin /// openbsd -- Directly call GNU Binutils assembler and linker namespace openbsd { @@ -412,6 +412,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; + class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { public: Linker(const ToolChain &TC) : GnuTool("openbsd::Linker", "linker", TC) {} @@ -440,6 +441,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; + class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { public: Linker(const ToolChain &TC) : GnuTool("bitrig::Linker", "linker", TC) {} @@ -468,6 +470,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; + class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { public: Linker(const ToolChain &TC) : GnuTool("freebsd::Linker", "linker", TC) {} @@ -485,7 +488,6 @@ /// netbsd -- Directly call GNU Binutils assembler and linker namespace netbsd { class LLVM
Re: [PATCH] D14311: [Clang] Fix some Clang-tidy modernize warnings, other minor fixes
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D14311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D14311: [Clang] Fix some Clang-tidy modernize warnings, other minor fixes
Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added subscribers: dschuff, jfb. Fixed warnings are: modernize-use-override, modernize-use-nullptr and modernize-redundant-void-arg. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM http://reviews.llvm.org/D14311 Files: lib/AST/ASTContext.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp lib/StaticAnalyzer/Core/LoopWidening.cpp Index: lib/StaticAnalyzer/Core/LoopWidening.cpp === --- lib/StaticAnalyzer/Core/LoopWidening.cpp +++ lib/StaticAnalyzer/Core/LoopWidening.cpp @@ -23,7 +23,7 @@ static const Expr *getLoopCondition(const Stmt *LoopStmt) { switch (LoopStmt->getStmtClass()) { default: -return NULL; +return nullptr; case Stmt::ForStmtClass: return cast(LoopStmt)->getCond(); case Stmt::WhileStmtClass: Index: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp === --- lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp +++ lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp @@ -32,9 +32,9 @@ LockState(Kind K) : K(K) {} public: - static LockState getLocked(void) { return LockState(Locked); } - static LockState getUnlocked(void) { return LockState(Unlocked); } - static LockState getDestroyed(void) { return LockState(Destroyed); } + static LockState getLocked() { return LockState(Locked); } + static LockState getUnlocked() { return LockState(Unlocked); } + static LockState getDestroyed() { return LockState(Destroyed); } bool operator==(const LockState &X) const { return K == X.K; Index: lib/Driver/Tools.h === --- lib/Driver/Tools.h +++ lib/Driver/Tools.h @@ -255,7 +255,7 @@ void appendEBLinkFlags(const llvm::opt::ArgList &Args, ArgStringList &CmdArgs, const llvm::Triple &Triple); -} +} // end namespace arm namespace mips { typedef enum { NanLegacy = 1, Nan2008 = 2 } NanEncoding; @@ -278,11 +278,11 @@ bool shouldUseFPXX(const llvm::opt::ArgList &Args, const llvm::Triple &Triple, StringRef CPUName, StringRef ABIName, mips::FloatABI FloatABI); -} +} // end namespace mips namespace ppc { bool hasPPCAbiArg(const llvm::opt::ArgList &Args, const char *Value); -} +} // end namespace ppc /// cloudabi -- Directly call GNU Binutils linker namespace cloudabi { @@ -396,7 +396,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; -} +} // end namespace darwin /// openbsd -- Directly call GNU Binutils assembler and linker namespace openbsd { @@ -412,6 +412,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; + class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { public: Linker(const ToolChain &TC) : GnuTool("openbsd::Linker", "linker", TC) {} @@ -440,6 +441,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; + class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { public: Linker(const ToolChain &TC) : GnuTool("bitrig::Linker", "linker", TC) {} @@ -468,6 +470,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; + class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { public: Linker(const ToolChain &TC) : GnuTool("freebsd::Linker", "linker", TC) {} @@ -485,7 +488,6 @@ /// netbsd -- Directly call GNU Binutils assembler and linker namespace netbsd { class LLVM_LIBRARY_VISIBILITY Assembler : public GnuTool { - public: Assembler(const ToolChain &TC) : GnuTool("netbsd::Assembler", "assembler", TC) {} @@ -497,8 +499,8 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; + class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { - public: Linker(const ToolChain &TC) : GnuTool("netbsd::Linker", "linker", TC) {} @@ -525,6 +527,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; + class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { public: Linker(const ToolChain &TC) : GnuTool("GNU::Linker", "linker", TC) {} @@ -537,7 +540,7 @@ const llvm::opt::ArgList &TCArgs, const char *LinkingOutput) const override; }; -} +} // end namespace gnutools namespace nacltools { class LLVM_LIBRARY_VISIBILITY AssemblerARM : public gnutools::Assembler { @@ -549,6 +552,7 @@ const llvm::opt::Arg