[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

2023-03-07 Thread Balázs Benics via Phabricator via cfe-commits 
steakhal added a comment.

As this resolves a crash, I'm backporting it: 
https://github.com/llvm/llvm-project/issues/61245


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144780/new/

https://reviews.llvm.org/D144780

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

2023-03-06 Thread Balázs Benics via Phabricator via cfe-commits 
steakhal added a comment.

Ah sorry that it took me so long to push this. I completely forgot about this 
one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144780/new/

https://reviews.llvm.org/D144780

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

2023-03-06 Thread Balázs Benics via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG53f75425b3fe: [analyzer] Explicit cast on customized 
offsetof should not be ignored when… (authored by danix800, committed by 
steakhal).

Changed prior to commit:
  https://reviews.llvm.org/D144780?vs=500385=502934#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144780/new/

https://reviews.llvm.org/D144780

Files:
  clang/lib/StaticAnalyzer/Core/BugReporter.cpp
  clang/test/Analysis/bitwise-ops-nocrash.c


Index: clang/test/Analysis/bitwise-ops-nocrash.c
===
--- /dev/null
+++ clang/test/Analysis/bitwise-ops-nocrash.c
@@ -0,0 +1,22 @@
+// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text 
-triple x86_64-linux-gnu -Wno-shift-count-overflow -verify %s
+
+#define offsetof(type,memb) ((unsigned long)&((type*)0)->memb)
+
+typedef struct {
+  unsigned long guest_counter;
+  unsigned int guest_fpc;
+} S;
+
+// no crash
+int left_shift_overflow_no_crash(unsigned int i) {
+  unsigned shift = 323U; // expected-note{{'shift' initialized to 323}}
+  switch (i) { // expected-note{{Control jumps to 'case 8:'  at line 14}}
+  case offsetof(S, guest_fpc):
+return 3 << shift; // expected-warning{{The result of the left shift is 
undefined due to shifting by '323', which is greater or equal to the width of 
type 'int'}}
+// expected-note@-1{{The result of the left shift is undefined due to 
shifting by '323', which is greater or equal to the width of type 'int'}}
+  default:
+break;
+  }
+
+  return 0;
+}
Index: clang/lib/StaticAnalyzer/Core/BugReporter.cpp
===
--- clang/lib/StaticAnalyzer/Core/BugReporter.cpp
+++ clang/lib/StaticAnalyzer/Core/BugReporter.cpp
@@ -766,7 +766,7 @@
 case Stmt::CaseStmtClass: {
   os << "Control jumps to 'case ";
   const auto *Case = cast(S);
-  const Expr *LHS = Case->getLHS()->IgnoreParenCasts();
+  const Expr *LHS = Case->getLHS()->IgnoreParenImpCasts();
 
   // Determine if it is an enum.
   bool GetRawInt = true;


Index: clang/test/Analysis/bitwise-ops-nocrash.c
===
--- /dev/null
+++ clang/test/Analysis/bitwise-ops-nocrash.c
@@ -0,0 +1,22 @@
+// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -triple x86_64-linux-gnu -Wno-shift-count-overflow -verify %s
+
+#define offsetof(type,memb) ((unsigned long)&((type*)0)->memb)
+
+typedef struct {
+  unsigned long guest_counter;
+  unsigned int guest_fpc;
+} S;
+
+// no crash
+int left_shift_overflow_no_crash(unsigned int i) {
+  unsigned shift = 323U; // expected-note{{'shift' initialized to 323}}
+  switch (i) { // expected-note{{Control jumps to 'case 8:'  at line 14}}
+  case offsetof(S, guest_fpc):
+return 3 << shift; // expected-warning{{The result of the left shift is undefined due to shifting by '323', which is greater or equal to the width of type 'int'}}
+// expected-note@-1{{The result of the left shift is undefined due to shifting by '323', which is greater or equal to the width of type 'int'}}
+  default:
+break;
+  }
+
+  return 0;
+}
Index: clang/lib/StaticAnalyzer/Core/BugReporter.cpp
===
--- clang/lib/StaticAnalyzer/Core/BugReporter.cpp
+++ clang/lib/StaticAnalyzer/Core/BugReporter.cpp
@@ -766,7 +766,7 @@
 case Stmt::CaseStmtClass: {
   os << "Control jumps to 'case ";
   const auto *Case = cast(S);
-  const Expr *LHS = Case->getLHS()->IgnoreParenCasts();
+  const Expr *LHS = Case->getLHS()->IgnoreParenImpCasts();
 
   // Determine if it is an enum.
   bool GetRawInt = true;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

2023-02-27 Thread Ding Fei via Phabricator via cfe-commits 
danix800 added a comment.

danix800 (danix...@gmail.com) is OK, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144780/new/

https://reviews.llvm.org/D144780

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

2023-02-27 Thread Balázs Benics via Phabricator via cfe-commits 
steakhal added a comment.

In D144780#4154619 , @danix800 wrote:

> In D144780#4154487 , @steakhal 
> wrote:
>
>> I love it. Short, to the point. Thanks.
>> I think this is the right way to fix this.
>> Good job.
>> Can you merge the change? Or should I do it on you behalf?
>
> I've no permission to merge, please do it for me. Thanks!

In that case please tell me what should I set as the commit-author?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144780/new/

https://reviews.llvm.org/D144780

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

2023-02-27 Thread Ding Fei via Phabricator via cfe-commits 
danix800 added a comment.

In D144780#4154487 , @steakhal wrote:

> I love it. Short, to the point. Thanks.
> I think this is the right way to fix this.
> Good job.
> Can you merge the change? Or should I do it on you behalf?

I've no permission to merge, please do it for me. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144780/new/

https://reviews.llvm.org/D144780

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

2023-02-27 Thread Balázs Benics via Phabricator via cfe-commits 
steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

I love it. Short, to the point. Thanks.
I think this is the right way to fix this.
Good job.
Can you merge the change? Or should I do it on you behalf?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144780/new/

https://reviews.llvm.org/D144780

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

2023-02-25 Thread Ding Fei via Phabricator via cfe-commits 
danix800 created this revision.
danix800 added a project: clang.
Herald added subscribers: steakhal, martong.
Herald added a reviewer: NoQ.
Herald added a project: All.
danix800 requested review of this revision.
Herald added a subscriber: cfe-commits.

If ignored, the subexpr is a UnaryOperator (&) which cannot be evaluated 
(assertion failed).

`#define offsetof(type,memb) ((unsigned long)&((type*)0)->memb)`


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144780

Files:
  clang/lib/StaticAnalyzer/Core/BugReporter.cpp
  clang/test/Analysis/bitwise-ops-nocrash.c


Index: clang/test/Analysis/bitwise-ops-nocrash.c
===
--- /dev/null
+++ clang/test/Analysis/bitwise-ops-nocrash.c
@@ -0,0 +1,22 @@
+// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text 
-triple x86_64-linux-gnu -Wno-shift-count-overflow -verify %s
+
+#define offsetof(type,memb) ((unsigned long)&((type*)0)->memb)
+
+typedef struct {
+  unsigned long guest_counter;
+  unsigned int guest_fpc;
+} S;
+
+// no crash
+int left_shift_overflow_no_crash(unsigned int i) {
+  unsigned shift = 323U; // expected-note{{'shift' initialized to 323}}
+  switch (i) { // expected-note{{Control jumps to 'case 8:'  at line 13}}
+  case offsetof(S, guest_fpc):
+return 3 << shift; // expected-warning{{The result of the left shift is 
undefined due to shifting by '323', which is greater or equal to the width of 
type 'int'}}
+// expected-note@-1{{The result of the left shift is undefined due to 
shifting by '323', which is greater or equal to the width of type 'int'}}
+  default:
+break;
+  }
+
+  return 0;
+}
Index: clang/lib/StaticAnalyzer/Core/BugReporter.cpp
===
--- clang/lib/StaticAnalyzer/Core/BugReporter.cpp
+++ clang/lib/StaticAnalyzer/Core/BugReporter.cpp
@@ -766,7 +766,7 @@
 case Stmt::CaseStmtClass: {
   os << "Control jumps to 'case ";
   const auto *Case = cast(S);
-  const Expr *LHS = Case->getLHS()->IgnoreParenCasts();
+  const Expr *LHS = Case->getLHS()->IgnoreParenImpCasts();
 
   // Determine if it is an enum.
   bool GetRawInt = true;


Index: clang/test/Analysis/bitwise-ops-nocrash.c
===
--- /dev/null
+++ clang/test/Analysis/bitwise-ops-nocrash.c
@@ -0,0 +1,22 @@
+// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -triple x86_64-linux-gnu -Wno-shift-count-overflow -verify %s
+
+#define offsetof(type,memb) ((unsigned long)&((type*)0)->memb)
+
+typedef struct {
+  unsigned long guest_counter;
+  unsigned int guest_fpc;
+} S;
+
+// no crash
+int left_shift_overflow_no_crash(unsigned int i) {
+  unsigned shift = 323U; // expected-note{{'shift' initialized to 323}}
+  switch (i) { // expected-note{{Control jumps to 'case 8:'  at line 13}}
+  case offsetof(S, guest_fpc):
+return 3 << shift; // expected-warning{{The result of the left shift is undefined due to shifting by '323', which is greater or equal to the width of type 'int'}}
+// expected-note@-1{{The result of the left shift is undefined due to shifting by '323', which is greater or equal to the width of type 'int'}}
+  default:
+break;
+  }
+
+  return 0;
+}
Index: clang/lib/StaticAnalyzer/Core/BugReporter.cpp
===
--- clang/lib/StaticAnalyzer/Core/BugReporter.cpp
+++ clang/lib/StaticAnalyzer/Core/BugReporter.cpp
@@ -766,7 +766,7 @@
 case Stmt::CaseStmtClass: {
   os << "Control jumps to 'case ";
   const auto *Case = cast(S);
-  const Expr *LHS = Case->getLHS()->IgnoreParenCasts();
+  const Expr *LHS = Case->getLHS()->IgnoreParenImpCasts();
 
   // Determine if it is an enum.
   bool GetRawInt = true;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits