[PATCH] D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols.
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG404b1b2ed42f: [Tooling/Inclusion] Add missing placerholder _1 symbols. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145553/new/ https://reviews.llvm.org/D145553 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc clang/tools/include-mapping/gen_std.py Index: clang/tools/include-mapping/gen_std.py === --- clang/tools/include-mapping/gen_std.py +++ clang/tools/include-mapping/gen_std.py @@ -245,9 +245,8 @@ # We don't index std literal operators (e.g. # std::literals::chrono_literals::operator""d), these symbols can't be # accessed by std::. - # FIXME: index std::placeholders symbols, placeholders.html page is - # different (which contains one entry for _1, _2, ..., _N), we need special - # handling. + # + # std::placeholders symbols are handled manually in StdSpecialSymbolMap.inc (symbol_index_root, "chrono.html", "std::chrono::"), (symbol_index_root, "filesystem.html", "std::filesystem::"), (symbol_index_root, "pmr.html", "std::pmr::"), Index: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc === --- clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc +++ clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc @@ -254,6 +254,40 @@ SYMBOL(make_index_sequence, std::, ) SYMBOL(make_integer_sequence, std::, ) +// The std::placeholder symbols (_1, ..., _N) are listed in the cppreference +// placeholder.html, but the index only contains a single entry with "_1, _2, ..., _N" +// text, which are not handled by the script. +// N is an implementation-defined number (10 for libc++; 29 for libstdc++). +SYMBOL(_1, std::placeholders::, ) +SYMBOL(_2, std::placeholders::, ) +SYMBOL(_3, std::placeholders::, ) +SYMBOL(_4, std::placeholders::, ) +SYMBOL(_5, std::placeholders::, ) +SYMBOL(_6, std::placeholders::, ) +SYMBOL(_7, std::placeholders::, ) +SYMBOL(_8, std::placeholders::, ) +SYMBOL(_9, std::placeholders::, ) +SYMBOL(_10, std::placeholders::, ) +SYMBOL(_11, std::placeholders::, ) +SYMBOL(_12, std::placeholders::, ) +SYMBOL(_13, std::placeholders::, ) +SYMBOL(_14, std::placeholders::, ) +SYMBOL(_15, std::placeholders::, ) +SYMBOL(_16, std::placeholders::, ) +SYMBOL(_17, std::placeholders::, ) +SYMBOL(_18, std::placeholders::, ) +SYMBOL(_19, std::placeholders::, ) +SYMBOL(_20, std::placeholders::, ) +SYMBOL(_21, std::placeholders::, ) +SYMBOL(_22, std::placeholders::, ) +SYMBOL(_23, std::placeholders::, ) +SYMBOL(_24, std::placeholders::, ) +SYMBOL(_25, std::placeholders::, ) +SYMBOL(_26, std::placeholders::, ) +SYMBOL(_27, std::placeholders::, ) +SYMBOL(_28, std::placeholders::, ) +SYMBOL(_29, std::placeholders::, ) + // Macros SYMBOL(NULL, None, ) SYMBOL(NULL, None, ) Index: clang/tools/include-mapping/gen_std.py === --- clang/tools/include-mapping/gen_std.py +++ clang/tools/include-mapping/gen_std.py @@ -245,9 +245,8 @@ # We don't index std literal operators (e.g. # std::literals::chrono_literals::operator""d), these symbols can't be # accessed by std::. - # FIXME: index std::placeholders symbols, placeholders.html page is - # different (which contains one entry for _1, _2, ..., _N), we need special - # handling. + # + # std::placeholders symbols are handled manually in StdSpecialSymbolMap.inc (symbol_index_root, "chrono.html", "std::chrono::"), (symbol_index_root, "filesystem.html", "std::filesystem::"), (symbol_index_root, "pmr.html", "std::pmr::"), Index: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc === --- clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc +++ clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc @@ -254,6 +254,40 @@ SYMBOL(make_index_sequence, std::, ) SYMBOL(make_integer_sequence, std::, ) +// The std::placeholder symbols (_1, ..., _N) are listed in the cppreference +// placeholder.html, but the index only contains a single entry with "_1, _2, ..., _N" +// text, which are not handled by the script. +// N is an implementation-defined number (10 for libc++; 29 for libstdc++). +SYMBOL(_1, std::placeholders::, ) +SYMBOL(_2, std::placeholders::, ) +SYMBOL(_3, std::placeholders::, ) +SYMBOL(_4, std::placeholders::, ) +SYMBOL(_5, std::placeholders::, ) +SYMBOL(_6, std::placeholders::, ) +SYMBOL(_7, std::placeholders::, ) +SYMBOL(_8, std::placeholders::, ) +SYMBOL(_9, std::placeholders::, ) +SYMBOL(_10, std::placeholders::, ) +SYMBOL(_11, std::placeholders::, ) +SYMBOL(_12, std::placeholders::, ) +SYMBOL(_13, std:
[PATCH] D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols.
hokein updated this revision to Diff 503653. hokein marked an inline comment as done. hokein added a comment. address comment: add more _N symbol up to _29. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145553/new/ https://reviews.llvm.org/D145553 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc clang/tools/include-mapping/gen_std.py Index: clang/tools/include-mapping/gen_std.py === --- clang/tools/include-mapping/gen_std.py +++ clang/tools/include-mapping/gen_std.py @@ -245,9 +245,8 @@ # We don't index std literal operators (e.g. # std::literals::chrono_literals::operator""d), these symbols can't be # accessed by std::. - # FIXME: index std::placeholders symbols, placeholders.html page is - # different (which contains one entry for _1, _2, ..., _N), we need special - # handling. + # + # std::placeholders symbols are handled manually in StdSpecialSymbolMap.inc (symbol_index_root, "chrono.html", "std::chrono::"), (symbol_index_root, "filesystem.html", "std::filesystem::"), (symbol_index_root, "pmr.html", "std::pmr::"), Index: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc === --- clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc +++ clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc @@ -254,6 +254,40 @@ SYMBOL(make_index_sequence, std::, ) SYMBOL(make_integer_sequence, std::, ) +// The std::placeholder symbols (_1, ..., _N) are listed in the cppreference +// placeholder.html, but the index only contains a single entry with "_1, _2, ..., _N" +// text, which are not handled by the script. +// N is an implementation-defined number (10 for libc++; 29 for libstdc++). +SYMBOL(_1, std::placeholders::, ) +SYMBOL(_2, std::placeholders::, ) +SYMBOL(_3, std::placeholders::, ) +SYMBOL(_4, std::placeholders::, ) +SYMBOL(_5, std::placeholders::, ) +SYMBOL(_6, std::placeholders::, ) +SYMBOL(_7, std::placeholders::, ) +SYMBOL(_8, std::placeholders::, ) +SYMBOL(_9, std::placeholders::, ) +SYMBOL(_10, std::placeholders::, ) +SYMBOL(_11, std::placeholders::, ) +SYMBOL(_12, std::placeholders::, ) +SYMBOL(_13, std::placeholders::, ) +SYMBOL(_14, std::placeholders::, ) +SYMBOL(_15, std::placeholders::, ) +SYMBOL(_16, std::placeholders::, ) +SYMBOL(_17, std::placeholders::, ) +SYMBOL(_18, std::placeholders::, ) +SYMBOL(_19, std::placeholders::, ) +SYMBOL(_20, std::placeholders::, ) +SYMBOL(_21, std::placeholders::, ) +SYMBOL(_22, std::placeholders::, ) +SYMBOL(_23, std::placeholders::, ) +SYMBOL(_24, std::placeholders::, ) +SYMBOL(_25, std::placeholders::, ) +SYMBOL(_26, std::placeholders::, ) +SYMBOL(_27, std::placeholders::, ) +SYMBOL(_28, std::placeholders::, ) +SYMBOL(_29, std::placeholders::, ) + // Macros SYMBOL(NULL, None, ) SYMBOL(NULL, None, ) Index: clang/tools/include-mapping/gen_std.py === --- clang/tools/include-mapping/gen_std.py +++ clang/tools/include-mapping/gen_std.py @@ -245,9 +245,8 @@ # We don't index std literal operators (e.g. # std::literals::chrono_literals::operator""d), these symbols can't be # accessed by std::. - # FIXME: index std::placeholders symbols, placeholders.html page is - # different (which contains one entry for _1, _2, ..., _N), we need special - # handling. + # + # std::placeholders symbols are handled manually in StdSpecialSymbolMap.inc (symbol_index_root, "chrono.html", "std::chrono::"), (symbol_index_root, "filesystem.html", "std::filesystem::"), (symbol_index_root, "pmr.html", "std::pmr::"), Index: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc === --- clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc +++ clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc @@ -254,6 +254,40 @@ SYMBOL(make_index_sequence, std::, ) SYMBOL(make_integer_sequence, std::, ) +// The std::placeholder symbols (_1, ..., _N) are listed in the cppreference +// placeholder.html, but the index only contains a single entry with "_1, _2, ..., _N" +// text, which are not handled by the script. +// N is an implementation-defined number (10 for libc++; 29 for libstdc++). +SYMBOL(_1, std::placeholders::, ) +SYMBOL(_2, std::placeholders::, ) +SYMBOL(_3, std::placeholders::, ) +SYMBOL(_4, std::placeholders::, ) +SYMBOL(_5, std::placeholders::, ) +SYMBOL(_6, std::placeholders::, ) +SYMBOL(_7, std::placeholders::, ) +SYMBOL(_8, std::placeholders::, ) +SYMBOL(_9, std::placeholders::, ) +SYMBOL(_10, std::placeholders::, ) +SYMBOL(_11, std::placeholders::, ) +SYMBOL(_12, std::placeholders::, ) +SYMBOL(_13, std::placeholders::, ) +SYMBOL(_14, std::placeholders::, ) +SYMBOL(_15, std::placeholder
[PATCH] D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols.
kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:260 +// text, which are not handled by the script. +// N is an implementation-defined number, 10 should be enough in practice. +SYMBOL(_1, std::placeholders::, ) libstdc++ actually has _N=29 (don't know why not 30, as it starts from 1 actually :D) you mind listing it all the way till 29? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145553/new/ https://reviews.llvm.org/D145553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols.
hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145553 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc clang/tools/include-mapping/gen_std.py Index: clang/tools/include-mapping/gen_std.py === --- clang/tools/include-mapping/gen_std.py +++ clang/tools/include-mapping/gen_std.py @@ -245,9 +245,8 @@ # We don't index std literal operators (e.g. # std::literals::chrono_literals::operator""d), these symbols can't be # accessed by std::. - # FIXME: index std::placeholders symbols, placeholders.html page is - # different (which contains one entry for _1, _2, ..., _N), we need special - # handling. + # + # std::placeholders symbols are handled manually in StdSpecialSymbolMap.inc (symbol_index_root, "chrono.html", "std::chrono::"), (symbol_index_root, "filesystem.html", "std::filesystem::"), (symbol_index_root, "pmr.html", "std::pmr::"), Index: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc === --- clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc +++ clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc @@ -254,6 +254,21 @@ SYMBOL(make_index_sequence, std::, ) SYMBOL(make_integer_sequence, std::, ) +// The std::placeholder symbols (_1, ..., _N) are listed in the cppreference +// placeholder.html, but the index only contains a single entry with "_1, _2, ..., _N" +// text, which are not handled by the script. +// N is an implementation-defined number, 10 should be enough in practice. +SYMBOL(_1, std::placeholders::, ) +SYMBOL(_2, std::placeholders::, ) +SYMBOL(_3, std::placeholders::, ) +SYMBOL(_4, std::placeholders::, ) +SYMBOL(_5, std::placeholders::, ) +SYMBOL(_6, std::placeholders::, ) +SYMBOL(_7, std::placeholders::, ) +SYMBOL(_8, std::placeholders::, ) +SYMBOL(_9, std::placeholders::, ) +SYMBOL(_10, std::placeholders::, ) + // Macros SYMBOL(NULL, None, ) SYMBOL(NULL, None, ) Index: clang/tools/include-mapping/gen_std.py === --- clang/tools/include-mapping/gen_std.py +++ clang/tools/include-mapping/gen_std.py @@ -245,9 +245,8 @@ # We don't index std literal operators (e.g. # std::literals::chrono_literals::operator""d), these symbols can't be # accessed by std::. - # FIXME: index std::placeholders symbols, placeholders.html page is - # different (which contains one entry for _1, _2, ..., _N), we need special - # handling. + # + # std::placeholders symbols are handled manually in StdSpecialSymbolMap.inc (symbol_index_root, "chrono.html", "std::chrono::"), (symbol_index_root, "filesystem.html", "std::filesystem::"), (symbol_index_root, "pmr.html", "std::pmr::"), Index: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc === --- clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc +++ clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc @@ -254,6 +254,21 @@ SYMBOL(make_index_sequence, std::, ) SYMBOL(make_integer_sequence, std::, ) +// The std::placeholder symbols (_1, ..., _N) are listed in the cppreference +// placeholder.html, but the index only contains a single entry with "_1, _2, ..., _N" +// text, which are not handled by the script. +// N is an implementation-defined number, 10 should be enough in practice. +SYMBOL(_1, std::placeholders::, ) +SYMBOL(_2, std::placeholders::, ) +SYMBOL(_3, std::placeholders::, ) +SYMBOL(_4, std::placeholders::, ) +SYMBOL(_5, std::placeholders::, ) +SYMBOL(_6, std::placeholders::, ) +SYMBOL(_7, std::placeholders::, ) +SYMBOL(_8, std::placeholders::, ) +SYMBOL(_9, std::placeholders::, ) +SYMBOL(_10, std::placeholders::, ) + // Macros SYMBOL(NULL, None, ) SYMBOL(NULL, None, ) ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
