[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGafce10c5b60f: [clang][ExtractAPI] Add semicolons for enum,
typedef, struct declaration… (authored by chaitanyav, committed by dang).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146354/new/
https://reviews.llvm.org/D146354
Files:
clang/lib/ExtractAPI/DeclarationFragments.cpp
clang/test/ExtractAPI/anonymous_record_no_typedef.c
clang/test/ExtractAPI/enum.c
clang/test/ExtractAPI/struct.c
clang/test/ExtractAPI/typedef.c
clang/test/ExtractAPI/typedef_anonymous_record.c
clang/test/ExtractAPI/typedef_chain.c
clang/test/ExtractAPI/underscored.c
Index: clang/test/ExtractAPI/underscored.c
===
--- clang/test/ExtractAPI/underscored.c
+++ clang/test/ExtractAPI/underscored.c
@@ -135,6 +135,10 @@
{
"kind": "identifier",
"spelling": "ExposedRecord"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -296,6 +300,10 @@
{
"kind": "identifier",
"spelling": "ExposedTypedef"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -356,6 +364,10 @@
{
"kind": "identifier",
"spelling": "ExposedTypedefToHidden"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/typedef_chain.c
===
--- clang/test/ExtractAPI/typedef_chain.c
+++ clang/test/ExtractAPI/typedef_chain.c
@@ -68,6 +68,10 @@
{
"kind": "identifier",
"spelling": "MyInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -128,6 +132,10 @@
{
"kind": "identifier",
"spelling": "MyIntInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -188,6 +196,10 @@
{
"kind": "identifier",
"spelling": "MyIntIntInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/typedef_anonymous_record.c
===
--- clang/test/ExtractAPI/typedef_anonymous_record.c
+++ clang/test/ExtractAPI/typedef_anonymous_record.c
@@ -75,6 +75,10 @@
{
"kind": "identifier",
"spelling": "MyEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -170,6 +174,10 @@
{
"kind": "identifier",
"spelling": "MyStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -223,6 +231,10 @@
{
"kind": "identifier",
"spelling": "MyStructStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -283,6 +295,10 @@
{
"kind": "identifier",
"spelling": "MyStructStructStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -343,6 +359,10 @@
{
"kind": "identifier",
"spelling": "MyEnumEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -403,6 +423,10 @@
{
"kind": "identifier",
"spelling": "MyEnumEnumEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/typedef.c
===
--- clang/test/ExtractAPI/typedef.c
+++ clang/test/ExtractAPI/typedef.c
@@ -66,6 +66,10 @@
{
"kind": "identifier",
"spelling": "MyInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/struct.c
===
--- clang/test/ExtractAPI/struct.c
+++ clang/test/ExtractAPI/struct.c
@@ -89,6 +89,10 @@
{
"kind": "identifier",
"spelling": "Color"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"docComment": {
Index: clang/test/ExtractAPI/enum.c
===
--- clang/test/ExtractAPI/enum.c
+++
[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments
chaitanyav added a comment. Name: NagaChaitanya Vellanki email: pnag...@protonmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.org/D146354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments
chaitanyav added a comment. Thank you, Please go ahead and Commit the change. I don't have commit access, Will follow the instructions on the page to get access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.org/D146354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments
dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! I think it's fine to go ahead and land this (premerge check are not a requirement). Have you contributed to LLVM before? If not I will need to commit it on your behalf. Once that is done you should follow the instructions at https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access to gain commit access if you wish to continue contributing to the project and LLVM in general. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.org/D146354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments
chaitanyav added a comment. The debian build is failing because of this https://github.com/google/llvm-premerge-checks/issues/436 The windows build is failing because of https://github.com/llvm/llvm-project/issues/61519, i see that the fix (https://reviews.llvm.org/rGd233c7b814071e8b9345b1c25411272ec7446c8d) for this is already on main but i cannot trigger a new build for my changes. Please advice on how to trigger a new build that will run on latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146354/new/ https://reviews.llvm.org/D146354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments
chaitanyav updated this revision to Diff 506309.
chaitanyav added a comment.
- Update reference output in underscored.c
- combine return and append semicolon fragment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146354/new/
https://reviews.llvm.org/D146354
Files:
clang/lib/ExtractAPI/DeclarationFragments.cpp
clang/test/ExtractAPI/anonymous_record_no_typedef.c
clang/test/ExtractAPI/enum.c
clang/test/ExtractAPI/struct.c
clang/test/ExtractAPI/typedef.c
clang/test/ExtractAPI/typedef_anonymous_record.c
clang/test/ExtractAPI/typedef_chain.c
clang/test/ExtractAPI/underscored.c
Index: clang/test/ExtractAPI/underscored.c
===
--- clang/test/ExtractAPI/underscored.c
+++ clang/test/ExtractAPI/underscored.c
@@ -135,6 +135,10 @@
{
"kind": "identifier",
"spelling": "ExposedRecord"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -296,6 +300,10 @@
{
"kind": "identifier",
"spelling": "ExposedTypedef"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -356,6 +364,10 @@
{
"kind": "identifier",
"spelling": "ExposedTypedefToHidden"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/typedef_chain.c
===
--- clang/test/ExtractAPI/typedef_chain.c
+++ clang/test/ExtractAPI/typedef_chain.c
@@ -68,6 +68,10 @@
{
"kind": "identifier",
"spelling": "MyInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -128,6 +132,10 @@
{
"kind": "identifier",
"spelling": "MyIntInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -188,6 +196,10 @@
{
"kind": "identifier",
"spelling": "MyIntIntInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/typedef_anonymous_record.c
===
--- clang/test/ExtractAPI/typedef_anonymous_record.c
+++ clang/test/ExtractAPI/typedef_anonymous_record.c
@@ -75,6 +75,10 @@
{
"kind": "identifier",
"spelling": "MyEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -170,6 +174,10 @@
{
"kind": "identifier",
"spelling": "MyStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -223,6 +231,10 @@
{
"kind": "identifier",
"spelling": "MyStructStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -283,6 +295,10 @@
{
"kind": "identifier",
"spelling": "MyStructStructStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -343,6 +359,10 @@
{
"kind": "identifier",
"spelling": "MyEnumEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -403,6 +423,10 @@
{
"kind": "identifier",
"spelling": "MyEnumEnumEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/typedef.c
===
--- clang/test/ExtractAPI/typedef.c
+++ clang/test/ExtractAPI/typedef.c
@@ -66,6 +66,10 @@
{
"kind": "identifier",
"spelling": "MyInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/struct.c
===
--- clang/test/ExtractAPI/struct.c
+++ clang/test/ExtractAPI/struct.c
@@ -89,6 +89,10 @@
{
"kind": "identifier",
"spelling": "Color"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"docComment": {
Index: clang/test/ExtractAPI/enum.c
===
--- clang/test/ExtractAPI/enum.c
+++ clang/test/ExtractAPI/enum.c
@@ -153,6 +153,10 @@
"kind": "typeIdentifier",
"preciseIdentifier":
[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments
chaitanyav updated this revision to Diff 506308.
chaitanyav added a comment.
- Update reference output in underscored.c
- combine return and append semicolon fragment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146354/new/
https://reviews.llvm.org/D146354
Files:
clang/lib/ExtractAPI/DeclarationFragments.cpp
clang/test/ExtractAPI/underscored.c
Index: clang/test/ExtractAPI/underscored.c
===
--- clang/test/ExtractAPI/underscored.c
+++ clang/test/ExtractAPI/underscored.c
@@ -135,6 +135,10 @@
{
"kind": "identifier",
"spelling": "ExposedRecord"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -296,6 +300,10 @@
{
"kind": "identifier",
"spelling": "ExposedTypedef"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -356,6 +364,10 @@
{
"kind": "identifier",
"spelling": "ExposedTypedefToHidden"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/lib/ExtractAPI/DeclarationFragments.cpp
===
--- clang/lib/ExtractAPI/DeclarationFragments.cpp
+++ clang/lib/ExtractAPI/DeclarationFragments.cpp
@@ -470,8 +470,7 @@
getFragmentsForType(IntegerType, EnumDecl->getASTContext(), After))
.append(std::move(After));
- Fragments.append(";", DeclarationFragments::FragmentKind::Text);
- return Fragments;
+ return Fragments.append(";", DeclarationFragments::FragmentKind::Text);
}
DeclarationFragments
@@ -495,8 +494,7 @@
Fragments.appendSpace().append(
Record->getName(), DeclarationFragments::FragmentKind::Identifier);
- Fragments.append(";", DeclarationFragments::FragmentKind::Text);
- return Fragments;
+ return Fragments.append(";", DeclarationFragments::FragmentKind::Text);
}
DeclarationFragments
@@ -746,8 +744,7 @@
.appendSpace()
.append(Decl->getName(), DeclarationFragments::FragmentKind::Identifier);
- Fragments.append(";", DeclarationFragments::FragmentKind::Text);
- return Fragments;
+ return Fragments.append(";", DeclarationFragments::FragmentKind::Text);
}
template
Index: clang/test/ExtractAPI/underscored.c
===
--- clang/test/ExtractAPI/underscored.c
+++ clang/test/ExtractAPI/underscored.c
@@ -135,6 +135,10 @@
{
"kind": "identifier",
"spelling": "ExposedRecord"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -296,6 +300,10 @@
{
"kind": "identifier",
"spelling": "ExposedTypedef"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -356,6 +364,10 @@
{
"kind": "identifier",
"spelling": "ExposedTypedefToHidden"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/lib/ExtractAPI/DeclarationFragments.cpp
===
--- clang/lib/ExtractAPI/DeclarationFragments.cpp
+++ clang/lib/ExtractAPI/DeclarationFragments.cpp
@@ -470,8 +470,7 @@
getFragmentsForType(IntegerType, EnumDecl->getASTContext(), After))
.append(std::move(After));
- Fragments.append(";", DeclarationFragments::FragmentKind::Text);
- return Fragments;
+ return Fragments.append(";", DeclarationFragments::FragmentKind::Text);
}
DeclarationFragments
@@ -495,8 +494,7 @@
Fragments.appendSpace().append(
Record->getName(), DeclarationFragments::FragmentKind::Identifier);
- Fragments.append(";", DeclarationFragments::FragmentKind::Text);
- return Fragments;
+ return Fragments.append(";", DeclarationFragments::FragmentKind::Text);
}
DeclarationFragments
@@ -746,8 +744,7 @@
.appendSpace()
.append(Decl->getName(), DeclarationFragments::FragmentKind::Identifier);
- Fragments.append(";", DeclarationFragments::FragmentKind::Text);
- return Fragments;
+ return Fragments.append(";", DeclarationFragments::FragmentKind::Text);
}
template
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments
chaitanyav created this revision.
chaitanyav added a reviewer: dang.
Herald added a reviewer: ributzka.
Herald added a project: All.
chaitanyav requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://github.com/llvm/llvm-project/issues/61480
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D146354
Files:
clang/lib/ExtractAPI/DeclarationFragments.cpp
clang/test/ExtractAPI/anonymous_record_no_typedef.c
clang/test/ExtractAPI/enum.c
clang/test/ExtractAPI/struct.c
clang/test/ExtractAPI/typedef.c
clang/test/ExtractAPI/typedef_anonymous_record.c
clang/test/ExtractAPI/typedef_chain.c
Index: clang/test/ExtractAPI/typedef_chain.c
===
--- clang/test/ExtractAPI/typedef_chain.c
+++ clang/test/ExtractAPI/typedef_chain.c
@@ -68,6 +68,10 @@
{
"kind": "identifier",
"spelling": "MyInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -128,6 +132,10 @@
{
"kind": "identifier",
"spelling": "MyIntInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -188,6 +196,10 @@
{
"kind": "identifier",
"spelling": "MyIntIntInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/typedef_anonymous_record.c
===
--- clang/test/ExtractAPI/typedef_anonymous_record.c
+++ clang/test/ExtractAPI/typedef_anonymous_record.c
@@ -75,6 +75,10 @@
{
"kind": "identifier",
"spelling": "MyEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -170,6 +174,10 @@
{
"kind": "identifier",
"spelling": "MyStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -223,6 +231,10 @@
{
"kind": "identifier",
"spelling": "MyStructStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -283,6 +295,10 @@
{
"kind": "identifier",
"spelling": "MyStructStructStruct"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -343,6 +359,10 @@
{
"kind": "identifier",
"spelling": "MyEnumEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -403,6 +423,10 @@
{
"kind": "identifier",
"spelling": "MyEnumEnumEnum"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/typedef.c
===
--- clang/test/ExtractAPI/typedef.c
+++ clang/test/ExtractAPI/typedef.c
@@ -66,6 +66,10 @@
{
"kind": "identifier",
"spelling": "MyInt"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
Index: clang/test/ExtractAPI/struct.c
===
--- clang/test/ExtractAPI/struct.c
+++ clang/test/ExtractAPI/struct.c
@@ -89,6 +89,10 @@
{
"kind": "identifier",
"spelling": "Color"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"docComment": {
Index: clang/test/ExtractAPI/enum.c
===
--- clang/test/ExtractAPI/enum.c
+++ clang/test/ExtractAPI/enum.c
@@ -153,6 +153,10 @@
"kind": "typeIdentifier",
"preciseIdentifier": "c:i",
"spelling": "unsigned int"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"docComment": {
@@ -461,6 +465,10 @@
"kind": "typeIdentifier",
"preciseIdentifier": "c:c",
"spelling": "unsigned char"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -684,6 +692,10 @@
"kind": "typeIdentifier",
"preciseIdentifier": "c:i",
"spelling": "unsigned int"
+},
+{
+ "kind": "text",
+ "spelling": ";"
}
],
"identifier": {
@@ -772,6 +784,10 @@
"kind": "typeIdentifier",
"preciseIdentifier": "c:i",
"spelling": "unsigned int"
+},
+{
+
