[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG992cb98462ab: [clang][CodeGen] Break up TargetInfo.cpp [8/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 532358. barannikov88 added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 added a comment. @efriedma Thank you for all your reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 528209. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 523846. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 523240. barannikov88 added a comment. Undo remaining unintended formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 523236. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 523232. barannikov88 added a comment. Update BUILD.gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 523230. barannikov88 added a comment. Add a virtual destructor to DefaultABIInfo to pin the vtable to a cpp file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 523227. barannikov88 added a comment. Move complexTempStructure to its only user (PPC.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 523163. barannikov88 added a comment. Rebase & ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 added a comment. ping :) Any comments / questions / suggestions are welcome Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 521642. barannikov88 added a comment. Undo reformatting in arch-specific files This should help in resolving merge conflicts downstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 520781. barannikov88 added a comment. Undo unintended formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 520777. barannikov88 added a comment. Undo file renaming so that it does not look like the file was replaced Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/TargetInfo.h clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 520774. barannikov88 added a comment. Squash commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatted-files.txt clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/ABIInfoImpl.cpp clang/lib/CodeGen/ABIInfoImpl.h clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBlocks.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGException.cpp clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGExprAgg.cpp clang/lib/CodeGen/CGExprCXX.cpp clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib/CodeGen/CGOpenCLRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/CodeGen/CMakeLists.txt clang/lib/CodeGen/CodeGenFunction.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGenTypes.cpp clang/lib/CodeGen/ItaniumCXXABI.cpp clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/lib/CodeGen/SwiftCallingConv.cpp clang/lib/CodeGen/TargetCodeGenInfo.cpp clang/lib/CodeGen/TargetCodeGenInfo.h clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/TargetInfo.h clang/lib/CodeGen/Targets/AArch64.cpp clang/lib/CodeGen/Targets/AMDGPU.cpp clang/lib/CodeGen/Targets/ARC.cpp clang/lib/CodeGen/Targets/ARM.cpp clang/lib/CodeGen/Targets/AVR.cpp clang/lib/CodeGen/Targets/BPF.cpp clang/lib/CodeGen/Targets/CSKY.cpp clang/lib/CodeGen/Targets/Hexagon.cpp clang/lib/CodeGen/Targets/Lanai.cpp clang/lib/CodeGen/Targets/LoongArch.cpp clang/lib/CodeGen/Targets/M68k.cpp clang/lib/CodeGen/Targets/MSP430.cpp clang/lib/CodeGen/Targets/Mips.cpp clang/lib/CodeGen/Targets/NVPTX.cpp clang/lib/CodeGen/Targets/PNaCl.cpp clang/lib/CodeGen/Targets/PPC.cpp clang/lib/CodeGen/Targets/RISCV.cpp clang/lib/CodeGen/Targets/SPIR.cpp clang/lib/CodeGen/Targets/Sparc.cpp clang/lib/CodeGen/Targets/SystemZ.cpp clang/lib/CodeGen/Targets/TCE.cpp clang/lib/CodeGen/Targets/VE.cpp clang/lib/CodeGen/Targets/WebAssembly.cpp clang/lib/CodeGen/Targets/X86.cpp clang/lib/CodeGen/Targets/XCore.cpp clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp llvm/utils/gn/secondary/clang/lib/CodeGen/BUILD.gn ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]
barannikov88 updated this revision to Diff 520772.
barannikov88 retitled this revision from "[clang][CodeGen] Break up
TargetInfo.cpp [7/7]" to "[clang][CodeGen] Break up TargetInfo.cpp [8/8]".
barannikov88 edited the summary of this revision.
barannikov88 added a comment.
Rebase on top of the commit that introduced factory functions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148094/new/
https://reviews.llvm.org/D148094
Files:
clang/docs/tools/clang-formatted-files.txt
clang/lib/CodeGen/ABIInfoImpl.cpp
clang/lib/CodeGen/Targets/AArch64.cpp
clang/lib/CodeGen/Targets/AMDGPU.cpp
clang/lib/CodeGen/Targets/ARC.cpp
clang/lib/CodeGen/Targets/ARM.cpp
clang/lib/CodeGen/Targets/AVR.cpp
clang/lib/CodeGen/Targets/BPF.cpp
clang/lib/CodeGen/Targets/Hexagon.cpp
clang/lib/CodeGen/Targets/Lanai.cpp
clang/lib/CodeGen/Targets/MSP430.cpp
clang/lib/CodeGen/Targets/Mips.cpp
clang/lib/CodeGen/Targets/NVPTX.cpp
clang/lib/CodeGen/Targets/PNaCl.cpp
clang/lib/CodeGen/Targets/PPC.cpp
clang/lib/CodeGen/Targets/RISCV.cpp
clang/lib/CodeGen/Targets/SPIR.cpp
clang/lib/CodeGen/Targets/Sparc.cpp
clang/lib/CodeGen/Targets/SystemZ.cpp
clang/lib/CodeGen/Targets/TCE.cpp
clang/lib/CodeGen/Targets/X86.cpp
clang/lib/CodeGen/Targets/XCore.cpp
Index: clang/lib/CodeGen/Targets/XCore.cpp
===
--- clang/lib/CodeGen/Targets/XCore.cpp
+++ clang/lib/CodeGen/Targets/XCore.cpp
@@ -77,7 +77,7 @@
/// been exited too soon for the encoding to be correct for the member.
///
class TypeStringCache {
- enum Status {NonRecursive, Recursive, Incomplete, IncompleteUsed};
+ enum Status { NonRecursive, Recursive, Incomplete, IncompleteUsed };
struct Entry {
std::string Str; // The encoded TypeString for the type.
enum Status State; // Information about the encoding in 'Str'.
@@ -91,8 +91,7 @@
TypeStringCache() : IncompleteCount(0), IncompleteUsedCount(0) {}
void addIncomplete(const IdentifierInfo *ID, std::string StubEnc);
bool removeIncomplete(const IdentifierInfo *ID);
- void addIfComplete(const IdentifierInfo *ID, StringRef Str,
- bool IsRecursive);
+ void addIfComplete(const IdentifierInfo *ID, StringRef Str, bool IsRecursive);
StringRef lookupStr(const IdentifierInfo *ID);
};
@@ -101,11 +100,13 @@
class FieldEncoding {
bool HasName;
std::string Enc;
+
public:
FieldEncoding(bool b, SmallStringEnc ) : HasName(b), Enc(e.c_str()) {}
StringRef str() { return Enc; }
bool operator<(const FieldEncoding ) const {
-if (HasName != rhs.HasName) return HasName;
+if (HasName != rhs.HasName)
+ return HasName;
return Enc < rhs.Enc;
}
};
@@ -196,7 +197,7 @@
if (!ID)
return;
Entry = Map[ID];
- assert( (E.Str.empty() || E.State == Recursive) &&
+ assert((E.Str.empty() || E.State == Recursive) &&
"Incorrectly use of addIncomplete");
assert(!StubEnc.empty() && "Passing an empty string to addIncomplete()");
E.Swapped.swap(E.Str); // swap out the Recursive
@@ -215,8 +216,7 @@
auto I = Map.find(ID);
assert(I != Map.end() && "Entry not present");
Entry = I->second;
- assert( (E.State == Incomplete ||
- E.State == IncompleteUsed) &&
+ assert((E.State == Incomplete || E.State == IncompleteUsed) &&
"Entry must be an incomplete type");
bool IsRecursive = false;
if (E.State == IncompleteUsed) {
@@ -244,7 +244,7 @@
return; // No key or it is an incomplete sub-type so don't add.
Entry = Map[ID];
if (IsRecursive && !E.Str.empty()) {
-assert(E.State==Recursive && E.Str.size() == Str.size() &&
+assert(E.State == Recursive && E.Str.size() == Str.size() &&
"This is not the same Recursive entry");
// The parent container was not recursive after all, so we could have used
// this Recursive sub-member entry after all, but we assumed the worse when
@@ -253,7 +253,7 @@
}
assert(E.Str.empty() && "Entry already present");
E.Str = Str.str();
- E.State = IsRecursive? Recursive : NonRecursive;
+ E.State = IsRecursive ? Recursive : NonRecursive;
}
/// Return a cached TypeString encoding for the ID. If there isn't one, or we
@@ -261,13 +261,13 @@
/// encoding is Recursive, return an empty StringRef.
StringRef TypeStringCache::lookupStr(const IdentifierInfo *ID) {
if (!ID)
-return StringRef(); // We have no key.
+return StringRef(); // We have no key.
auto I = Map.find(ID);
if (I == Map.end())
-return StringRef(); // We have no encoding.
+return StringRef(); // We have no encoding.
Entry = I->second;
if (E.State == Recursive && IncompleteCount)
-return StringRef(); // We don't use Recursive encodings for member types.
+return StringRef(); // We don't use Recursive encodings for member types.
if (E.State == Incomplete) {
// The incomplete type is being used to break out of
