[PATCH] D151726: [clang] Remove unnecessary casts around Allocate function calls

[Balázs Benics via Phabricator via cfe-commits]

steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

Makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151726/new/

https://reviews.llvm.org/D151726

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151726: [clang] Remove unnecessary casts around Allocate function calls

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr created this revision.
gribozavr added a reviewer: NoQ.
Herald added subscribers: steakhal, martong.
Herald added a project: All.
gribozavr requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151726

Files:
  clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp
  clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
  clang/lib/StaticAnalyzer/Core/ProgramState.cpp
  clang/lib/StaticAnalyzer/Core/SymbolManager.cpp

Index: clang/lib/StaticAnalyzer/Core/SymbolManager.cpp
===
--- clang/lib/StaticAnalyzer/Core/SymbolManager.cpp
+++ clang/lib/StaticAnalyzer/Core/SymbolManager.cpp
@@ -170,7 +170,7 @@
   void *InsertPos;
   SymExpr *SD = DataSet.FindNodeOrInsertPos(profile, InsertPos);
   if (!SD) {
-SD = (SymExpr*) BPAlloc.Allocate();
+SD = BPAlloc.Allocate();
 new (SD) SymbolRegionValue(SymbolCounter, R);
 DataSet.InsertNode(SD, InsertPos);
 ++SymbolCounter;
@@ -189,7 +189,7 @@
   void *InsertPos;
   SymExpr *SD = DataSet.FindNodeOrInsertPos(profile, InsertPos);
   if (!SD) {
-SD = (SymExpr*) BPAlloc.Allocate();
+SD = BPAlloc.Allocate();
 new (SD) SymbolConjured(SymbolCounter, E, LCtx, T, Count, SymbolTag);
 DataSet.InsertNode(SD, InsertPos);
 ++SymbolCounter;
@@ -206,7 +206,7 @@
   void *InsertPos;
   SymExpr *SD = DataSet.FindNodeOrInsertPos(profile, InsertPos);
   if (!SD) {
-SD = (SymExpr*) BPAlloc.Allocate();
+SD = BPAlloc.Allocate();
 new (SD) SymbolDerived(SymbolCounter, parentSymbol, R);
 DataSet.InsertNode(SD, InsertPos);
 ++SymbolCounter;
@@ -222,7 +222,7 @@
   void *InsertPos;
   SymExpr *SD = DataSet.FindNodeOrInsertPos(profile, InsertPos);
   if (!SD) {
-SD = (SymExpr*) BPAlloc.Allocate();
+SD = BPAlloc.Allocate();
 new (SD) SymbolExtent(SymbolCounter, R);
 DataSet.InsertNode(SD, InsertPos);
 ++SymbolCounter;
@@ -240,7 +240,7 @@
   void *InsertPos;
   SymExpr *SD = DataSet.FindNodeOrInsertPos(profile, InsertPos);
   if (!SD) {
-SD = (SymExpr*) BPAlloc.Allocate();
+SD = BPAlloc.Allocate();
 new (SD) SymbolMetadata(SymbolCounter, R, S, T, LCtx, Count, SymbolTag);
 DataSet.InsertNode(SD, InsertPos);
 ++SymbolCounter;
@@ -257,7 +257,7 @@
   void *InsertPos;
   SymExpr *data = DataSet.FindNodeOrInsertPos(ID, InsertPos);
   if (!data) {
-data = (SymbolCast*) BPAlloc.Allocate();
+data = BPAlloc.Allocate();
 new (data) SymbolCast(Op, From, To);
 DataSet.InsertNode(data, InsertPos);
   }
@@ -275,7 +275,7 @@
   SymExpr *data = DataSet.FindNodeOrInsertPos(ID, InsertPos);
 
   if (!data) {
-data = (SymIntExpr*) BPAlloc.Allocate();
+data = BPAlloc.Allocate();
 new (data) SymIntExpr(lhs, op, v, t);
 DataSet.InsertNode(data, InsertPos);
   }
@@ -293,7 +293,7 @@
   SymExpr *data = DataSet.FindNodeOrInsertPos(ID, InsertPos);
 
   if (!data) {
-data = (IntSymExpr*) BPAlloc.Allocate();
+data = BPAlloc.Allocate();
 new (data) IntSymExpr(lhs, op, rhs, t);
 DataSet.InsertNode(data, InsertPos);
   }
@@ -311,7 +311,7 @@
   SymExpr *data = DataSet.FindNodeOrInsertPos(ID, InsertPos);
 
   if (!data) {
-data = (SymSymExpr*) BPAlloc.Allocate();
+data = BPAlloc.Allocate();
 new (data) SymSymExpr(lhs, op, rhs, t);
 DataSet.InsertNode(data, InsertPos);
   }
@@ -327,7 +327,7 @@
   void *InsertPos;
   SymExpr *data = DataSet.FindNodeOrInsertPos(ID, InsertPos);
   if (!data) {
-data = (UnarySymExpr *)BPAlloc.Allocate();
+data = BPAlloc.Allocate();
 new (data) UnarySymExpr(Operand, Opc, T);
 DataSet.InsertNode(data, InsertPos);
   }
Index: clang/lib/StaticAnalyzer/Core/ProgramState.cpp
===
--- clang/lib/StaticAnalyzer/Core/ProgramState.cpp
+++ clang/lib/StaticAnalyzer/Core/ProgramState.cpp
@@ -424,7 +424,7 @@
 freeStates.pop_back();
   }
   else {
-newState = (ProgramState*) Alloc.Allocate();
+newState = Alloc.Allocate();
   }
   new (newState) ProgramState(State);
   StateSet.InsertNode(newState, InsertPos);
Index: clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
===
--- clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
+++ clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
@@ -408,7 +408,7 @@
 }
 else {
   // Allocate a new node.
-  V = (NodeTy*) getAllocator().Allocate();
+  V = getAllocator().Allocate();
 }
 
 ++NumNodes;
@@ -432,7 +432,7 @@
 ProgramStateRef State,
 int64_t Id,
 bool IsSink) {
-  NodeTy *V = (NodeTy *) getAllocator().Allocate();
+  NodeTy *V = getAllocator().Allocate();
   new (V) NodeTy(L, State, Id, IsSink);
   return V;
 }
Index: