[PATCH] D152584: [clang-format] Remove redundant test case

[Paul Kirth via Phabricator via cfe-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa28a46665529: [clang-format] Remove redundant test case 
(authored by paulkirth).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152584/new/

https://reviews.llvm.org/D152584

Files:
  clang/test/Format/overlapping-lines.cpp


Index: clang/test/Format/overlapping-lines.cpp
===
--- clang/test/Format/overlapping-lines.cpp
+++ /dev/null
@@ -1,8 +0,0 @@
-// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format --style=Google 2>&1 | 
FileCheck %s 
-// CHECK-NOT: The new replacement overlaps with an existing replacement.
-
-#ifdef 
-
-
-#else 
-#endif 


Index: clang/test/Format/overlapping-lines.cpp
===
--- clang/test/Format/overlapping-lines.cpp
+++ /dev/null
@@ -1,8 +0,0 @@
-// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format --style=Google 2>&1 | FileCheck %s 
-// CHECK-NOT: The new replacement overlaps with an existing replacement.
-
-#ifdef 
-
-
-#else 
-#endif 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152584: [clang-format] Remove redundant test case

[Paul Kirth via Phabricator via cfe-commits]

paulkirth created this revision.
paulkirth added reviewers: owenpan, MyDeveloperDay.
Herald added projects: All, clang, clang-format.
Herald added a subscriber: cfe-commits.
Herald added reviewers: rymiel, HazardyKnusperkeks.
paulkirth requested review of this revision.
Herald added a comment.

NOTE: Clang-Format Team Automated Review Comment

It looks like your clang-format review does not contain any unit tests, please 
try to ensure all code changes have a unit test (unless this is an `NFC` or 
refactoring, adding documentation etc..)

Add your unit tests in `clang/unittests/Format` and you can build with `ninja 
FormatTests`.  We recommend using the `verifyFormat(xxx)` format of unit tests 
rather than `EXPECT_EQ` as this will ensure you change is tolerant to random 
whitespace changes (see FormatTest.cpp as an example)

For situations where your change is altering the TokenAnnotator.cpp which can 
happen if you are trying to improve the annotation phase to ensure we are 
correctly identifying the type of a token, please add a token annotator test in 
`TokenAnnotatorTest.cpp`


The test is now properly covered in unit tests, and shouldn't have been
added in the initial commit of D152473 .


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152584

Files:
  clang/test/Format/overlapping-lines.cpp


Index: clang/test/Format/overlapping-lines.cpp
===
--- clang/test/Format/overlapping-lines.cpp
+++ /dev/null
@@ -1,8 +0,0 @@
-// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format --style=Google 2>&1 | 
FileCheck %s 
-// CHECK-NOT: The new replacement overlaps with an existing replacement.
-
-#ifdef 
-
-
-#else 
-#endif 


Index: clang/test/Format/overlapping-lines.cpp
===
--- clang/test/Format/overlapping-lines.cpp
+++ /dev/null
@@ -1,8 +0,0 @@
-// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format --style=Google 2>&1 | FileCheck %s 
-// CHECK-NOT: The new replacement overlaps with an existing replacement.
-
-#ifdef 
-
-
-#else 
-#endif 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits