[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08f1aa87281f: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D153161?vs=532257&id=533648#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153161/new/ https://reviews.llvm.org/D153161 Files: clang/test/Driver/riscv-arch.c llvm/docs/RISCVUsage.rst llvm/lib/Support/RISCVISAInfo.cpp llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp llvm/lib/Target/RISCV/RISCVFeatures.td llvm/test/CodeGen/RISCV/add-before-shl.ll llvm/test/CodeGen/RISCV/attributes.ll llvm/test/CodeGen/RISCV/cm_mvas_mvsa.ll llvm/test/MC/RISCV/align.s llvm/test/MC/RISCV/compress-rv32d.s llvm/test/MC/RISCV/compress-rv32f.s llvm/test/MC/RISCV/rv32c-aliases-valid.s llvm/test/MC/RISCV/rv32c-invalid.s llvm/test/MC/RISCV/rv32c-valid.s llvm/test/MC/RISCV/rv32dc-valid.s llvm/test/MC/RISCV/rv32fc-valid.s llvm/test/MC/RISCV/rv32zcb-invalid.s llvm/test/MC/RISCV/rv32zcb-valid.s llvm/test/MC/RISCV/rv32zcmp-invalid.s llvm/test/MC/RISCV/rv32zcmp-valid.s llvm/test/MC/RISCV/rv32zcmt-invalid.s llvm/test/MC/RISCV/rv32zcmt-valid.s llvm/test/MC/RISCV/rv64c-aliases-valid.s llvm/test/MC/RISCV/rv64c-hints-valid.s llvm/test/MC/RISCV/rv64c-invalid.s llvm/test/MC/RISCV/rv64c-valid.s llvm/test/MC/RISCV/rv64dc-valid.s llvm/test/MC/RISCV/rv64zcb-valid.s llvm/test/MC/RISCV/rv64zcmp-invalid.s llvm/test/MC/RISCV/rv64zcmp-valid.s llvm/test/MC/RISCV/rvzcmt-user-csr-name.s Index: llvm/test/MC/RISCV/rvzcmt-user-csr-name.s === --- llvm/test/MC/RISCV/rvzcmt-user-csr-name.s +++ llvm/test/MC/RISCV/rvzcmt-user-csr-name.s @@ -1,13 +1,13 @@ -# RUN: llvm-mc %s -triple=riscv32 -riscv-no-aliases -mattr=+experimental-zcmt -show-encoding \ +# RUN: llvm-mc %s -triple=riscv32 -riscv-no-aliases -mattr=+zcmt -show-encoding \ # RUN: | FileCheck -check-prefixes=CHECK-INST,CHECK-ENC %s -# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+experimental-zcmt < %s \ -# RUN: | llvm-objdump -d --mattr=+experimental-zcmt - \ +# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+zcmt < %s \ +# RUN: | llvm-objdump -d --mattr=+zcmt - \ # RUN: | FileCheck -check-prefix=CHECK-INST-ALIAS %s # -# RUN: llvm-mc %s -triple=riscv64 -riscv-no-aliases -mattr=+experimental-zcmt -show-encoding \ +# RUN: llvm-mc %s -triple=riscv64 -riscv-no-aliases -mattr=+zcmt -show-encoding \ # RUN: | FileCheck -check-prefixes=CHECK-INST,CHECK-ENC %s -# RUN: llvm-mc -filetype=obj -triple riscv64 -mattr=+experimental-zcmt < %s \ -# RUN: | llvm-objdump -d --mattr=+experimental-zcmt - \ +# RUN: llvm-mc -filetype=obj -triple riscv64 -mattr=+zcmt < %s \ +# RUN: | llvm-objdump -d --mattr=+zcmt - \ # RUN: | FileCheck -check-prefix=CHECK-INST-ALIAS %s ## Index: llvm/test/MC/RISCV/rv64zcmp-valid.s === --- llvm/test/MC/RISCV/rv64zcmp-valid.s +++ llvm/test/MC/RISCV/rv64zcmp-valid.s @@ -1,7 +1,7 @@ -# RUN: llvm-mc %s -triple=riscv64 -mattr=experimental-zcmp -riscv-no-aliases -show-encoding \ +# RUN: llvm-mc %s -triple=riscv64 -mattr=zcmp -riscv-no-aliases -show-encoding \ # RUN: | FileCheck -check-prefixes=CHECK-ASM,CHECK-ASM-AND-OBJ %s -# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=experimental-zcmp < %s \ -# RUN: | llvm-objdump --mattr=-c,experimental-zcmp -M no-aliases -d -r - \ +# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=zcmp < %s \ +# RUN: | llvm-objdump --mattr=-c,zcmp -M no-aliases -d -r - \ # RUN: | FileCheck --check-prefixes=CHECK-ASM-AND-OBJ %s # CHECK-ASM-AND-OBJ: cm.mvsa01 s1, s0 Index: llvm/test/MC/RISCV/rv64zcmp-invalid.s === --- llvm/test/MC/RISCV/rv64zcmp-invalid.s +++ llvm/test/MC/RISCV/rv64zcmp-invalid.s @@ -1,4 +1,4 @@ -# RUN: not llvm-mc -triple=riscv64 -mattr=experimental-zcmp -riscv-no-aliases -show-encoding < %s 2>&1 \ +# RUN: not llvm-mc -triple=riscv64 -mattr=zcmp -riscv-no-aliases -show-encoding < %s 2>&1 \ # RUN: | FileCheck -check-prefixes=CHECK-ERROR %s # CHECK-ERROR: error: invalid operand for instruction Index: llvm/test/MC/RISCV/rv64zcb-valid.s === --- llvm/test/MC/RISCV/rv64zcb-valid.s +++ llvm/test/MC/RISCV/rv64zcb-valid.s @@ -1,13 +1,13 @@ -# RUN: llvm-mc %s -triple=riscv64 -mattr=+m,+zbb,+zba,+experimental-zcb -riscv-no-aliases -show-encoding \ +# RUN: llvm-mc %s -triple=riscv64 -mattr=+m,+zbb,+zba,+zcb -riscv-no-aliases -show-encoding \ # RUN: | FileCheck -check-prefixes=CHECK-ASM,CHECK-ASM-AND-OBJ %s -# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+m,+zbb,+zba,+experimental-zcb <
[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.
VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153161/new/ https://reviews.llvm.org/D153161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.
craig.topper added inline comments. Comment at: clang/test/Driver/riscv-arch.c:376 -// RUN: %clang --target=riscv32-unknown-elf -march=rv32izca -### %s \ +// RUN: %clang --target=riscv32-unknown-elf -march=rv32izfa -### %s \ // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-EXPERIMENTAL-NOFLAG %s VincentWu wrote: > does it should be `zca`? I changed it because this is the generic test for experimental extensions. It doesn’t matter which extension it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153161/new/ https://reviews.llvm.org/D153161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.
VincentWu added inline comments. Comment at: clang/test/Driver/riscv-arch.c:376 -// RUN: %clang --target=riscv32-unknown-elf -march=rv32izca -### %s \ +// RUN: %clang --target=riscv32-unknown-elf -march=rv32izfa -### %s \ // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-EXPERIMENTAL-NOFLAG %s does it should be `zca`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153161/new/ https://reviews.llvm.org/D153161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.
craig.topper created this revision. craig.topper added reviewers: reames, jrtc27, asb, VincentWu. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson. Herald added a project: All. craig.topper requested review of this revision. Herald added subscribers: cfe-commits, wangpc, eopXD, MaskRay. Herald added projects: clang, LLVM. According to https://wiki.riscv.org/display/HOME/Recently+Ratified+Extensions these were ratified in April 2023. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153161 Files: clang/test/Driver/riscv-arch.c llvm/docs/RISCVUsage.rst llvm/lib/Support/RISCVISAInfo.cpp llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp llvm/lib/Target/RISCV/RISCVFeatures.td llvm/test/CodeGen/RISCV/add-before-shl.ll llvm/test/CodeGen/RISCV/attributes.ll llvm/test/MC/RISCV/align.s llvm/test/MC/RISCV/compress-rv32d.s llvm/test/MC/RISCV/compress-rv32f.s llvm/test/MC/RISCV/rv32c-aliases-valid.s llvm/test/MC/RISCV/rv32c-invalid.s llvm/test/MC/RISCV/rv32c-valid.s llvm/test/MC/RISCV/rv32dc-valid.s llvm/test/MC/RISCV/rv32fc-valid.s llvm/test/MC/RISCV/rv32zcb-invalid.s llvm/test/MC/RISCV/rv32zcb-valid.s llvm/test/MC/RISCV/rv32zcmp-invalid.s llvm/test/MC/RISCV/rv32zcmp-valid.s llvm/test/MC/RISCV/rv32zcmt-invalid.s llvm/test/MC/RISCV/rv32zcmt-valid.s llvm/test/MC/RISCV/rv64c-aliases-valid.s llvm/test/MC/RISCV/rv64c-hints-valid.s llvm/test/MC/RISCV/rv64c-invalid.s llvm/test/MC/RISCV/rv64c-valid.s llvm/test/MC/RISCV/rv64dc-valid.s llvm/test/MC/RISCV/rv64zcb-valid.s llvm/test/MC/RISCV/rv64zcmp-invalid.s llvm/test/MC/RISCV/rv64zcmp-valid.s llvm/test/MC/RISCV/rvzcmt-user-csr-name.s Index: llvm/test/MC/RISCV/rvzcmt-user-csr-name.s === --- llvm/test/MC/RISCV/rvzcmt-user-csr-name.s +++ llvm/test/MC/RISCV/rvzcmt-user-csr-name.s @@ -1,13 +1,13 @@ -# RUN: llvm-mc %s -triple=riscv32 -riscv-no-aliases -mattr=+experimental-zcmt -show-encoding \ +# RUN: llvm-mc %s -triple=riscv32 -riscv-no-aliases -mattr=+zcmt -show-encoding \ # RUN: | FileCheck -check-prefixes=CHECK-INST,CHECK-ENC %s -# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+experimental-zcmt < %s \ -# RUN: | llvm-objdump -d --mattr=+experimental-zcmt - \ +# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+zcmt < %s \ +# RUN: | llvm-objdump -d --mattr=+zcmt - \ # RUN: | FileCheck -check-prefix=CHECK-INST-ALIAS %s # -# RUN: llvm-mc %s -triple=riscv64 -riscv-no-aliases -mattr=+experimental-zcmt -show-encoding \ +# RUN: llvm-mc %s -triple=riscv64 -riscv-no-aliases -mattr=+zcmt -show-encoding \ # RUN: | FileCheck -check-prefixes=CHECK-INST,CHECK-ENC %s -# RUN: llvm-mc -filetype=obj -triple riscv64 -mattr=+experimental-zcmt < %s \ -# RUN: | llvm-objdump -d --mattr=+experimental-zcmt - \ +# RUN: llvm-mc -filetype=obj -triple riscv64 -mattr=+zcmt < %s \ +# RUN: | llvm-objdump -d --mattr=+zcmt - \ # RUN: | FileCheck -check-prefix=CHECK-INST-ALIAS %s ## Index: llvm/test/MC/RISCV/rv64zcmp-valid.s === --- llvm/test/MC/RISCV/rv64zcmp-valid.s +++ llvm/test/MC/RISCV/rv64zcmp-valid.s @@ -1,7 +1,7 @@ -# RUN: llvm-mc %s -triple=riscv64 -mattr=experimental-zcmp -riscv-no-aliases -show-encoding \ +# RUN: llvm-mc %s -triple=riscv64 -mattr=zcmp -riscv-no-aliases -show-encoding \ # RUN: | FileCheck -check-prefixes=CHECK-ASM,CHECK-ASM-AND-OBJ %s -# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=experimental-zcmp < %s \ -# RUN: | llvm-objdump --mattr=-c,experimental-zcmp -M no-aliases -d -r - \ +# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=zcmp < %s \ +# RUN: | llvm-objdump --mattr=-c,zcmp -M no-aliases -d -r - \ # RUN: | FileCheck --check-prefixes=CHECK-ASM-AND-OBJ %s # CHECK-ASM-AND-OBJ: cm.mvsa01 s1, s0 Index: llvm/test/MC/RISCV/rv64zcmp-invalid.s === --- llvm/test/MC/RISCV/rv64zcmp-invalid.s +++ llvm/test/MC/RISCV/rv64zcmp-invalid.s @@ -1,4 +1,4 @@ -# RUN: not llvm-mc -triple=riscv64 -mattr=experimental-zcmp -riscv-no-aliases -show-encoding < %s 2>&1 \ +# RUN: not llvm-mc -triple=riscv64 -mattr=zcmp -riscv-no-aliases -show-encoding < %s 2>&1 \ # RUN: | FileCheck -check-prefixes=CHECK-ERROR %s # CHECK-ERROR: error: invalid operand for instruction Index: llvm/test/MC/RISCV/rv64zcb-valid.s === --- llvm/test/MC/RISCV/rv64zcb-valid.s +++ llvm/test/MC/RISCV/rv64zcb-valid.s @@ -1,13 +1,13 @@ -# RUN: llvm-mc %s -triple=riscv64 -mattr=+m,+zbb,+zba,+experimental-zcb -riscv-no-aliases -show-encodi