Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

[Evgeniy Stepanov via cfe-commits]

eugenis closed this revision.
eugenis added a comment.

r255166


Repository:
  rL LLVM

http://reviews.llvm.org/D15395



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

[Evgeniy Stepanov via cfe-commits]

eugenis added a comment.

Should be fine.


Repository:
  rL LLVM

http://reviews.llvm.org/D15395



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

[Eric Fiselier via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM. For clang this patch should have no functionality change because clang 
allows attributes to appear only in the declaration.  GCC however was 
previously ignoring the attributes and only now will it mark those functions as 
hidden. I don't think this will be an issue though. Do you agree?


Repository:
  rL LLVM

http://reviews.llvm.org/D15395



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15395: Add 3 more missing inline/visibility attributes

[Evgeniy Stepanov via cfe-commits]

eugenis created this revision.
eugenis added reviewers: EricWF, mclow.lists.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.

These are the cases when an out-of-class definition of a method is marked 
_LIBCPP_INLINE_VISIBILITY, but the in-class declaration is not. This will start 
failing when (or if) we switch to __attribute__((internal_linkage)).


Repository:
  rL LLVM

http://reviews.llvm.org/D15395

Files:
  include/bitset
  include/memory

Index: include/memory
===
--- include/memory
+++ include/memory
@@ -3995,6 +3995,7 @@
 is_convertible<_Yp*, element_type*>::value,
 shared_ptr&
 >::type
+_LIBCPP_INLINE_VISIBILITY
 operator=(auto_ptr<_Yp> __r);
 #endif
 template 
@@ -4008,6 +4009,7 @@
 _LIBCPP_INLINE_VISIBILITY
 operator=(unique_ptr<_Yp, _Dp>&& __r);
 #else  // _LIBCPP_HAS_NO_RVALUE_REFERENCES
+_LIBCPP_INLINE_VISIBILITY
 operator=(unique_ptr<_Yp, _Dp> __r);
 #endif
 
Index: include/bitset
===
--- include/bitset
+++ include/bitset
@@ -202,6 +202,7 @@
 private:
 #ifdef _LIBCPP_HAS_NO_CONSTEXPR
 void __init(unsigned long long __v, false_type) _NOEXCEPT;
+_LIBCPP_INLINE_VISIBILITY
 void __init(unsigned long long __v, true_type) _NOEXCEPT;
 #endif  // _LIBCPP_HAS_NO_CONSTEXPR
 unsigned long to_ulong(false_type) const;


Index: include/memory
===
--- include/memory
+++ include/memory
@@ -3995,6 +3995,7 @@
 is_convertible<_Yp*, element_type*>::value,
 shared_ptr&
 >::type
+_LIBCPP_INLINE_VISIBILITY
 operator=(auto_ptr<_Yp> __r);
 #endif
 template 
@@ -4008,6 +4009,7 @@
 _LIBCPP_INLINE_VISIBILITY
 operator=(unique_ptr<_Yp, _Dp>&& __r);
 #else  // _LIBCPP_HAS_NO_RVALUE_REFERENCES
+_LIBCPP_INLINE_VISIBILITY
 operator=(unique_ptr<_Yp, _Dp> __r);
 #endif
 
Index: include/bitset
===
--- include/bitset
+++ include/bitset
@@ -202,6 +202,7 @@
 private:
 #ifdef _LIBCPP_HAS_NO_CONSTEXPR
 void __init(unsigned long long __v, false_type) _NOEXCEPT;
+_LIBCPP_INLINE_VISIBILITY
 void __init(unsigned long long __v, true_type) _NOEXCEPT;
 #endif  // _LIBCPP_HAS_NO_CONSTEXPR
 unsigned long to_ulong(false_type) const;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits