[PATCH] D159051: [clang-format][NFC] Change EXPECT_EQ to verifyFormat or verifyNoChang

[Owen Pan via Phabricator via cfe-commits]

owenpan added a comment.

rG14feca5d14f1 
 concludes 
the cleanup of this gigantic file WRT `EXPECT_EQ`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159051/new/

https://reviews.llvm.org/D159051

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159051: [clang-format][NFC] Change EXPECT_EQ to verifyFormat or verifyNoChang

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.

+1 to this before we goto github


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159051/new/

https://reviews.llvm.org/D159051

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159051: [clang-format][NFC] Change EXPECT_EQ to verifyFormat or verifyNoChang

[Owen Pan via Phabricator via cfe-commits]

owenpan added inline comments.



Comment at: clang/unittests/Format/FormatTest.cpp:23933
   verifyNoChange("FOO(String-ized&Messy+But(: :Still)=Intentional);", Style);
-  EXPECT_EQ(
-  "FOO(String-ized&Messy+But\\(: :Still)=Intentional);",
-  format("FOO(String-ized&Messy+But\\(: :Still)=Intentional);", Style));
+  verifyFormat("FOO(String-ized&Messy+But\\(: :Still)=Intentional);", Style);
   verifyNoChange("FOO(String-ized&Messy+But,: :Still=Intentional);", Style);

To be consistent with the surrounding test cases. (Will fix it before landing.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159051/new/

https://reviews.llvm.org/D159051

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits