[PATCH] D16541: [libc++] Renable test/std/re/re.alg/re.alg.match/awk.pass.cpp

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists closed this revision.
mclow.lists added a comment.
Herald added a reviewer: EricWF.

For some reason, this test was not marked `// XFAIL gnu-linux` like all the 
other tests that use the `LOCALE_cs_CZ_ISO8859_2` locale.
In revision 352006, I uncommented this entire test, and added the XFAIL line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D16541/new/

https://reviews.llvm.org/D16541



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16541: [libc++] Renable test/std/re/re.alg/re.alg.match/awk.pass.cpp

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added a comment.

This bot is broken: 
http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/


https://reviews.llvm.org/D16541



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16541: [libc++] Renable test/std/re/re.alg/re.alg.match/awk.pass.cpp

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

committed as revision 299652


https://reviews.llvm.org/D16541



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16541: [libc++] Renable test/std/re/re.alg/re.alg.match/awk.pass.cpp

[Duncan P. N. Exon Smith via cfe-commits]

dexonsmith created this revision.
dexonsmith added a reviewer: mclow.lists.
dexonsmith added a subscriber: cfe-commits.

This entire test was effectively disabled in r187636 with no relevant
explanation.  The test passes for me just by removing the comment
markers.


http://reviews.llvm.org/D16541

Files:
  test/std/re/re.alg/re.alg.match/awk.pass.cpp

Index: test/std/re/re.alg/re.alg.match/awk.pass.cpp
===
--- test/std/re/re.alg/re.alg.match/awk.pass.cpp
+++ test/std/re/re.alg/re.alg.match/awk.pass.cpp
@@ -25,7 +25,7 @@
 
 int main()
 {
-/*{
+{
 std::cmatch m;
 const char s[] = "a";
 assert(std::regex_match(s, m, std::regex("a", 
std::regex_constants::awk)));
@@ -615,12 +615,12 @@
 assert(m.size() == 0);
 }
 std::locale::global(std::locale(LOCALE_cs_CZ_ISO8859_2));
-*/{
+{
 std::cmatch m;
 const char s[] = "m";
-   /* assert(std::regex_match(s, m,*/ std::regex("[a[=M=]z]"/*,
- 
std::regex_constants::awk*/);//));
-/*assert(m.size() == 1);
+assert(std::regex_match(s, m, std::regex("[a[=M=]z]",
+ std::regex_constants::awk)));
+assert(m.size() == 1);
 assert(!m.prefix().matched);
 assert(m.prefix().first == s);
 assert(m.prefix().second == m[0].first);
@@ -630,8 +630,8 @@
 assert(m.length(0) == std::char_traits::length(s));
 assert(m.position(0) == 0);
 assert(m.str(0) == s);
-*/}
-/*{
+}
+{
 std::cmatch m;
 const char s[] = "Ch";
 assert(std::regex_match(s, m, std::regex("[a[.ch.]z]",
@@ -1387,4 +1387,4 @@
 assert(m.position(0) == 0);
 assert(m.str(0) == s);
 }
-*/}
+}


Index: test/std/re/re.alg/re.alg.match/awk.pass.cpp
===
--- test/std/re/re.alg/re.alg.match/awk.pass.cpp
+++ test/std/re/re.alg/re.alg.match/awk.pass.cpp
@@ -25,7 +25,7 @@
 
 int main()
 {
-/*{
+{
 std::cmatch m;
 const char s[] = "a";
 assert(std::regex_match(s, m, std::regex("a", std::regex_constants::awk)));
@@ -615,12 +615,12 @@
 assert(m.size() == 0);
 }
 std::locale::global(std::locale(LOCALE_cs_CZ_ISO8859_2));
-*/{
+{
 std::cmatch m;
 const char s[] = "m";
-   /* assert(std::regex_match(s, m,*/ std::regex("[a[=M=]z]"/*,
- std::regex_constants::awk*/);//));
-/*assert(m.size() == 1);
+assert(std::regex_match(s, m, std::regex("[a[=M=]z]",
+ std::regex_constants::awk)));
+assert(m.size() == 1);
 assert(!m.prefix().matched);
 assert(m.prefix().first == s);
 assert(m.prefix().second == m[0].first);
@@ -630,8 +630,8 @@
 assert(m.length(0) == std::char_traits::length(s));
 assert(m.position(0) == 0);
 assert(m.str(0) == s);
-*/}
-/*{
+}
+{
 std::cmatch m;
 const char s[] = "Ch";
 assert(std::regex_match(s, m, std::regex("[a[.ch.]z]",
@@ -1387,4 +1387,4 @@
 assert(m.position(0) == 0);
 assert(m.str(0) == s);
 }
-*/}
+}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits