Re: [PATCH] D20614: Remove trailing spaces in x86 intrinsic headers

[michael zuckerman via cfe-commits]

m_zuckerman accepted this revision.
m_zuckerman added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rL LLVM

http://reviews.llvm.org/D20614



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20614: Remove trailing spaces in x86 intrinsic headers

[Katya Romanova via cfe-commits]

kromanova updated this revision to Diff 58472.
kromanova added a comment.

I attached full svn diff. Thank you Michael!

I had to clean up the trailing spaces from doxygen comments (because it mess up 
our post-processing scripts), but since I was doing it, I decided to clean up 
the rest of the header files in the intrinsics header directory. That's why 
some of the files that you recently touched were affected.


Repository:
  rL LLVM

http://reviews.llvm.org/D20614

Files:
  __wmmintrin_aes.h
  __wmmintrin_pclmul.h
  avx512fintrin.h
  avx512vldqintrin.h
  mwaitxintrin.h
  pmmintrin.h

Index: pmmintrin.h
===
--- pmmintrin.h
+++ pmmintrin.h
@@ -31,9 +31,9 @@
   __attribute__((__always_inline__, __nodebug__, __target__("sse3")))
 
 /// \brief Loads data from an unaligned memory location to elements in a 128-bit
-///vector. If the address of the data is not 16-byte aligned, the 
-///instruction may read two adjacent aligned blocks of memory to retrieve 
-///the requested data. 
+///vector. If the address of the data is not 16-byte aligned, the
+///instruction may read two adjacent aligned blocks of memory to retrieve
+///the requested data.
 ///
 /// \headerfile 
 ///
@@ -75,14 +75,14 @@
 /// This intrinsic corresponds to the \c VHADDPS instruction.
 ///
 /// \param __a
-///A 128-bit vector of [4 x float] containing one of the source operands. 
-///The horizontal sums of the values are stored in the lower bits of the 
+///A 128-bit vector of [4 x float] containing one of the source operands.
+///The horizontal sums of the values are stored in the lower bits of the
 ///destination.
 /// \param __b
-///A 128-bit vector of [4 x float] containing one of the source operands. 
-///The horizontal sums of the values are stored in the upper bits of the 
+///A 128-bit vector of [4 x float] containing one of the source operands.
+///The horizontal sums of the values are stored in the upper bits of the
 ///destination.
-/// \returns A 128-bit vector of [4 x float] containing the horizontal sums of 
+/// \returns A 128-bit vector of [4 x float] containing the horizontal sums of
 ///both operands.
 static __inline__ __m128 __DEFAULT_FN_ATTRS
 _mm_hadd_ps(__m128 __a, __m128 __b)
@@ -98,14 +98,14 @@
 /// This intrinsic corresponds to the \c VHSUBPS instruction.
 ///
 /// \param __a
-///A 128-bit vector of [4 x float] containing one of the source operands. 
-///The horizontal differences between the values are stored in the lower 
+///A 128-bit vector of [4 x float] containing one of the source operands.
+///The horizontal differences between the values are stored in the lower
 ///bits of the destination.
 /// \param __b
-///A 128-bit vector of [4 x float] containing one of the source operands. 
-///The horizontal differences between the values are stored in the upper 
+///A 128-bit vector of [4 x float] containing one of the source operands.
+///The horizontal differences between the values are stored in the upper
 ///bits of the destination.
-/// \returns A 128-bit vector of [4 x float] containing the horizontal 
+/// \returns A 128-bit vector of [4 x float] containing the horizontal
 ///differences of both operands.
 static __inline__ __m128 __DEFAULT_FN_ATTRS
 _mm_hsub_ps(__m128 __a, __m128 __b)
@@ -168,28 +168,28 @@
 ///A 128-bit vector of [2 x double] containing the left source operand.
 /// \param __b
 ///A 128-bit vector of [2 x double] containing the right source operand.
-/// \returns A 128-bit vector of [2 x double] containing the alternating sums 
+/// \returns A 128-bit vector of [2 x double] containing the alternating sums
 ///and differences of both operands.
 static __inline__ __m128d __DEFAULT_FN_ATTRS
 _mm_addsub_pd(__m128d __a, __m128d __b)
 {
   return __builtin_ia32_addsubpd((__v2df)__a, (__v2df)__b);
 }
 
-/// \brief Horizontally adds the pairs of values contained in two 128-bit 
+/// \brief Horizontally adds the pairs of values contained in two 128-bit
 ///vectors of [2 x double].
 ///
 /// \headerfile 
 ///
 /// This intrinsic corresponds to the \c VHADDPD instruction.
 ///
 /// \param __a
-///A 128-bit vector of [2 x double] containing one of the source operands. 
-///The horizontal sum of the values is stored in the lower bits of the 
+///A 128-bit vector of [2 x double] containing one of the source operands.
+///The horizontal sum of the values is stored in the lower bits of the
 ///destination.
 /// \param __b
-///A 128-bit vector of [2 x double] containing one of the source operands. 
-///The horizontal sum of the values is stored in the upper bits of the 
+///A 128-bit vector of [2 x double] containing one of the source operands.
+///The horizontal sum of the values is stored in the upper bits of the
 ///destination.
 /// \returns A 128-bit vector of [2 x double] 

Re: [PATCH] D20614: Remove trailing spaces in x86 intrinsic headers

[michael zuckerman via cfe-commits]

m_zuckerman added a comment.

First thanks

I don't see any problem with the patch. 
but if you can please add full svn diff from clang.

svn diff --diff-cmd=diff -x -U99  > x.patch


Repository:
  rL LLVM

http://reviews.llvm.org/D20614



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20614: Remove trailing spaces in x86 intrinsic headers

[Katya Romanova via cfe-commits]

kromanova created this revision.
kromanova added a reviewer: m_zuckerman.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.

Clean up: remove trailing spaces in x86 intrinsic headers.

Repository:
  rL LLVM

http://reviews.llvm.org/D20614

Files:
  __wmmintrin_aes.h
  __wmmintrin_pclmul.h
  avx512fintrin.h
  avx512vldqintrin.h
  mwaitxintrin.h
  pmmintrin.h

Index: pmmintrin.h
===
--- pmmintrin.h
+++ pmmintrin.h
@@ -31,9 +31,9 @@
   __attribute__((__always_inline__, __nodebug__, __target__("sse3")))
 
 /// \brief Loads data from an unaligned memory location to elements in a 128-bit
-///vector. If the address of the data is not 16-byte aligned, the 
-///instruction may read two adjacent aligned blocks of memory to retrieve 
-///the requested data. 
+///vector. If the address of the data is not 16-byte aligned, the
+///instruction may read two adjacent aligned blocks of memory to retrieve
+///the requested data.
 ///
 /// \headerfile 
 ///
@@ -75,14 +75,14 @@
 /// This intrinsic corresponds to the \c VHADDPS instruction.
 ///
 /// \param __a
-///A 128-bit vector of [4 x float] containing one of the source operands. 
-///The horizontal sums of the values are stored in the lower bits of the 
+///A 128-bit vector of [4 x float] containing one of the source operands.
+///The horizontal sums of the values are stored in the lower bits of the
 ///destination.
 /// \param __b
-///A 128-bit vector of [4 x float] containing one of the source operands. 
-///The horizontal sums of the values are stored in the upper bits of the 
+///A 128-bit vector of [4 x float] containing one of the source operands.
+///The horizontal sums of the values are stored in the upper bits of the
 ///destination.
-/// \returns A 128-bit vector of [4 x float] containing the horizontal sums of 
+/// \returns A 128-bit vector of [4 x float] containing the horizontal sums of
 ///both operands.
 static __inline__ __m128 __DEFAULT_FN_ATTRS
 _mm_hadd_ps(__m128 __a, __m128 __b)
@@ -98,14 +98,14 @@
 /// This intrinsic corresponds to the \c VHSUBPS instruction.
 ///
 /// \param __a
-///A 128-bit vector of [4 x float] containing one of the source operands. 
-///The horizontal differences between the values are stored in the lower 
+///A 128-bit vector of [4 x float] containing one of the source operands.
+///The horizontal differences between the values are stored in the lower
 ///bits of the destination.
 /// \param __b
-///A 128-bit vector of [4 x float] containing one of the source operands. 
-///The horizontal differences between the values are stored in the upper 
+///A 128-bit vector of [4 x float] containing one of the source operands.
+///The horizontal differences between the values are stored in the upper
 ///bits of the destination.
-/// \returns A 128-bit vector of [4 x float] containing the horizontal 
+/// \returns A 128-bit vector of [4 x float] containing the horizontal
 ///differences of both operands.
 static __inline__ __m128 __DEFAULT_FN_ATTRS
 _mm_hsub_ps(__m128 __a, __m128 __b)
@@ -168,7 +168,7 @@
 ///A 128-bit vector of [2 x double] containing the left source operand.
 /// \param __b
 ///A 128-bit vector of [2 x double] containing the right source operand.
-/// \returns A 128-bit vector of [2 x double] containing the alternating sums 
+/// \returns A 128-bit vector of [2 x double] containing the alternating sums
 ///and differences of both operands.
 static __inline__ __m128d __DEFAULT_FN_ATTRS
 _mm_addsub_pd(__m128d __a, __m128d __b)
@@ -176,7 +176,7 @@
   return __builtin_ia32_addsubpd((__v2df)__a, (__v2df)__b);
 }
 
-/// \brief Horizontally adds the pairs of values contained in two 128-bit 
+/// \brief Horizontally adds the pairs of values contained in two 128-bit
 ///vectors of [2 x double].
 ///
 /// \headerfile 
@@ -184,12 +184,12 @@
 /// This intrinsic corresponds to the \c VHADDPD instruction.
 ///
 /// \param __a
-///A 128-bit vector of [2 x double] containing one of the source operands. 
-///The horizontal sum of the values is stored in the lower bits of the 
+///A 128-bit vector of [2 x double] containing one of the source operands.
+///The horizontal sum of the values is stored in the lower bits of the
 ///destination.
 /// \param __b
-///A 128-bit vector of [2 x double] containing one of the source operands. 
-///The horizontal sum of the values is stored in the upper bits of the 
+///A 128-bit vector of [2 x double] containing one of the source operands.
+///The horizontal sum of the values is stored in the upper bits of the
 ///destination.
 /// \returns A 128-bit vector of [2 x double] containing the horizontal sums of
 ///both operands.
@@ -207,14 +207,14 @@
 /// This intrinsic corresponds to the \c VHSUBPD instruction.
 ///
 ///