Re: [PATCH] D20766: [clang-tidy] Fix script adding new clang-tidy check
This revision was automatically updated to reflect the committed changes. Closed by commit rL271207: [clang-tidy] Fix script adding new clang-tidy check (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D20766?vs=58878&id=58958#toc Repository: rL LLVM http://reviews.llvm.org/D20766 Files: clang-tools-extra/trunk/clang-tidy/add_new_check.py Index: clang-tools-extra/trunk/clang-tidy/add_new_check.py === --- clang-tools-extra/trunk/clang-tidy/add_new_check.py +++ clang-tools-extra/trunk/clang-tidy/add_new_check.py @@ -138,7 +138,7 @@ if (MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function '%%0' is insufficiently awesome") - << MatchedDecl->getName() + << MatchedDecl << FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_"); } Index: clang-tools-extra/trunk/clang-tidy/add_new_check.py === --- clang-tools-extra/trunk/clang-tidy/add_new_check.py +++ clang-tools-extra/trunk/clang-tidy/add_new_check.py @@ -138,7 +138,7 @@ if (MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function '%%0' is insufficiently awesome") - << MatchedDecl->getName() + << MatchedDecl << FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_"); } ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20766: [clang-tidy] Fix script adding new clang-tidy check
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D20766: [clang-tidy] Fix script adding new clang-tidy check
etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The `getName()` call is useless. It's better to show a better example as tutorial. http://reviews.llvm.org/D20766 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py === --- clang-tidy/add_new_check.py +++ clang-tidy/add_new_check.py @@ -138,7 +138,7 @@ if (MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function '%%0' is insufficiently awesome") - << MatchedDecl->getName() + << MatchedDecl << FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_"); } Index: clang-tidy/add_new_check.py === --- clang-tidy/add_new_check.py +++ clang-tidy/add_new_check.py @@ -138,7 +138,7 @@ if (MatchedDecl->getName().startswith("awesome_")) return; diag(MatchedDecl->getLocation(), "function '%%0' is insufficiently awesome") - << MatchedDecl->getName() + << MatchedDecl << FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_"); } ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits