Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
This revision was automatically updated to reflect the committed changes. Closed by commit rL271832: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and… (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20871?vs=59659=59665#toc Repository: rL LLVM http://reviews.llvm.org/D20871 Files: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/test/CodeGen/avx512f-builtins.c Index: cfe/trunk/test/CodeGen/avx512f-builtins.c === --- cfe/trunk/test/CodeGen/avx512f-builtins.c +++ cfe/trunk/test/CodeGen/avx512f-builtins.c @@ -7343,3 +7343,38 @@ return _mm_maskz_cvtsd_ss(__U, __A, __B); } + +__m512i test_mm512_setzero_epi32() +{ + // CHECK-LABEL: @test_mm512_setzero_epi32 + // CHECK: zeroinitializer + return _mm512_setzero_epi32(); +} + +__m512i test_mm512_setzero() +{ + // CHECK-LABEL: @test_mm512_setzero + // CHECK: zeroinitializer + return _mm512_setzero(); +} + +__m512i test_mm512_setzero_si512() +{ + // CHECK-LABEL: @test_mm512_setzero_si512 + // CHECK: zeroinitializer + return _mm512_setzero_si512(); +} + +__m512i test_mm512_setzero_ps() +{ + // CHECK-LABEL: @test_mm512_setzero_ps + // CHECK: zeroinitializer + return _mm512_setzero_ps(); +} + +__m512d test_mm512_setzero_pd() +{ + // CHECK-LABEL: @test_mm512_setzero_pd + // CHECK: zeroinitializer + return _mm512_setzero_pd(); +} \ No newline at end of file Index: cfe/trunk/lib/Headers/avx512fintrin.h === --- cfe/trunk/lib/Headers/avx512fintrin.h +++ cfe/trunk/lib/Headers/avx512fintrin.h @@ -170,6 +170,8 @@ return (__m512i)(__v8di){ 0, 0, 0, 0, 0, 0, 0, 0 }; } +#define _mm512_setzero_epi32 _mm512_setzero_si512 + static __inline__ __m512d __DEFAULT_FN_ATTRS _mm512_undefined_pd() { @@ -274,6 +276,9 @@ return (__m512){ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; } + +#define _mm512_setzero _mm512_setzero_ps + static __inline __m512d __DEFAULT_FN_ATTRS _mm512_setzero_pd(void) { Index: cfe/trunk/test/CodeGen/avx512f-builtins.c === --- cfe/trunk/test/CodeGen/avx512f-builtins.c +++ cfe/trunk/test/CodeGen/avx512f-builtins.c @@ -7343,3 +7343,38 @@ return _mm_maskz_cvtsd_ss(__U, __A, __B); } + +__m512i test_mm512_setzero_epi32() +{ + // CHECK-LABEL: @test_mm512_setzero_epi32 + // CHECK: zeroinitializer + return _mm512_setzero_epi32(); +} + +__m512i test_mm512_setzero() +{ + // CHECK-LABEL: @test_mm512_setzero + // CHECK: zeroinitializer + return _mm512_setzero(); +} + +__m512i test_mm512_setzero_si512() +{ + // CHECK-LABEL: @test_mm512_setzero_si512 + // CHECK: zeroinitializer + return _mm512_setzero_si512(); +} + +__m512i test_mm512_setzero_ps() +{ + // CHECK-LABEL: @test_mm512_setzero_ps + // CHECK: zeroinitializer + return _mm512_setzero_ps(); +} + +__m512d test_mm512_setzero_pd() +{ + // CHECK-LABEL: @test_mm512_setzero_pd + // CHECK: zeroinitializer + return _mm512_setzero_pd(); +} \ No newline at end of file Index: cfe/trunk/lib/Headers/avx512fintrin.h === --- cfe/trunk/lib/Headers/avx512fintrin.h +++ cfe/trunk/lib/Headers/avx512fintrin.h @@ -170,6 +170,8 @@ return (__m512i)(__v8di){ 0, 0, 0, 0, 0, 0, 0, 0 }; } +#define _mm512_setzero_epi32 _mm512_setzero_si512 + static __inline__ __m512d __DEFAULT_FN_ATTRS _mm512_undefined_pd() { @@ -274,6 +276,9 @@ return (__m512){ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; } + +#define _mm512_setzero _mm512_setzero_ps + static __inline __m512d __DEFAULT_FN_ATTRS _mm512_setzero_pd(void) { ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - add test_mm512_setzero_pd() as well if you can. Comment at: test/CodeGen/avx512f-builtins.c:7291 @@ +7290,3 @@ + +__m512i test_mm512_setzero_ps() +{ __m512d test_mm512_setzero_pd() ? http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
m_zuckerman updated this revision to Diff 59659. http://reviews.llvm.org/D20871 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c +++ test/CodeGen/avx512f-builtins.c @@ -7266,3 +7266,31 @@ return _mm512_setr_ps( __A, __B, __C, __D, __E, __F, __G, __H, __I, __J, __K, __L, __M, __N, __O, __P); } + +__m512i test_mm512_setzero_epi32() +{ + // CHECK-LABEL: @test_mm512_setzero_epi32 + // CHECK: zeroinitializer + return _mm512_setzero_epi32(); +} + +__m512i test_mm512_setzero() +{ + // CHECK-LABEL: @test_mm512_setzero + // CHECK: zeroinitializer + return _mm512_setzero(); +} + +__m512i test_mm512_setzero_si512() +{ + // CHECK-LABEL: @test_mm512_setzero_si512 + // CHECK: zeroinitializer + return _mm512_setzero_si512(); +} + +__m512i test_mm512_setzero_ps() +{ + // CHECK-LABEL: @test_mm512_setzero_ps + // CHECK: zeroinitializer + return _mm512_setzero_ps(); +} Index: lib/Headers/avx512fintrin.h === --- lib/Headers/avx512fintrin.h +++ lib/Headers/avx512fintrin.h @@ -164,6 +164,8 @@ return (__m512i)(__v8di){ 0, 0, 0, 0, 0, 0, 0, 0 }; } +#define _mm512_setzero_epi32 _mm512_setzero_si512 + static __inline__ __m512d __DEFAULT_FN_ATTRS _mm512_undefined_pd() { @@ -268,6 +270,9 @@ return (__m512){ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; } + +#define _mm512_setzero _mm512_setzero_ps + static __inline __m512d __DEFAULT_FN_ATTRS _mm512_setzero_pd(void) { Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c +++ test/CodeGen/avx512f-builtins.c @@ -7266,3 +7266,31 @@ return _mm512_setr_ps( __A, __B, __C, __D, __E, __F, __G, __H, __I, __J, __K, __L, __M, __N, __O, __P); } + +__m512i test_mm512_setzero_epi32() +{ + // CHECK-LABEL: @test_mm512_setzero_epi32 + // CHECK: zeroinitializer + return _mm512_setzero_epi32(); +} + +__m512i test_mm512_setzero() +{ + // CHECK-LABEL: @test_mm512_setzero + // CHECK: zeroinitializer + return _mm512_setzero(); +} + +__m512i test_mm512_setzero_si512() +{ + // CHECK-LABEL: @test_mm512_setzero_si512 + // CHECK: zeroinitializer + return _mm512_setzero_si512(); +} + +__m512i test_mm512_setzero_ps() +{ + // CHECK-LABEL: @test_mm512_setzero_ps + // CHECK: zeroinitializer + return _mm512_setzero_ps(); +} Index: lib/Headers/avx512fintrin.h === --- lib/Headers/avx512fintrin.h +++ lib/Headers/avx512fintrin.h @@ -164,6 +164,8 @@ return (__m512i)(__v8di){ 0, 0, 0, 0, 0, 0, 0, 0 }; } +#define _mm512_setzero_epi32 _mm512_setzero_si512 + static __inline__ __m512d __DEFAULT_FN_ATTRS _mm512_undefined_pd() { @@ -268,6 +270,9 @@ return (__m512){ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; } + +#define _mm512_setzero _mm512_setzero_ps + static __inline __m512d __DEFAULT_FN_ATTRS _mm512_setzero_pd(void) { ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
RKSimon added a comment. Can you add tests for the existing _mm512_setzero_* intrinsics as well please? http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
m_zuckerman updated this revision to Diff 59389. http://reviews.llvm.org/D20871 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c +++ test/CodeGen/avx512f-builtins.c @@ -7266,3 +7266,17 @@ return _mm512_setr_ps( __A, __B, __C, __D, __E, __F, __G, __H, __I, __J, __K, __L, __M, __N, __O, __P); } + +__m512i test_mm512_setzero_epi32() +{ + // CHECK-LABEL: @test_mm512_setzero_epi32 + // CHECK: zeroinitializer + return _mm512_setzero_epi32(); +} + +__m512i test_mm512_setzero() +{ + // CHECK-LABEL: @test_mm512_setzero + // CHECK: zeroinitializer + return _mm512_setzero(); +} \ No newline at end of file Index: lib/Headers/avx512fintrin.h === --- lib/Headers/avx512fintrin.h +++ lib/Headers/avx512fintrin.h @@ -164,6 +164,8 @@ return (__m512i)(__v8di){ 0, 0, 0, 0, 0, 0, 0, 0 }; } +#define _mm512_setzero_epi32 _mm512_setzero_si512 + static __inline__ __m512d __DEFAULT_FN_ATTRS _mm512_undefined_pd() { @@ -268,6 +270,9 @@ return (__m512){ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; } + +#define _mm512_setzero _mm512_setzero_ps + static __inline __m512d __DEFAULT_FN_ATTRS _mm512_setzero_pd(void) { Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c +++ test/CodeGen/avx512f-builtins.c @@ -7266,3 +7266,17 @@ return _mm512_setr_ps( __A, __B, __C, __D, __E, __F, __G, __H, __I, __J, __K, __L, __M, __N, __O, __P); } + +__m512i test_mm512_setzero_epi32() +{ + // CHECK-LABEL: @test_mm512_setzero_epi32 + // CHECK: zeroinitializer + return _mm512_setzero_epi32(); +} + +__m512i test_mm512_setzero() +{ + // CHECK-LABEL: @test_mm512_setzero + // CHECK: zeroinitializer + return _mm512_setzero(); +} \ No newline at end of file Index: lib/Headers/avx512fintrin.h === --- lib/Headers/avx512fintrin.h +++ lib/Headers/avx512fintrin.h @@ -164,6 +164,8 @@ return (__m512i)(__v8di){ 0, 0, 0, 0, 0, 0, 0, 0 }; } +#define _mm512_setzero_epi32 _mm512_setzero_si512 + static __inline__ __m512d __DEFAULT_FN_ATTRS _mm512_undefined_pd() { @@ -268,6 +270,9 @@ return (__m512){ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; } + +#define _mm512_setzero _mm512_setzero_ps + static __inline __m512d __DEFAULT_FN_ATTRS _mm512_setzero_pd(void) { ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
m_zuckerman added a comment. Yes its API http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
RKSimon added a subscriber: RKSimon. RKSimon added a comment. Tests? http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
delena added a comment. Why do you need them. Is it a part of API? http://reviews.llvm.org/D20871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32
m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20871 Files: lib/Headers/avx512fintrin.h Index: lib/Headers/avx512fintrin.h === --- lib/Headers/avx512fintrin.h +++ lib/Headers/avx512fintrin.h @@ -164,6 +164,8 @@ return (__m512i)(__v8di){ 0, 0, 0, 0, 0, 0, 0, 0 }; } +#define _mm512_setzero_epi32 _mm512_setzero_si512 + static __inline__ __m512d __DEFAULT_FN_ATTRS _mm512_undefined_pd() { @@ -268,6 +270,9 @@ return (__m512){ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; } + +#define _mm512_setzero _mm512_setzero_ps + static __inline __m512d __DEFAULT_FN_ATTRS _mm512_setzero_pd(void) { Index: lib/Headers/avx512fintrin.h === --- lib/Headers/avx512fintrin.h +++ lib/Headers/avx512fintrin.h @@ -164,6 +164,8 @@ return (__m512i)(__v8di){ 0, 0, 0, 0, 0, 0, 0, 0 }; } +#define _mm512_setzero_epi32 _mm512_setzero_si512 + static __inline__ __m512d __DEFAULT_FN_ATTRS _mm512_undefined_pd() { @@ -268,6 +270,9 @@ return (__m512){ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; } + +#define _mm512_setzero _mm512_setzero_ps + static __inline __m512d __DEFAULT_FN_ATTRS _mm512_setzero_pd(void) { ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits