Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called
This revision was automatically updated to reflect the committed changes. Closed by commit rL273193: [Sema] Only define function as move assignment when needed (authored by epilk). Changed prior to commit: http://reviews.llvm.org/D20923?vs=59409=61296#toc Repository: rL LLVM http://reviews.llvm.org/D20923 Files: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp Index: cfe/trunk/lib/Sema/SemaExpr.cpp === --- cfe/trunk/lib/Sema/SemaExpr.cpp +++ cfe/trunk/lib/Sema/SemaExpr.cpp @@ -13012,7 +13012,7 @@ if (MethodDecl->isDefaulted() && !MethodDecl->isDeleted()) { if (MethodDecl->isCopyAssignmentOperator()) DefineImplicitCopyAssignment(Loc, MethodDecl); -else +else if (MethodDecl->isMoveAssignmentOperator()) DefineImplicitMoveAssignment(Loc, MethodDecl); } } else if (isa(MethodDecl) && Index: cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp === --- cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp +++ cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp @@ -196,3 +196,15 @@ A a; B b; // expected-note {{here}} } + +namespace PR27941 { +struct ExplicitBool { + ExplicitBool =(bool) = default; // expected-error{{only special member functions may be defaulted}} + int member; +}; + +int fn() { + ExplicitBool t; + t = true; +} +} Index: cfe/trunk/lib/Sema/SemaExpr.cpp === --- cfe/trunk/lib/Sema/SemaExpr.cpp +++ cfe/trunk/lib/Sema/SemaExpr.cpp @@ -13012,7 +13012,7 @@ if (MethodDecl->isDefaulted() && !MethodDecl->isDeleted()) { if (MethodDecl->isCopyAssignmentOperator()) DefineImplicitCopyAssignment(Loc, MethodDecl); -else +else if (MethodDecl->isMoveAssignmentOperator()) DefineImplicitMoveAssignment(Loc, MethodDecl); } } else if (isa(MethodDecl) && Index: cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp === --- cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp +++ cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp @@ -196,3 +196,15 @@ A a; B b; // expected-note {{here}} } + +namespace PR27941 { +struct ExplicitBool { + ExplicitBool =(bool) = default; // expected-error{{only special member functions may be defaulted}} + int member; +}; + +int fn() { + ExplicitBool t; + t = true; +} +} ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called
manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman http://reviews.llvm.org/D20923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called
erik.pilkington added a comment. Ping! http://reviews.llvm.org/D20923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called
erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. erik.pilkington added a subscriber: cfe-commits. Previously, clang would crash on the test case below, because it misinterprets the `operator=(bool)` call as a move assignment operator. http://reviews.llvm.org/D20923 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/cxx0x-defaulted-functions.cpp Index: test/SemaCXX/cxx0x-defaulted-functions.cpp === --- test/SemaCXX/cxx0x-defaulted-functions.cpp +++ test/SemaCXX/cxx0x-defaulted-functions.cpp @@ -196,3 +196,15 @@ A a; B b; // expected-note {{here}} } + +namespace PR27941 { +struct ExplicitBool { + ExplicitBool =(bool) = default; // expected-error{{only special member functions may be defaulted}} + int member; +}; + +int fn() { + ExplicitBool t; + t = true; +} +} Index: lib/Sema/SemaExpr.cpp === --- lib/Sema/SemaExpr.cpp +++ lib/Sema/SemaExpr.cpp @@ -13005,7 +13005,7 @@ if (MethodDecl->isDefaulted() && !MethodDecl->isDeleted()) { if (MethodDecl->isCopyAssignmentOperator()) DefineImplicitCopyAssignment(Loc, MethodDecl); -else +else if (MethodDecl->isMoveAssignmentOperator()) DefineImplicitMoveAssignment(Loc, MethodDecl); } } else if (isa(MethodDecl) && Index: test/SemaCXX/cxx0x-defaulted-functions.cpp === --- test/SemaCXX/cxx0x-defaulted-functions.cpp +++ test/SemaCXX/cxx0x-defaulted-functions.cpp @@ -196,3 +196,15 @@ A a; B b; // expected-note {{here}} } + +namespace PR27941 { +struct ExplicitBool { + ExplicitBool =(bool) = default; // expected-error{{only special member functions may be defaulted}} + int member; +}; + +int fn() { + ExplicitBool t; + t = true; +} +} Index: lib/Sema/SemaExpr.cpp === --- lib/Sema/SemaExpr.cpp +++ lib/Sema/SemaExpr.cpp @@ -13005,7 +13005,7 @@ if (MethodDecl->isDefaulted() && !MethodDecl->isDeleted()) { if (MethodDecl->isCopyAssignmentOperator()) DefineImplicitCopyAssignment(Loc, MethodDecl); -else +else if (MethodDecl->isMoveAssignmentOperator()) DefineImplicitMoveAssignment(Loc, MethodDecl); } } else if (isa(MethodDecl) && ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits