Re: [PATCH] D20939: Update for DiagnosticInfoStackSize changes

[Matt Arsenault via cfe-commits]

arsenm accepted this revision.
arsenm added a reviewer: arsenm.
arsenm added a comment.
This revision is now accepted and ready to land.

r273178


http://reviews.llvm.org/D20939



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20939: Update for DiagnosticInfoStackSize changes

[Matt Arsenault via cfe-commits]

arsenm created this revision.
arsenm added a subscriber: cfe-commits.

http://reviews.llvm.org/D20939

Files:
  lib/CodeGen/CodeGenAction.cpp
  test/Misc/backend-resource-limit-diagnostics.cl

Index: test/Misc/backend-resource-limit-diagnostics.cl
===
--- /dev/null
+++ test/Misc/backend-resource-limit-diagnostics.cl
@@ -0,0 +1,10 @@
+// REQUIRES: amdgpu-registered-target
+// RUN: not %clang_cc1 -emit-codegen-only -triple=amdgcn-- %s 2>&1 | FileCheck 
%s
+
+
+// CHECK: error: local memory limit exceeded (48) in use_huge_lds
+kernel void use_huge_lds()
+{
+volatile local int huge[12];
+huge[0] = 2;
+}
Index: lib/CodeGen/CodeGenAction.cpp
===
--- lib/CodeGen/CodeGenAction.cpp
+++ lib/CodeGen/CodeGenAction.cpp
@@ -415,9 +415,10 @@
 return false;
 
   if (const Decl *ND = Gen->GetDeclForMangledName(D.getFunction().getName())) {
+// FIXME: Shouldn't need to truncate to uint32_t
 Diags.Report(ND->getASTContext().getFullLoc(ND->getLocation()),
  diag::warn_fe_frame_larger_than)
-<< D.getStackSize() << Decl::castToDeclContext(ND);
+  << static_cast(D.getStackSize()) << 
Decl::castToDeclContext(ND);
 return true;
   }
 


Index: test/Misc/backend-resource-limit-diagnostics.cl
===
--- /dev/null
+++ test/Misc/backend-resource-limit-diagnostics.cl
@@ -0,0 +1,10 @@
+// REQUIRES: amdgpu-registered-target
+// RUN: not %clang_cc1 -emit-codegen-only -triple=amdgcn-- %s 2>&1 | FileCheck %s
+
+
+// CHECK: error: local memory limit exceeded (48) in use_huge_lds
+kernel void use_huge_lds()
+{
+volatile local int huge[12];
+huge[0] = 2;
+}
Index: lib/CodeGen/CodeGenAction.cpp
===
--- lib/CodeGen/CodeGenAction.cpp
+++ lib/CodeGen/CodeGenAction.cpp
@@ -415,9 +415,10 @@
 return false;
 
   if (const Decl *ND = Gen->GetDeclForMangledName(D.getFunction().getName())) {
+// FIXME: Shouldn't need to truncate to uint32_t
 Diags.Report(ND->getASTContext().getFullLoc(ND->getLocation()),
  diag::warn_fe_frame_larger_than)
-<< D.getStackSize() << Decl::castToDeclContext(ND);
+  << static_cast(D.getStackSize()) << Decl::castToDeclContext(ND);
 return true;
   }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits