Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma
kkwli0 added a comment. I update the test cases in https://reviews.llvm.org/D22417. Repository: rL LLVM https://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma
I will take a look and put up a patch for it. Kelvin On Fri, Jul 15, 2016 at 2:46 AM, Alexey Bataev wrote: > Kelvin, > Please look at these messages and fix the tests. Or tell me and I will > fix them > > Best regards, > Alexey Bataev > = > Software Engineer > Intel Compiler Team > > 15.07.2016 9:23, Robinson, Paul пишет: > > > >> -Original Message- > >> From: Alexey Bataev [mailto:a.bat...@hotmail.com] > >> Sent: Thursday, July 14, 2016 7:51 PM > >> To: reviews+d22096+public+4c00789034d62...@reviews.llvm.org > >> Cc: cfe-commits@lists.llvm.org; kkw...@gmail.com; cber...@us.ibm.com; > >> sfan...@us.ibm.com; hfin...@anl.gov; acja...@us.ibm.com; Robinson, Paul > >> Subject: Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target > >> parallel for simd' pragma > >> > >> Hi Paul, > >> Could you provide a little bit more info about diagnostic you see? Maybe > >> the tests just need to be fixed > > That would be fine too. Log of the two failing tests attached. > > Thanks, > > --paulr > > > >> Best regards, > >> Alexey Bataev > >> = > >> Software Engineer > >> Intel Compiler Team > >> > >> 15.07.2016 2:09, Paul Robinson пишет: > >>> probinson added a subscriber: probinson. > >>> probinson added a comment. > >>> > >>> I'm seeing a different set of diagnostics in two of these tests, > because > >> we default to C+11, which makes them fail for us. Ideally you'd > >> conditionalize the tests on the value of `__cplusplus` (like Charles Li > >> has been doing for a whole lot of the Clang tests). If that's > >> inconvenient for you right now, would you mind if I added `-std=c++03` > to > >> the following tests? It's just these two that need it: > >>> target_parallel_for_simd_collapse_messages.cpp > >>> target_parallel_for_simd_ordered_messages.cpp > >>> > >>> > >>> Repository: > >>> rL LLVM > >>> > >>> https://reviews.llvm.org/D22096 > >>> > >>> > >>> > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma
Kelvin, Please look at these messages and fix the tests. Or tell me and I will fix them Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 15.07.2016 9:23, Robinson, Paul пишет: > >> -Original Message- >> From: Alexey Bataev [mailto:a.bat...@hotmail.com] >> Sent: Thursday, July 14, 2016 7:51 PM >> To: reviews+d22096+public+4c00789034d62...@reviews.llvm.org >> Cc: cfe-commits@lists.llvm.org; kkw...@gmail.com; cber...@us.ibm.com; >> sfan...@us.ibm.com; hfin...@anl.gov; acja...@us.ibm.com; Robinson, Paul >> Subject: Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target >> parallel for simd' pragma >> >> Hi Paul, >> Could you provide a little bit more info about diagnostic you see? Maybe >> the tests just need to be fixed > That would be fine too. Log of the two failing tests attached. > Thanks, > --paulr > >> Best regards, >> Alexey Bataev >> = >> Software Engineer >> Intel Compiler Team >> >> 15.07.2016 2:09, Paul Robinson пишет: >>> probinson added a subscriber: probinson. >>> probinson added a comment. >>> >>> I'm seeing a different set of diagnostics in two of these tests, because >> we default to C+11, which makes them fail for us. Ideally you'd >> conditionalize the tests on the value of `__cplusplus` (like Charles Li >> has been doing for a whole lot of the Clang tests). If that's >> inconvenient for you right now, would you mind if I added `-std=c++03` to >> the following tests? It's just these two that need it: >>> target_parallel_for_simd_collapse_messages.cpp >>> target_parallel_for_simd_ordered_messages.cpp >>> >>> >>> Repository: >>> rL LLVM >>> >>> https://reviews.llvm.org/D22096 >>> >>> >>> ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RE: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma
> -Original Message- > From: Alexey Bataev [mailto:a.bat...@hotmail.com] > Sent: Thursday, July 14, 2016 7:51 PM > To: reviews+d22096+public+4c00789034d62...@reviews.llvm.org > Cc: cfe-commits@lists.llvm.org; kkw...@gmail.com; cber...@us.ibm.com; > sfan...@us.ibm.com; hfin...@anl.gov; acja...@us.ibm.com; Robinson, Paul > Subject: Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target > parallel for simd' pragma > > Hi Paul, > Could you provide a little bit more info about diagnostic you see? Maybe > the tests just need to be fixed That would be fine too. Log of the two failing tests attached. Thanks, --paulr > > Best regards, > Alexey Bataev > = > Software Engineer > Intel Compiler Team > > 15.07.2016 2:09, Paul Robinson пишет: > > probinson added a subscriber: probinson. > > probinson added a comment. > > > > I'm seeing a different set of diagnostics in two of these tests, because > we default to C+11, which makes them fail for us. Ideally you'd > conditionalize the tests on the value of `__cplusplus` (like Charles Li > has been doing for a whole lot of the Clang tests). If that's > inconvenient for you right now, would you mind if I added `-std=c++03` to > the following tests? It's just these two that need it: > > > > target_parallel_for_simd_collapse_messages.cpp > > target_parallel_for_simd_ordered_messages.cpp > > > > > > Repository: > >rL LLVM > > > > https://reviews.llvm.org/D22096 > > > > > > FAIL: Clang :: OpenMP/target_parallel_for_simd_collapse_messages.cpp (307 of 430) TEST 'Clang :: OpenMP/target_parallel_for_simd_collapse_messages.cpp' FAILED Script: -- /home/probinson/ssd/projects/staging/o/build-gcc-ps4-sce-staging-test-ninja/./bin/clang -cc1 -internal-isystem /home/probinson/ssd/projects/staging/o/build-gcc-ps4-sce-staging-test-ninja/bin/../lib/clang/include -nostdsysteminc -verify -fopenmp /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp -- Exit Code: 1 Command Output (stderr): -- error: 'error' diagnostics expected but not seen: File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 40 (directive at /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp:39): expression is not an integral constant expression File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 40 (directive at /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp:39): expression is not an integral constant expression File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 72 (directive at /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp:71): expression is not an integral constant expression error: 'error' diagnostics seen but not expected: File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 72: integral constant expression must have integral or unscoped enumeration type, not 'char *' File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 40: integral constant expression must have integral or unscoped enumeration type, not 'char *' File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 40: integral constant expression must have integral or unscoped enumeration type, not 'char *' error: 'note' diagnostics seen but not expected: File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 62: non-constexpr function 'foobool' cannot be used in a constant expression File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 6: declared here File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 67: non-constexpr function 'foobool' cannot be used in a constant expression File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 6: declared here File /home/probinson/ssd/projects/staging/o/llvm/tools/clang/test/OpenMP/target_parallel_for_simd_collapse_messages.cpp Line 3
Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma
Hi Paul, Could you provide a little bit more info about diagnostic you see? Maybe the tests just need to be fixed Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 15.07.2016 2:09, Paul Robinson пишет: > probinson added a subscriber: probinson. > probinson added a comment. > > I'm seeing a different set of diagnostics in two of these tests, because we > default to C+11, which makes them fail for us. Ideally you'd conditionalize > the tests on the value of `__cplusplus` (like Charles Li has been doing for a > whole lot of the Clang tests). If that's inconvenient for you right now, > would you mind if I added `-std=c++03` to the following tests? It's just > these two that need it: > > target_parallel_for_simd_collapse_messages.cpp > target_parallel_for_simd_ordered_messages.cpp > > > Repository: >rL LLVM > > https://reviews.llvm.org/D22096 > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma
probinson added a subscriber: probinson. probinson added a comment. I'm seeing a different set of diagnostics in two of these tests, because we default to C+11, which makes them fail for us. Ideally you'd conditionalize the tests on the value of `__cplusplus` (like Charles Li has been doing for a whole lot of the Clang tests). If that's inconvenient for you right now, would you mind if I added `-std=c++03` to the following tests? It's just these two that need it: target_parallel_for_simd_collapse_messages.cpp target_parallel_for_simd_ordered_messages.cpp Repository: rL LLVM https://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
