[PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection
echristo accepted this revision. echristo added a comment. Thanks for explaining all of this and going through it Dehao. LGTM. -eric https://reviews.llvm.org/D25435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection
I started the llvm-dev thread for the instruction location tradeoffs (removing the location from instructions to improve profiling support - possibly at the cost of other debug info consumers). The motivation for this flag is different - for added functionality that's generally (imho/based on conversations so far) pretty well justified for profile needs (the need for function start lines to make profiles somewhat resilient to unrelated code changes, etc - as mentioned in the review/patch description). On Mon, Jan 9, 2017 at 11:51 AM Eric Christopher via Phabricator < revi...@reviews.llvm.org> wrote: > echristo added a comment. > > I don't think this ever was hashed out in the llvm-dev thread? > > > https://reviews.llvm.org/D25435 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection
echristo added a comment. I don't think this ever was hashed out in the llvm-dev thread? https://reviews.llvm.org/D25435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection
danielcdh added a comment. Thanks David for the reivew. Could you also help take a look at https://reviews.llvm.org/D25434, as it depends on the TargetOptions.h change in that patch. Thanks, Dehao https://reviews.llvm.org/D25435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
