[PATCH] D25700: [Driver] Use stem rather than filename for executable name

[Petr Hosek via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL284430: [Driver] Use stem rather than filename for 
executable name (authored by phosek).

Changed prior to commit:
  https://reviews.llvm.org/D25700?vs=74905=74917#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D25700

Files:
  cfe/trunk/lib/Driver/Tools.cpp


Index: cfe/trunk/lib/Driver/Tools.cpp
===
--- cfe/trunk/lib/Driver/Tools.cpp
+++ cfe/trunk/lib/Driver/Tools.cpp
@@ -10060,7 +10060,7 @@
   Args.ClaimAllArgs(options::OPT_w);
 
   const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
-  if (llvm::sys::path::filename(Exec).equals_lower("lld")) {
+  if (llvm::sys::path::stem(Exec).equals_lower("lld")) {
 CmdArgs.push_back("-flavor");
 CmdArgs.push_back("gnu");
   }


Index: cfe/trunk/lib/Driver/Tools.cpp
===
--- cfe/trunk/lib/Driver/Tools.cpp
+++ cfe/trunk/lib/Driver/Tools.cpp
@@ -10060,7 +10060,7 @@
   Args.ClaimAllArgs(options::OPT_w);
 
   const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
-  if (llvm::sys::path::filename(Exec).equals_lower("lld")) {
+  if (llvm::sys::path::stem(Exec).equals_lower("lld")) {
 CmdArgs.push_back("-flavor");
 CmdArgs.push_back("gnu");
   }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

[Bruno Cardoso Lopes via cfe-commits]

bruno accepted this revision.
bruno added a comment.

Ok, thanks!  LGTM


Repository:
  rL LLVM

https://reviews.llvm.org/D25700



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

[Davide Italiano via cfe-commits]

davide added a comment.

And yes, if you can add a test case that will be great (there's no bot that 
caught this upstream) but one of our internal bots did.


Repository:
  rL LLVM

https://reviews.llvm.org/D25700



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

[Bruno Cardoso Lopes via cfe-commits]

bruno added a reviewer: bruno.
bruno added a comment.

Can you add a testcase for that?


Repository:
  rL LLVM

https://reviews.llvm.org/D25700



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

[Davide Italiano via cfe-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

Was going to commit the same. Thanks. LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D25700



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25700: [Driver] Use stem rather than filename for executable name

[Petr Hosek via cfe-commits]

phosek created this revision.
phosek added a reviewer: davide.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.

When comparing the linker name in Fuchsia driver, use stem rather than filename 
to get the name of the linker becase on Windows, the filename will have an 
extension.


Repository:
  rL LLVM

https://reviews.llvm.org/D25700

Files:
  lib/Driver/Tools.cpp


Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tools.cpp
@@ -10060,7 +10060,7 @@
   Args.ClaimAllArgs(options::OPT_w);
 
   const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
-  if (llvm::sys::path::filename(Exec).equals_lower("lld")) {
+  if (llvm::sys::path::stem(Exec).equals_lower("lld")) {
 CmdArgs.push_back("-flavor");
 CmdArgs.push_back("gnu");
   }


Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tools.cpp
@@ -10060,7 +10060,7 @@
   Args.ClaimAllArgs(options::OPT_w);
 
   const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
-  if (llvm::sys::path::filename(Exec).equals_lower("lld")) {
+  if (llvm::sys::path::stem(Exec).equals_lower("lld")) {
 CmdArgs.push_back("-flavor");
 CmdArgs.push_back("gnu");
   }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits