[PATCH] D28146: [compiler-rt] [test] [builtins] Remove obsolete/UB tests in __fixuns?fdi based

[Michał Górny via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL292257: [test] [builtins] Remove obsolete/UB tests in 
__fixuns?fdi based (authored by mgorny).

Changed prior to commit:
  https://reviews.llvm.org/D28146?vs=82625&id=84737#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D28146

Files:
  compiler-rt/trunk/test/builtins/Unit/fixunsdfdi_test.c
  compiler-rt/trunk/test/builtins/Unit/fixunssfdi_test.c


Index: compiler-rt/trunk/test/builtins/Unit/fixunsdfdi_test.c
===
--- compiler-rt/trunk/test/builtins/Unit/fixunsdfdi_test.c
+++ compiler-rt/trunk/test/builtins/Unit/fixunsdfdi_test.c
@@ -95,9 +95,6 @@
 if (test__fixunsdfdi(0x1.Ep+62, 0x7800LL))
 return 1;
 
-if (test__fixunsdfdi(0x1.p+64, 0xLL))
-return 1;
-
 #if !TARGET_LIBGCC
 if (test__fixunsdfdi(-0x1.Fp+62, 0))
 return 1;
Index: compiler-rt/trunk/test/builtins/Unit/fixunssfdi_test.c
===
--- compiler-rt/trunk/test/builtins/Unit/fixunssfdi_test.c
+++ compiler-rt/trunk/test/builtins/Unit/fixunssfdi_test.c
@@ -79,8 +79,6 @@
 return 1;
 if (test__fixunssfdi(0x1.00p+63F, 0x8000LL))
 return 1;
-if (test__fixunssfdi(0x1.00p+64F, 0xLL))
-return 1;
 if (test__fixunssfdi(0x1.FEp+62F, 0x7F80LL))
 return 1;
 if (test__fixunssfdi(0x1.FCp+62F, 0x7F00LL))


Index: compiler-rt/trunk/test/builtins/Unit/fixunsdfdi_test.c
===
--- compiler-rt/trunk/test/builtins/Unit/fixunsdfdi_test.c
+++ compiler-rt/trunk/test/builtins/Unit/fixunsdfdi_test.c
@@ -95,9 +95,6 @@
 if (test__fixunsdfdi(0x1.Ep+62, 0x7800LL))
 return 1;
 
-if (test__fixunsdfdi(0x1.p+64, 0xLL))
-return 1;
-
 #if !TARGET_LIBGCC
 if (test__fixunsdfdi(-0x1.Fp+62, 0))
 return 1;
Index: compiler-rt/trunk/test/builtins/Unit/fixunssfdi_test.c
===
--- compiler-rt/trunk/test/builtins/Unit/fixunssfdi_test.c
+++ compiler-rt/trunk/test/builtins/Unit/fixunssfdi_test.c
@@ -79,8 +79,6 @@
 return 1;
 if (test__fixunssfdi(0x1.00p+63F, 0x8000LL))
 return 1;
-if (test__fixunssfdi(0x1.00p+64F, 0xLL))
-return 1;
 if (test__fixunssfdi(0x1.FEp+62F, 0x7F80LL))
 return 1;
 if (test__fixunssfdi(0x1.FCp+62F, 0x7F00LL))
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28146: [compiler-rt] [test] [builtins] Remove obsolete/UB tests in __fixuns?fdi based

[Derek Schuff via Phabricator via cfe-commits]

dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

I don't have any particular ownership or knowledge of this file, but the change 
still LGTM


https://reviews.llvm.org/D28146



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28146: [compiler-rt] [test] [builtins] Remove obsolete/UB tests in __fixuns?fdi based

[Michał Górny via Phabricator via cfe-commits]

mgorny created this revision.
mgorny added reviewers: ddunbar, sdmitrouk, dschuff.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, dberris.

Remove the failing tests for __fixunssfdi() and __fixunsdfdi() that
relied on undefined (and most likely obsolete in terms of compiler-rt
implementation behavior).

Both tests presumed that 0x1.p+64 would be converted to
0xLL, that is the largest value in uint64 range.
However, the C/C++ standards do not specify the behavior for converting
a floating-point value to an integer of smaller range, and in this case
both libgcc and compiler-rt implementations return 0 instead.

Since the current behavior is correct with regards to standards
and there is no good way of expressing 0xLL in single-
or double-precision float, I've removed the failing test altogether.


https://reviews.llvm.org/D28146

Files:
  test/builtins/Unit/fixunsdfdi_test.c
  test/builtins/Unit/fixunssfdi_test.c


Index: test/builtins/Unit/fixunssfdi_test.c
===
--- test/builtins/Unit/fixunssfdi_test.c
+++ test/builtins/Unit/fixunssfdi_test.c
@@ -79,8 +79,6 @@
 return 1;
 if (test__fixunssfdi(0x1.00p+63F, 0x8000LL))
 return 1;
-if (test__fixunssfdi(0x1.00p+64F, 0xLL))
-return 1;
 if (test__fixunssfdi(0x1.FEp+62F, 0x7F80LL))
 return 1;
 if (test__fixunssfdi(0x1.FCp+62F, 0x7F00LL))
Index: test/builtins/Unit/fixunsdfdi_test.c
===
--- test/builtins/Unit/fixunsdfdi_test.c
+++ test/builtins/Unit/fixunsdfdi_test.c
@@ -95,9 +95,6 @@
 if (test__fixunsdfdi(0x1.Ep+62, 0x7800LL))
 return 1;
 
-if (test__fixunsdfdi(0x1.p+64, 0xLL))
-return 1;
-
 #if !TARGET_LIBGCC
 if (test__fixunsdfdi(-0x1.Fp+62, 0))
 return 1;


Index: test/builtins/Unit/fixunssfdi_test.c
===
--- test/builtins/Unit/fixunssfdi_test.c
+++ test/builtins/Unit/fixunssfdi_test.c
@@ -79,8 +79,6 @@
 return 1;
 if (test__fixunssfdi(0x1.00p+63F, 0x8000LL))
 return 1;
-if (test__fixunssfdi(0x1.00p+64F, 0xLL))
-return 1;
 if (test__fixunssfdi(0x1.FEp+62F, 0x7F80LL))
 return 1;
 if (test__fixunssfdi(0x1.FCp+62F, 0x7F00LL))
Index: test/builtins/Unit/fixunsdfdi_test.c
===
--- test/builtins/Unit/fixunsdfdi_test.c
+++ test/builtins/Unit/fixunsdfdi_test.c
@@ -95,9 +95,6 @@
 if (test__fixunsdfdi(0x1.Ep+62, 0x7800LL))
 return 1;
 
-if (test__fixunsdfdi(0x1.p+64, 0xLL))
-return 1;
-
 #if !TARGET_LIBGCC
 if (test__fixunsdfdi(-0x1.Fp+62, 0))
 return 1;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits