[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies
doug.gregor added a comment. LGTM, thank you! Repository: rL LLVM https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies
arphaman added a comment. Generally such NFC patches can be committed directly as they can be reviewed after the commit Repository: rL LLVM https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies
This revision was automatically updated to reflect the committed changes. Closed by commit rL310609: [Parse] Document PrintStats, SkipFunctionBodies (authored by modocache). Repository: rL LLVM https://reviews.llvm.org/D36530 Files: cfe/trunk/include/clang/Parse/ParseAST.h Index: cfe/trunk/include/clang/Parse/ParseAST.h === --- cfe/trunk/include/clang/Parse/ParseAST.h +++ cfe/trunk/include/clang/Parse/ParseAST.h @@ -29,10 +29,13 @@ /// This operation inserts the parsed decls into the translation /// unit held by Ctx. /// + /// \param PrintStats Whether to print LLVM statistics related to parsing. /// \param TUKind The kind of translation unit being parsed. - /// /// \param CompletionConsumer If given, an object to consume code completion /// results. + /// \param SkipFunctionBodies Whether to skip parsing of function bodies. + /// This option can be used, for example, to speed up searches for + /// delcarations/definitions when indexing. void ParseAST(Preprocessor , ASTConsumer *C, ASTContext , bool PrintStats = false, TranslationUnitKind TUKind = TU_Complete, @@ -43,7 +46,7 @@ /// abstract syntax tree. void ParseAST(Sema , bool PrintStats = false, bool SkipFunctionBodies = false); - + } // end namespace clang #endif Index: cfe/trunk/include/clang/Parse/ParseAST.h === --- cfe/trunk/include/clang/Parse/ParseAST.h +++ cfe/trunk/include/clang/Parse/ParseAST.h @@ -29,10 +29,13 @@ /// This operation inserts the parsed decls into the translation /// unit held by Ctx. /// + /// \param PrintStats Whether to print LLVM statistics related to parsing. /// \param TUKind The kind of translation unit being parsed. - /// /// \param CompletionConsumer If given, an object to consume code completion /// results. + /// \param SkipFunctionBodies Whether to skip parsing of function bodies. + /// This option can be used, for example, to speed up searches for + /// delcarations/definitions when indexing. void ParseAST(Preprocessor , ASTConsumer *C, ASTContext , bool PrintStats = false, TranslationUnitKind TUKind = TU_Complete, @@ -43,7 +46,7 @@ /// abstract syntax tree. void ParseAST(Sema , bool PrintStats = false, bool SkipFunctionBodies = false); - + } // end namespace clang #endif ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies
modocache added a comment. Oops, sorry. I couldn't find anyone recent in the commit history. I hope no one minds if I just go ahead and commit this. https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies
craig.topper resigned from this revision. craig.topper added a comment. Guessing I'm only on here because I did the bulk of the 0->nullptr changes to clang a few years back. https://reviews.llvm.org/D36530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies
modocache created this revision. Add documentation for `clang::ParseAST` parameters `PrintStats` and `SkipFunctionBodies`. Also, remove a tiny bit of trailing whitespace. https://reviews.llvm.org/D36530 Files: include/clang/Parse/ParseAST.h Index: include/clang/Parse/ParseAST.h === --- include/clang/Parse/ParseAST.h +++ include/clang/Parse/ParseAST.h @@ -29,10 +29,13 @@ /// This operation inserts the parsed decls into the translation /// unit held by Ctx. /// + /// \param PrintStats Whether to print LLVM statistics related to parsing. /// \param TUKind The kind of translation unit being parsed. - /// /// \param CompletionConsumer If given, an object to consume code completion /// results. + /// \param SkipFunctionBodies Whether to skip parsing of function bodies. + /// This option can be used, for example, to speed up searches for + /// delcarations/definitions when indexing. void ParseAST(Preprocessor , ASTConsumer *C, ASTContext , bool PrintStats = false, TranslationUnitKind TUKind = TU_Complete, @@ -43,7 +46,7 @@ /// abstract syntax tree. void ParseAST(Sema , bool PrintStats = false, bool SkipFunctionBodies = false); - + } // end namespace clang #endif Index: include/clang/Parse/ParseAST.h === --- include/clang/Parse/ParseAST.h +++ include/clang/Parse/ParseAST.h @@ -29,10 +29,13 @@ /// This operation inserts the parsed decls into the translation /// unit held by Ctx. /// + /// \param PrintStats Whether to print LLVM statistics related to parsing. /// \param TUKind The kind of translation unit being parsed. - /// /// \param CompletionConsumer If given, an object to consume code completion /// results. + /// \param SkipFunctionBodies Whether to skip parsing of function bodies. + /// This option can be used, for example, to speed up searches for + /// delcarations/definitions when indexing. void ParseAST(Preprocessor , ASTConsumer *C, ASTContext , bool PrintStats = false, TranslationUnitKind TUKind = TU_Complete, @@ -43,7 +46,7 @@ /// abstract syntax tree. void ParseAST(Sema , bool PrintStats = false, bool SkipFunctionBodies = false); - + } // end namespace clang #endif ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
