[PATCH] D37479: run-clang-tidy: Report progress
florian.berchtold added a comment. This looks like a cool feature, why is it blocked? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37479/new/ https://reviews.llvm.org/D37479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D37479: run-clang-tidy: Report progress
Eugene.Zelenko added a comment. I think CMake output is good model for run-clang-tidy. https://reviews.llvm.org/D37479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D37479: run-clang-tidy: Report progress
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/tool/run-clang-tidy.py:155
args.quiet)
-sys.stdout.write(' '.join(invocation) + '\n')
+sys.stdout.write('[%s/%s] Running: %s' % (index+1, total_file_count, '
'.join(invocation) + '\n'))
subprocess.call(invocation)
1. Can we have these messages printed on the same line when run in a terminal?
Progress display is better when it doesn't fill the whole terminal scrollback.
Changing '\n' to '\r' should be a good start, but we also need to insure
reasonable interaction with other messages.
2. The whole invocation may be quite a large line. Maybe just print the
filename? (the rest would be repeated anyway)
https://reviews.llvm.org/D37479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D37479: run-clang-tidy: Report progress
Eugene.Zelenko added a comment. It'll be also nice to output progress in terminal when all messages will saved into file. https://reviews.llvm.org/D37479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D37479: run-clang-tidy: Report progress
kfunk added a comment. In https://reviews.llvm.org/D37479#861580, @Eugene.Zelenko wrote: > I think will be good idea to introduce command line option to control > progress display: turn it off, show in absolute numbers or percents. Honestly, I don't think this configurability is necessary. I'd like to keep that script here as simple as possible. I'll wait for some more opinions. https://reviews.llvm.org/D37479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D37479: run-clang-tidy: Report progress
Eugene.Zelenko added a comment. I think will be good idea to introduce command line option to control progress display: turn it off, show in absolute numbers or percents. https://reviews.llvm.org/D37479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
