[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

[Dan Albert via Phabricator via cfe-commits]

danalbert abandoned this revision.
danalbert added a comment.

zygoloid and nbjoerg got me pointed in the right direction on this. Looks like 
the user didn't have a key function defined for one of their classes, which was 
actually the root of the problem.


Repository:
  rL LLVM

https://reviews.llvm.org/D38827



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

[Dan Albert via Phabricator via cfe-commits]

danalbert planned changes to this revision.
danalbert added a comment.

Actually, I was wrong. This is implemented. Will update to set the flag the 
configures this and add a test.


Repository:
  rL LLVM

https://reviews.llvm.org/D38827



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

[Dan Albert via Phabricator via cfe-commits]

danalbert created this revision.
Herald added a subscriber: mgorny.

libc++ doesn't yet have the code for this, but libc++abi does. Adding
the switch to libc++ since the flag in libc++abi is
`_LIBCXX_DYNAMIC_FALLBACK`, not `_LIBCXXABI_DYNAMIC_FALLBACK`, and it
will be needed here as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D38827

Files:
  CMakeLists.txt


Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -103,6 +103,7 @@
 option(LIBCXX_ABI_FORCE_MICROSOFT "Ignore auto-detection and force use of the 
Microsoft ABI.")
 set(LIBCXX_ABI_DEFINES "" CACHE STRING "A semicolon separated list of ABI 
macros to define in the site config header.")
 option(LIBCXX_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)
+option(LIBCXX_DYNAMIC_FALLBACK  "Use strcmp fallback for comparing 
type_infos." OFF)
 
 if (NOT LIBCXX_ENABLE_SHARED AND NOT LIBCXX_ENABLE_STATIC)
   message(FATAL_ERROR "libc++ must be built as either a shared or static 
library.")


Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -103,6 +103,7 @@
 option(LIBCXX_ABI_FORCE_MICROSOFT "Ignore auto-detection and force use of the Microsoft ABI.")
 set(LIBCXX_ABI_DEFINES "" CACHE STRING "A semicolon separated list of ABI macros to define in the site config header.")
 option(LIBCXX_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)
+option(LIBCXX_DYNAMIC_FALLBACK  "Use strcmp fallback for comparing type_infos." OFF)
 
 if (NOT LIBCXX_ENABLE_SHARED AND NOT LIBCXX_ENABLE_STATIC)
   message(FATAL_ERROR "libc++ must be built as either a shared or static library.")
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits