[PATCH] D39161: [bindings] remove unique_external test failure

2017-11-11 Thread Masud Rahman via Phabricator via cfe-commits 
frutiger abandoned this revision.
frutiger added a comment.

Fixed by r317986.


https://reviews.llvm.org/D39161



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39161: [bindings] remove unique_external test failure

2017-11-10 Thread Masud Rahman via Phabricator via cfe-commits 
frutiger added a comment.

Thanks for the note, I'll wait.


https://reviews.llvm.org/D39161



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39161: [bindings] remove unique_external test failure

2017-11-10 Thread Michał Górny via Phabricator via cfe-commits 
mgorny added a comment.

I've rewritten the tests to use `unittest`, so this patch needs to be updated 
now. However, you may want to wait a while since @compnerd promised to look at 
it and he might have a way to get `uniqueExternal()` linkage.


https://reviews.llvm.org/D39161



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39161: [bindings] remove unique_external test failure

2017-11-09 Thread Michał Górny via Phabricator via cfe-commits 
mgorny added reviewers: jbcoe, aaron.ballman.
mgorny added a comment.

Let's try some more reviewers.


https://reviews.llvm.org/D39161



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39161: [bindings] remove unique_external test failure

2017-11-08 Thread Masud Rahman via Phabricator via cfe-commits 
frutiger added a comment.

Friendly poke @rsmith @compnerd


https://reviews.llvm.org/D39161



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39161: [bindings] remove unique_external test failure

2017-10-21 Thread Masud Rahman via Phabricator via cfe-commits 
frutiger added a comment.

I was unable to produce a simple test case that would still result in a cursor 
with 'unique external' linkage.  @rsmith I would appreciate if you can think of 
a symbol that may still have this kind of linkage.  Thanks!


https://reviews.llvm.org/D39161



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39161: [bindings] remove unique_external test failure

2017-10-21 Thread Masud Rahman via Phabricator via cfe-commits 
frutiger created this revision.

In SVN r314037, linkage determination of a symbol was significantly
refactored.  This resulted in extern anonymous namespace declarations to
no longer be considered 'unique_external'.  This ultimately broke a test
in the Python bindings.

This commit removes the 'unique_external' test case.


https://reviews.llvm.org/D39161

Files:
  bindings/python/tests/cindex/test_linkage.py


Index: bindings/python/tests/cindex/test_linkage.py
===
--- bindings/python/tests/cindex/test_linkage.py
+++ bindings/python/tests/cindex/test_linkage.py
@@ -12,7 +12,6 @@
 tu = get_tu("""
 void foo() { int no_linkage; }
 static int internal;
-namespace { extern int unique_external; }
 extern int external;
 """, lang = 'cpp')
 
@@ -22,9 +21,6 @@
 internal = get_cursor(tu.cursor, 'internal')
 assert internal.linkage == LinkageKind.INTERNAL
 
-unique_external = get_cursor(tu.cursor, 'unique_external')
-assert unique_external.linkage == LinkageKind.UNIQUE_EXTERNAL
-
 external = get_cursor(tu.cursor, 'external')
 assert external.linkage == LinkageKind.EXTERNAL
 


Index: bindings/python/tests/cindex/test_linkage.py
===
--- bindings/python/tests/cindex/test_linkage.py
+++ bindings/python/tests/cindex/test_linkage.py
@@ -12,7 +12,6 @@
 tu = get_tu("""
 void foo() { int no_linkage; }
 static int internal;
-namespace { extern int unique_external; }
 extern int external;
 """, lang = 'cpp')
 
@@ -22,9 +21,6 @@
 internal = get_cursor(tu.cursor, 'internal')
 assert internal.linkage == LinkageKind.INTERNAL
 
-unique_external = get_cursor(tu.cursor, 'unique_external')
-assert unique_external.linkage == LinkageKind.UNIQUE_EXTERNAL
-
 external = get_cursor(tu.cursor, 'external')
 assert external.linkage == LinkageKind.EXTERNAL
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits