[PATCH] D41935: [analyzer] NFC: Mark default constructors for ProgramPoints.

[Phabricator via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL322798: [analyzer] NFC: Use = default for 
default ProgramPoint constructors. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D41935?vs=129391=130322#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D41935

Files:
  cfe/trunk/include/clang/Analysis/ProgramPoint.h

Index: cfe/trunk/include/clang/Analysis/ProgramPoint.h
===
--- cfe/trunk/include/clang/Analysis/ProgramPoint.h
+++ cfe/trunk/include/clang/Analysis/ProgramPoint.h
@@ -98,7 +98,7 @@
   llvm::PointerIntPair Tag;
 
 protected:
-  ProgramPoint() {}
+  ProgramPoint() = default;
   ProgramPoint(const void *P,
Kind k,
const LocationContext *l,
@@ -234,7 +234,7 @@
   
 private:
   friend class ProgramPoint;
-  BlockEntrance() {}
+  BlockEntrance() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockEntranceKind;
   }
@@ -255,7 +255,7 @@
 
 private:
   friend class ProgramPoint;
-  BlockExit() {}
+  BlockExit() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockExitKind;
   }
@@ -275,7 +275,7 @@
   const T* getStmtAs() const { return dyn_cast(getStmt()); }
 
 protected:
-  StmtPoint() {}
+  StmtPoint() = default;
 private:
   friend class ProgramPoint;
   static bool isKind(const ProgramPoint ) {
@@ -295,15 +295,15 @@
 
 private:
   friend class ProgramPoint;
-  PreStmt() {}
+  PreStmt() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreStmtKind;
   }
 };
 
 class PostStmt : public StmtPoint {
 protected:
-  PostStmt() {}
+  PostStmt() = default;
   PostStmt(const Stmt *S, const void *data, Kind k, const LocationContext *L,
const ProgramPointTag *tag = nullptr)
 : StmtPoint(S, data, k, L, tag) {}
@@ -334,15 +334,15 @@
 
 private:
   friend class ProgramPoint;
-  PostCondition() {}
+  PostCondition() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostConditionKind;
   }
 };
 
 class LocationCheck : public StmtPoint {
 protected:
-  LocationCheck() {}
+  LocationCheck() = default;
   LocationCheck(const Stmt *S, const LocationContext *L,
 ProgramPoint::Kind K, const ProgramPointTag *tag)
 : StmtPoint(S, nullptr, K, L, tag) {}
@@ -363,7 +363,7 @@
   
 private:
   friend class ProgramPoint;
-  PreLoad() {}
+  PreLoad() = default;
   static bool isKind(const ProgramPoint ) {
 return location.getKind() == PreLoadKind;
   }
@@ -377,7 +377,7 @@
   
 private:
   friend class ProgramPoint;
-  PreStore() {}
+  PreStore() = default;
   static bool isKind(const ProgramPoint ) {
 return location.getKind() == PreStoreKind;
   }
@@ -391,7 +391,7 @@
 
 private:
   friend class ProgramPoint;
-  PostLoad() {}
+  PostLoad() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostLoadKind;
   }
@@ -418,7 +418,7 @@
 
 private:
   friend class ProgramPoint;
-  PostStore() {}
+  PostStore() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostStoreKind;
   }
@@ -432,7 +432,7 @@
 
 private:
   friend class ProgramPoint;
-  PostLValue() {}
+  PostLValue() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostLValueKind;
   }
@@ -448,7 +448,7 @@
 
 private:
   friend class ProgramPoint;
-  PreStmtPurgeDeadSymbols() {}
+  PreStmtPurgeDeadSymbols() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreStmtPurgeDeadSymbolsKind;
   }
@@ -464,7 +464,7 @@
 
 private:
   friend class ProgramPoint;
-  PostStmtPurgeDeadSymbols() {}
+  PostStmtPurgeDeadSymbols() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostStmtPurgeDeadSymbolsKind;
   }
@@ -488,7 +488,7 @@
 
 private:
   friend class ProgramPoint;
-  BlockEdge() {}
+  BlockEdge() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockEdgeKind;
   }
@@ -517,7 +517,7 @@
 
 private:
   friend class ProgramPoint;
-  PostInitializer() {}
+  PostInitializer() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostInitializerKind;
   }
@@ -538,7 +538,7 @@
   }
 
 protected:
-  ImplicitCallPoint() {}
+  ImplicitCallPoint() = default;
 private:
   friend class ProgramPoint;
   static bool isKind(const ProgramPoint ) {
@@ -558,7 +558,7 @@
 
 private:
   friend class ProgramPoint;
-  PreImplicitCall() {}
+  PreImplicitCall() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreImplicitCallKind;
   }
@@ -575,7 +575,7 @@
 
 private:
   friend class ProgramPoint;
-  PostImplicitCall() {}
+  PostImplicitCall() = default;
   static bool isKind(const 

[PATCH] D41935: [analyzer] NFC: Mark default constructors for ProgramPoints.

[Phabricator via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rC322798: [analyzer] NFC: Use = default for 
default ProgramPoint constructors. (authored by dergachev, committed by ).

Repository:
  rC Clang

https://reviews.llvm.org/D41935

Files:
  include/clang/Analysis/ProgramPoint.h

Index: include/clang/Analysis/ProgramPoint.h
===
--- include/clang/Analysis/ProgramPoint.h
+++ include/clang/Analysis/ProgramPoint.h
@@ -98,7 +98,7 @@
   llvm::PointerIntPair Tag;
 
 protected:
-  ProgramPoint() {}
+  ProgramPoint() = default;
   ProgramPoint(const void *P,
Kind k,
const LocationContext *l,
@@ -234,7 +234,7 @@
   
 private:
   friend class ProgramPoint;
-  BlockEntrance() {}
+  BlockEntrance() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockEntranceKind;
   }
@@ -255,7 +255,7 @@
 
 private:
   friend class ProgramPoint;
-  BlockExit() {}
+  BlockExit() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockExitKind;
   }
@@ -275,7 +275,7 @@
   const T* getStmtAs() const { return dyn_cast(getStmt()); }
 
 protected:
-  StmtPoint() {}
+  StmtPoint() = default;
 private:
   friend class ProgramPoint;
   static bool isKind(const ProgramPoint ) {
@@ -295,15 +295,15 @@
 
 private:
   friend class ProgramPoint;
-  PreStmt() {}
+  PreStmt() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreStmtKind;
   }
 };
 
 class PostStmt : public StmtPoint {
 protected:
-  PostStmt() {}
+  PostStmt() = default;
   PostStmt(const Stmt *S, const void *data, Kind k, const LocationContext *L,
const ProgramPointTag *tag = nullptr)
 : StmtPoint(S, data, k, L, tag) {}
@@ -334,15 +334,15 @@
 
 private:
   friend class ProgramPoint;
-  PostCondition() {}
+  PostCondition() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostConditionKind;
   }
 };
 
 class LocationCheck : public StmtPoint {
 protected:
-  LocationCheck() {}
+  LocationCheck() = default;
   LocationCheck(const Stmt *S, const LocationContext *L,
 ProgramPoint::Kind K, const ProgramPointTag *tag)
 : StmtPoint(S, nullptr, K, L, tag) {}
@@ -363,7 +363,7 @@
   
 private:
   friend class ProgramPoint;
-  PreLoad() {}
+  PreLoad() = default;
   static bool isKind(const ProgramPoint ) {
 return location.getKind() == PreLoadKind;
   }
@@ -377,7 +377,7 @@
   
 private:
   friend class ProgramPoint;
-  PreStore() {}
+  PreStore() = default;
   static bool isKind(const ProgramPoint ) {
 return location.getKind() == PreStoreKind;
   }
@@ -391,7 +391,7 @@
 
 private:
   friend class ProgramPoint;
-  PostLoad() {}
+  PostLoad() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostLoadKind;
   }
@@ -418,7 +418,7 @@
 
 private:
   friend class ProgramPoint;
-  PostStore() {}
+  PostStore() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostStoreKind;
   }
@@ -432,7 +432,7 @@
 
 private:
   friend class ProgramPoint;
-  PostLValue() {}
+  PostLValue() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostLValueKind;
   }
@@ -448,7 +448,7 @@
 
 private:
   friend class ProgramPoint;
-  PreStmtPurgeDeadSymbols() {}
+  PreStmtPurgeDeadSymbols() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreStmtPurgeDeadSymbolsKind;
   }
@@ -464,7 +464,7 @@
 
 private:
   friend class ProgramPoint;
-  PostStmtPurgeDeadSymbols() {}
+  PostStmtPurgeDeadSymbols() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostStmtPurgeDeadSymbolsKind;
   }
@@ -488,7 +488,7 @@
 
 private:
   friend class ProgramPoint;
-  BlockEdge() {}
+  BlockEdge() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockEdgeKind;
   }
@@ -517,7 +517,7 @@
 
 private:
   friend class ProgramPoint;
-  PostInitializer() {}
+  PostInitializer() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostInitializerKind;
   }
@@ -538,7 +538,7 @@
   }
 
 protected:
-  ImplicitCallPoint() {}
+  ImplicitCallPoint() = default;
 private:
   friend class ProgramPoint;
   static bool isKind(const ProgramPoint ) {
@@ -558,7 +558,7 @@
 
 private:
   friend class ProgramPoint;
-  PreImplicitCall() {}
+  PreImplicitCall() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreImplicitCallKind;
   }
@@ -575,7 +575,7 @@
 
 private:
   friend class ProgramPoint;
-  PostImplicitCall() {}
+  PostImplicitCall() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostImplicitCallKind;
   }
@@ -589,7 +589,7 @@
 
 private:
   friend class ProgramPoint;
-  

[PATCH] D41935: [analyzer] NFC: Mark default constructors for ProgramPoints.

[Devin Coughlin via Phabricator via cfe-commits]

dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.

LGTM!


Repository:
  rC Clang

https://reviews.llvm.org/D41935



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41935: [analyzer] NFC: Mark default constructors for ProgramPoints.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet.

As suggested by Gabor in https://reviews.llvm.org/D41800, replace `{}` with `= 
default` for `ProgramPoint` default constructors.


Repository:
  rC Clang

https://reviews.llvm.org/D41935

Files:
  include/clang/Analysis/ProgramPoint.h

Index: include/clang/Analysis/ProgramPoint.h
===
--- include/clang/Analysis/ProgramPoint.h
+++ include/clang/Analysis/ProgramPoint.h
@@ -98,7 +98,7 @@
   llvm::PointerIntPair Tag;
 
 protected:
-  ProgramPoint() {}
+  ProgramPoint() = default;
   ProgramPoint(const void *P,
Kind k,
const LocationContext *l,
@@ -234,7 +234,7 @@
   
 private:
   friend class ProgramPoint;
-  BlockEntrance() {}
+  BlockEntrance() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockEntranceKind;
   }
@@ -255,7 +255,7 @@
 
 private:
   friend class ProgramPoint;
-  BlockExit() {}
+  BlockExit() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockExitKind;
   }
@@ -275,7 +275,7 @@
   const T* getStmtAs() const { return dyn_cast(getStmt()); }
 
 protected:
-  StmtPoint() {}
+  StmtPoint() = default;
 private:
   friend class ProgramPoint;
   static bool isKind(const ProgramPoint ) {
@@ -295,15 +295,15 @@
 
 private:
   friend class ProgramPoint;
-  PreStmt() {}
+  PreStmt() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreStmtKind;
   }
 };
 
 class PostStmt : public StmtPoint {
 protected:
-  PostStmt() {}
+  PostStmt() = default;
   PostStmt(const Stmt *S, const void *data, Kind k, const LocationContext *L,
const ProgramPointTag *tag = nullptr)
 : StmtPoint(S, data, k, L, tag) {}
@@ -334,15 +334,15 @@
 
 private:
   friend class ProgramPoint;
-  PostCondition() {}
+  PostCondition() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostConditionKind;
   }
 };
 
 class LocationCheck : public StmtPoint {
 protected:
-  LocationCheck() {}
+  LocationCheck() = default;
   LocationCheck(const Stmt *S, const LocationContext *L,
 ProgramPoint::Kind K, const ProgramPointTag *tag)
 : StmtPoint(S, nullptr, K, L, tag) {}
@@ -363,7 +363,7 @@
   
 private:
   friend class ProgramPoint;
-  PreLoad() {}
+  PreLoad() = default;
   static bool isKind(const ProgramPoint ) {
 return location.getKind() == PreLoadKind;
   }
@@ -377,7 +377,7 @@
   
 private:
   friend class ProgramPoint;
-  PreStore() {}
+  PreStore() = default;
   static bool isKind(const ProgramPoint ) {
 return location.getKind() == PreStoreKind;
   }
@@ -391,7 +391,7 @@
 
 private:
   friend class ProgramPoint;
-  PostLoad() {}
+  PostLoad() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostLoadKind;
   }
@@ -418,7 +418,7 @@
 
 private:
   friend class ProgramPoint;
-  PostStore() {}
+  PostStore() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostStoreKind;
   }
@@ -432,7 +432,7 @@
 
 private:
   friend class ProgramPoint;
-  PostLValue() {}
+  PostLValue() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostLValueKind;
   }
@@ -448,7 +448,7 @@
 
 private:
   friend class ProgramPoint;
-  PreStmtPurgeDeadSymbols() {}
+  PreStmtPurgeDeadSymbols() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreStmtPurgeDeadSymbolsKind;
   }
@@ -464,7 +464,7 @@
 
 private:
   friend class ProgramPoint;
-  PostStmtPurgeDeadSymbols() {}
+  PostStmtPurgeDeadSymbols() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostStmtPurgeDeadSymbolsKind;
   }
@@ -488,7 +488,7 @@
 
 private:
   friend class ProgramPoint;
-  BlockEdge() {}
+  BlockEdge() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == BlockEdgeKind;
   }
@@ -517,7 +517,7 @@
 
 private:
   friend class ProgramPoint;
-  PostInitializer() {}
+  PostInitializer() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostInitializerKind;
   }
@@ -538,7 +538,7 @@
   }
 
 protected:
-  ImplicitCallPoint() {}
+  ImplicitCallPoint() = default;
 private:
   friend class ProgramPoint;
   static bool isKind(const ProgramPoint ) {
@@ -558,7 +558,7 @@
 
 private:
   friend class ProgramPoint;
-  PreImplicitCall() {}
+  PreImplicitCall() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PreImplicitCallKind;
   }
@@ -575,7 +575,7 @@
 
 private:
   friend class ProgramPoint;
-  PostImplicitCall() {}
+  PostImplicitCall() = default;
   static bool isKind(const ProgramPoint ) {
 return Location.getKind() == PostImplicitCallKind;
   }
@@ -589,7 +589,7 @@