[PATCH] D43226: __threading_support: Remove (void) in favor of ().

2019-07-01 Thread Bruce Mitchener via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL364799: __threading_support: Remove (void) in favor of (). 
(authored by brucem, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43226/new/

https://reviews.llvm.org/D43226

Files:
  libcxx/trunk/include/__threading_support


Index: libcxx/trunk/include/__threading_support
===
--- libcxx/trunk/include/__threading_support
+++ libcxx/trunk/include/__threading_support
@@ -158,7 +158,7 @@
 // Execute once
 _LIBCPP_THREAD_ABI_VISIBILITY
 int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
-  void (*init_routine)(void));
+  void (*init_routine)());
 
 // Thread id
 _LIBCPP_THREAD_ABI_VISIBILITY
@@ -301,7 +301,7 @@
 
 // Execute once
 int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
-  void (*init_routine)(void)) {
+  void (*init_routine)()) {
   return pthread_once(flag, init_routine);
 }
 


Index: libcxx/trunk/include/__threading_support
===
--- libcxx/trunk/include/__threading_support
+++ libcxx/trunk/include/__threading_support
@@ -158,7 +158,7 @@
 // Execute once
 _LIBCPP_THREAD_ABI_VISIBILITY
 int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
-  void (*init_routine)(void));
+  void (*init_routine)());
 
 // Thread id
 _LIBCPP_THREAD_ABI_VISIBILITY
@@ -301,7 +301,7 @@
 
 // Execute once
 int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
-  void (*init_routine)(void)) {
+  void (*init_routine)()) {
   return pthread_once(flag, init_routine);
 }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

2019-06-03 Thread Marshall Clow via Phabricator via cfe-commits 
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

This looks fine to me.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43226/new/

https://reviews.llvm.org/D43226



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

2019-06-01 Thread Bruce Mitchener via Phabricator via cfe-commits 
brucem added a comment.
Herald added subscribers: libcxx-commits, ldionne.

Can we revive this review? I'd still like to land it ...


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43226/new/

https://reviews.llvm.org/D43226



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

2018-02-15 Thread Bruce Mitchener via Phabricator via cfe-commits 
brucem added a comment.

This is `modernize-redundant-void-arg`: 
https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html


Repository:
  rCXX libc++

https://reviews.llvm.org/D43226



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

2018-02-15 Thread Marshall Clow via Phabricator via cfe-commits 
mclow.lists added a comment.
Herald added a subscriber: christof.

Which clang-tidy module generates this warning, and what is the actual warning?


Repository:
  rCXX libc++

https://reviews.llvm.org/D43226



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

2018-02-13 Thread Bruce Mitchener via Phabricator via cfe-commits 
brucem created this revision.
brucem added reviewers: mclow.lists, EricWF.

This fixes a clang-tidy warning when building something that uses
this file.


Repository:
  rCXX libc++

https://reviews.llvm.org/D43226

Files:
  include/__threading_support


Index: include/__threading_support
===
--- include/__threading_support
+++ include/__threading_support
@@ -160,7 +160,7 @@
 // Execute once
 _LIBCPP_THREAD_ABI_VISIBILITY
 int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
-  void (*init_routine)(void));
+  void (*init_routine)());
 
 // Thread id
 _LIBCPP_THREAD_ABI_VISIBILITY
@@ -303,7 +303,7 @@
 
 // Execute once
 int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
-  void (*init_routine)(void)) {
+  void (*init_routine)()) {
   return pthread_once(flag, init_routine);
 }
 


Index: include/__threading_support
===
--- include/__threading_support
+++ include/__threading_support
@@ -160,7 +160,7 @@
 // Execute once
 _LIBCPP_THREAD_ABI_VISIBILITY
 int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
-  void (*init_routine)(void));
+  void (*init_routine)());
 
 // Thread id
 _LIBCPP_THREAD_ABI_VISIBILITY
@@ -303,7 +303,7 @@
 
 // Execute once
 int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
-  void (*init_routine)(void)) {
+  void (*init_routine)()) {
   return pthread_once(flag, init_routine);
 }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits