[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.
craig.topper added a comment. Is this ok to go in then? Repository: rC Clang https://reviews.llvm.org/D46328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.
efriedma added a comment. We don't expect user code to call these builtins directly anyway, so probably not useful to test. Repository: rC Clang https://reviews.llvm.org/D46328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.
craig.topper added a subscriber: eli.friedman. craig.topper added a comment. @eli.friedman is that test worth doing? Would we do it for every builtin? Repository: rC Clang https://reviews.llvm.org/D46328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.
efriedma added a comment. You could write a test like `static_assert(noexcept(__builtin_ia32_bzhi_di(0,0)), "");`. I don't think it has any other effect. Repository: rC Clang https://reviews.llvm.org/D46328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.
spatel added a comment. Seems right, but I don't know much about nothrow. Does some other attribute on these intrinsics suppress the possibility of throwing an exception? Ie, is there some way to test this? I can't seem to produce catch/landingpad IR even after putting an intrinsic in a 'try' with 'catch'. Repository: rC Clang https://reviews.llvm.org/D46328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
