[PATCH] D50674: [libc++] Add missing #include in C11 features tests
This revision was automatically updated to reflect the committed changes. Closed by commit rL339675: [libc++] Add missing #include in C11 features tests (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50674?vs=160475&id=160567#toc Repository: rL LLVM https://reviews.llvm.org/D50674 Files: libcxx/trunk/test/libcxx/language.support/has_c11_features.pass.cpp libcxx/trunk/test/std/depr/depr.c.headers/float_h.pass.cpp libcxx/trunk/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp Index: libcxx/trunk/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp === --- libcxx/trunk/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp +++ libcxx/trunk/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp @@ -11,6 +11,8 @@ #include +#include "test_macros.h" + #ifndef FLT_ROUNDS #error FLT_ROUNDS not defined #endif Index: libcxx/trunk/test/std/depr/depr.c.headers/float_h.pass.cpp === --- libcxx/trunk/test/std/depr/depr.c.headers/float_h.pass.cpp +++ libcxx/trunk/test/std/depr/depr.c.headers/float_h.pass.cpp @@ -11,6 +11,8 @@ #include +#include "test_macros.h" + #ifndef FLT_ROUNDS #error FLT_ROUNDS not defined #endif Index: libcxx/trunk/test/libcxx/language.support/has_c11_features.pass.cpp === --- libcxx/trunk/test/libcxx/language.support/has_c11_features.pass.cpp +++ libcxx/trunk/test/libcxx/language.support/has_c11_features.pass.cpp @@ -14,6 +14,9 @@ // _LIBCPP_HAS_C11_FEATURES - which is defined in <__config> // They should always be the same +#include <__config> +#include "test_macros.h" + #ifdef TEST_HAS_C11_FEATURES # ifndef _LIBCPP_HAS_C11_FEATURES # error "TEST_HAS_C11_FEATURES is defined, but _LIBCPP_HAS_C11_FEATURES is not" Index: libcxx/trunk/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp === --- libcxx/trunk/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp +++ libcxx/trunk/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp @@ -11,6 +11,8 @@ #include +#include "test_macros.h" + #ifndef FLT_ROUNDS #error FLT_ROUNDS not defined #endif Index: libcxx/trunk/test/std/depr/depr.c.headers/float_h.pass.cpp === --- libcxx/trunk/test/std/depr/depr.c.headers/float_h.pass.cpp +++ libcxx/trunk/test/std/depr/depr.c.headers/float_h.pass.cpp @@ -11,6 +11,8 @@ #include +#include "test_macros.h" + #ifndef FLT_ROUNDS #error FLT_ROUNDS not defined #endif Index: libcxx/trunk/test/libcxx/language.support/has_c11_features.pass.cpp === --- libcxx/trunk/test/libcxx/language.support/has_c11_features.pass.cpp +++ libcxx/trunk/test/libcxx/language.support/has_c11_features.pass.cpp @@ -14,6 +14,9 @@ // _LIBCPP_HAS_C11_FEATURES - which is defined in <__config> // They should always be the same +#include <__config> +#include "test_macros.h" + #ifdef TEST_HAS_C11_FEATURES # ifndef _LIBCPP_HAS_C11_FEATURES # error "TEST_HAS_C11_FEATURES is defined, but _LIBCPP_HAS_C11_FEATURES is not" ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50674: [libc++] Add missing #include in C11 features tests
hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. Good catch! Repository: rCXX libc++ https://reviews.llvm.org/D50674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50674: [libc++] Add missing #include in C11 features tests
ldionne created this revision. ldionne added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof. These #includes are quite important, since otherwise any #if TEST_STD_VER > 14 && defined(TEST_HAS_C11_FEATURES) checks are always false, and so we don't actually test for C11 support in the standard library. Repository: rCXX libc++ https://reviews.llvm.org/D50674 Files: libcxx/test/libcxx/language.support/has_c11_features.pass.cpp libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp Index: libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp === --- libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp +++ libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp @@ -11,6 +11,8 @@ #include +#include "test_macros.h" + #ifndef FLT_ROUNDS #error FLT_ROUNDS not defined #endif Index: libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp === --- libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp +++ libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp @@ -11,6 +11,8 @@ #include +#include "test_macros.h" + #ifndef FLT_ROUNDS #error FLT_ROUNDS not defined #endif Index: libcxx/test/libcxx/language.support/has_c11_features.pass.cpp === --- libcxx/test/libcxx/language.support/has_c11_features.pass.cpp +++ libcxx/test/libcxx/language.support/has_c11_features.pass.cpp @@ -14,6 +14,9 @@ // _LIBCPP_HAS_C11_FEATURES - which is defined in <__config> // They should always be the same +#include <__config> +#include "test_macros.h" + #ifdef TEST_HAS_C11_FEATURES # ifndef _LIBCPP_HAS_C11_FEATURES # error "TEST_HAS_C11_FEATURES is defined, but _LIBCPP_HAS_C11_FEATURES is not" Index: libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp === --- libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp +++ libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp @@ -11,6 +11,8 @@ #include +#include "test_macros.h" + #ifndef FLT_ROUNDS #error FLT_ROUNDS not defined #endif Index: libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp === --- libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp +++ libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp @@ -11,6 +11,8 @@ #include +#include "test_macros.h" + #ifndef FLT_ROUNDS #error FLT_ROUNDS not defined #endif Index: libcxx/test/libcxx/language.support/has_c11_features.pass.cpp === --- libcxx/test/libcxx/language.support/has_c11_features.pass.cpp +++ libcxx/test/libcxx/language.support/has_c11_features.pass.cpp @@ -14,6 +14,9 @@ // _LIBCPP_HAS_C11_FEATURES - which is defined in <__config> // They should always be the same +#include <__config> +#include "test_macros.h" + #ifdef TEST_HAS_C11_FEATURES # ifndef _LIBCPP_HAS_C11_FEATURES # error "TEST_HAS_C11_FEATURES is defined, but _LIBCPP_HAS_C11_FEATURES is not" ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
