[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation
ilya-biryukov added a comment. In https://reviews.llvm.org/D50703#1205167, @malaperle wrote: > Nah, I guess other things are partial too, like Go to Definition. Let's > assume they will be completed "soon" ;) https://reviews.llvm.org/D50889 should finally add the symbols from the main files. Sorry for the delays. Repository: rL LLVM https://reviews.llvm.org/D50703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation
malaperle added a comment. In https://reviews.llvm.org/D50703#1205109, @kbobyrev wrote: > In https://reviews.llvm.org/D50703#1205049, @malaperle wrote: > > > I hadn't marked it as done because without symbols in main files I found it > > quite lacking. > > > Ah, I see, thank you for spotting it! I was under the impression that it's > feature-complete. Should I mark it "Partial" until this is fixed then? Nah, I guess other things are partial too, like Go to Definition. Let's assume they will be completed "soon" ;) Repository: rL LLVM https://reviews.llvm.org/D50703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation
kbobyrev added a comment. In https://reviews.llvm.org/D50703#1205049, @malaperle wrote: > I hadn't marked it as done because without symbols in main files I found it > quite lacking. Ah, I see, thank you for spotting it! I was under the impression that it's feature-complete. Should I mark it "Partial" until this is fixed then? Repository: rL LLVM https://reviews.llvm.org/D50703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation
malaperle added a comment. Herald added a subscriber: kadircet. I hadn't marked it as done because without symbols in main files I found it quite lacking. Repository: rL LLVM https://reviews.llvm.org/D50703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE340007: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D50703?vs=160566=161196#toc Repository: rL LLVM https://reviews.llvm.org/D50703 Files: docs/clangd.rst Index: docs/clangd.rst === --- docs/clangd.rst +++ docs/clangd.rst @@ -64,7 +64,7 @@ | Completion | Yes| Yes| +-++--+ | Diagnostics | Yes| Yes| -+-++--+ ++-++--+ | Fix-its | Yes| Yes| +-++--+ | Go to Definition| Yes| Yes| @@ -83,7 +83,7 @@ +-++--+ | Document Symbols| Yes| Yes| +-++--+ -| Workspace Symbols | Yes| No | +| Workspace Symbols | Yes| Yes| +-++--+ | Syntax and Semantic Coloring| No | No | +-++--+ Index: docs/clangd.rst === --- docs/clangd.rst +++ docs/clangd.rst @@ -64,7 +64,7 @@ | Completion | Yes| Yes| +-++--+ | Diagnostics | Yes| Yes| -+-++--+ ++-++--+ | Fix-its | Yes| Yes| +-++--+ | Go to Definition| Yes| Yes| @@ -83,7 +83,7 @@ +-++--+ | Document Symbols| Yes| Yes| +-++--+ -| Workspace Symbols | Yes| No | +| Workspace Symbols | Yes| Yes| +-++--+ | Syntax and Semantic Coloring| No | No | +-++--+ ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation
This revision was automatically updated to reflect the committed changes. Closed by commit rL340007: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50703?vs=160566=161195#toc Repository: rL LLVM https://reviews.llvm.org/D50703 Files: clang-tools-extra/trunk/docs/clangd.rst Index: clang-tools-extra/trunk/docs/clangd.rst === --- clang-tools-extra/trunk/docs/clangd.rst +++ clang-tools-extra/trunk/docs/clangd.rst @@ -64,7 +64,7 @@ | Completion | Yes| Yes| +-++--+ | Diagnostics | Yes| Yes| -+-++--+ ++-++--+ | Fix-its | Yes| Yes| +-++--+ | Go to Definition| Yes| Yes| @@ -83,7 +83,7 @@ +-++--+ | Document Symbols| Yes| Yes| +-++--+ -| Workspace Symbols | Yes| No | +| Workspace Symbols | Yes| Yes| +-++--+ | Syntax and Semantic Coloring| No | No | +-++--+ Index: clang-tools-extra/trunk/docs/clangd.rst === --- clang-tools-extra/trunk/docs/clangd.rst +++ clang-tools-extra/trunk/docs/clangd.rst @@ -64,7 +64,7 @@ | Completion | Yes| Yes| +-++--+ | Diagnostics | Yes| Yes| -+-++--+ ++-++--+ | Fix-its | Yes| Yes| +-++--+ | Go to Definition| Yes| Yes| @@ -83,7 +83,7 @@ +-++--+ | Document Symbols| Yes| Yes| +-++--+ -| Workspace Symbols | Yes| No | +| Workspace Symbols | Yes| Yes| +-++--+ | Syntax and Semantic Coloring| No | No | +-++--+ ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation
kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. Workspace Symbol implementation was introduced in https://reviews.llvm.org/D44882 and should be complete now. https://reviews.llvm.org/D50703 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst === --- clang-tools-extra/docs/clangd.rst +++ clang-tools-extra/docs/clangd.rst @@ -64,7 +64,7 @@ | Completion | Yes| Yes| +-++--+ | Diagnostics | Yes| Yes| -+-++--+ ++-++--+ | Fix-its | Yes| Yes| +-++--+ | Go to Definition| Yes| Yes| @@ -83,7 +83,7 @@ +-++--+ | Document Symbols| Yes| Yes| +-++--+ -| Workspace Symbols | Yes| No | +| Workspace Symbols | Yes| Yes| +-++--+ | Syntax and Semantic Coloring| No | No | +-++--+ Index: clang-tools-extra/docs/clangd.rst === --- clang-tools-extra/docs/clangd.rst +++ clang-tools-extra/docs/clangd.rst @@ -64,7 +64,7 @@ | Completion | Yes| Yes| +-++--+ | Diagnostics | Yes| Yes| -+-++--+ ++-++--+ | Fix-its | Yes| Yes| +-++--+ | Go to Definition| Yes| Yes| @@ -83,7 +83,7 @@ +-++--+ | Document Symbols| Yes| Yes| +-++--+ -| Workspace Symbols | Yes| No | +| Workspace Symbols | Yes| Yes| +-++--+ | Syntax and Semantic Coloring| No | No | +-++--+ ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
