[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32
This revision was automatically updated to reflect the committed changes. Closed by commit rL342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32 (authored by pirama, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52368 Files: libcxxabi/trunk/src/private_typeinfo.cpp Index: libcxxabi/trunk/src/private_typeinfo.cpp === --- libcxxabi/trunk/src/private_typeinfo.cpp +++ libcxxabi/trunk/src/private_typeinfo.cpp @@ -64,6 +64,7 @@ return x == y; return strcmp(x->name(), y->name()) == 0; #else +(void) use_strcmp; return (x == y) || (strcmp(x->name(), y->name()) == 0); #endif } Index: libcxxabi/trunk/src/private_typeinfo.cpp === --- libcxxabi/trunk/src/private_typeinfo.cpp +++ libcxxabi/trunk/src/private_typeinfo.cpp @@ -64,6 +64,7 @@ return x == y; return strcmp(x->name(), y->name()) == 0; #else +(void) use_strcmp; return (x == y) || (strcmp(x->name(), y->name()) == 0); #endif } ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXXA libc++abi https://reviews.llvm.org/D52368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32
pirama updated this revision to Diff 166527. pirama added a comment. Simplify patch. Repository: rCXXA libc++abi https://reviews.llvm.org/D52368 Files: src/private_typeinfo.cpp Index: src/private_typeinfo.cpp === --- src/private_typeinfo.cpp +++ src/private_typeinfo.cpp @@ -64,6 +64,7 @@ return x == y; return strcmp(x->name(), y->name()) == 0; #else +(void) use_strcmp; return (x == y) || (strcmp(x->name(), y->name()) == 0); #endif } Index: src/private_typeinfo.cpp === --- src/private_typeinfo.cpp +++ src/private_typeinfo.cpp @@ -64,6 +64,7 @@ return x == y; return strcmp(x->name(), y->name()) == 0; #else +(void) use_strcmp; return (x == y) || (strcmp(x->name(), y->name()) == 0); #endif } ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32
mclow.lists added a comment. This seems like overkill to me; why not add `(void) use_strcmp` right before line 67 instead? Repository: rCXXA libc++abi https://reviews.llvm.org/D52368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32
pirama created this revision. pirama added reviewers: EricWF, srhines, mstorsjo. Herald added subscribers: libcxx-commits, ldionne, christof. Mark it as unused to avoid -Wunused-parameter. Repository: rCXXA libc++abi https://reviews.llvm.org/D52368 Files: src/private_typeinfo.cpp Index: src/private_typeinfo.cpp === --- src/private_typeinfo.cpp +++ src/private_typeinfo.cpp @@ -51,13 +51,17 @@ // Defining _LIBCXX_DYNAMIC_FALLBACK does not help since can_catch() calls // is_equal() with use_strcmp=false so the string names are not compared. +#define _UNUSED_IN_WIN32 #ifdef _WIN32 #include +#define _UNUSED_IN_WIN32 __attribute__((unused)) #endif static inline bool -is_equal(const std::type_info* x, const std::type_info* y, bool use_strcmp) +is_equal(const std::type_info* x, + const std::type_info* y, + _UNUSED_IN_WIN32 bool use_strcmp) { #ifndef _WIN32 if (!use_strcmp) Index: src/private_typeinfo.cpp === --- src/private_typeinfo.cpp +++ src/private_typeinfo.cpp @@ -51,13 +51,17 @@ // Defining _LIBCXX_DYNAMIC_FALLBACK does not help since can_catch() calls // is_equal() with use_strcmp=false so the string names are not compared. +#define _UNUSED_IN_WIN32 #ifdef _WIN32 #include +#define _UNUSED_IN_WIN32 __attribute__((unused)) #endif static inline bool -is_equal(const std::type_info* x, const std::type_info* y, bool use_strcmp) +is_equal(const std::type_info* x, + const std::type_info* y, + _UNUSED_IN_WIN32 bool use_strcmp) { #ifndef _WIN32 if (!use_strcmp) ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits